fix(web): align every titlebar control cluster on one shared inset

[juliusmarminge]

Titlebar geometry polish so the sidebar trigger, the thread view's layout controls, and the pull requests page's panel toggle all read as one family. Found while dogfooding on the orchestrator branch (#2829); ported here so both lineages agree.

What changed

• Icon size: the layout-control icons were hard-coded size-3.5 while the sidebar trigger (Button size="icon" default) and the PR page refresh icon render size-4 — the two ends of the titlebar sat a pixel apart on every edge. All layout-control icons now use size-4.
• Trigger inset symmetry: the right cluster carries mr-px (border compensation for anchoring inside the panel frame); the sidebar trigger now mirrors it with ml-px so both clusters sit one shared inset off their edges.
• Sheet-mode jump: the sheet overlays from the viewport top, but its tab bar used the compact spacing(11) row, re-centering the controls 4px higher than their closed-state titlebar position on every open. The sheet tab bar now keeps --workspace-topbar-height, and its layout-controls slot carries the mr-px so the horizontal inset matches too.
• PR page toggle: the panel toggle previously moved between an in-flow header slot (closed) and an absolute corner anchor (open). It now stays mounted at the fixed workspace-titlebar-controls inset in both states — the same anchor as the thread view — with a per-breakpoint footprint reserve in the list header so refresh never slides underneath it.

Verification

• pnpm --filter @t3tools/web typecheck clean
• Web suite: 2429/2429 passing

---

Note

Low Risk
CSS and layout-only changes to titlebar positioning and icon sizing; no auth, data, or API behavior.

Overview
Titlebar geometry is unified so sidebar trigger, thread layout controls, and PR page panel toggle read as one family and stop jumping on panel open/close.

Layout-control icons move from size-3.5 to size-4 to match the sidebar trigger and PR refresh. The sidebar trigger wrapper gains ml-px to mirror the right cluster’s mr-px. In sheet mode, the right-panel tab bar no longer forces a shorter topbar height (removed compact spacing(11) override), and sheet layout controls are wrapped with mr-px so horizontal inset matches the closed titlebar. On pull requests, panel toggles stay on the fixed workspace-titlebar-controls anchor whenever PRs are supported (not only when the panel is open); the list header uses a footprint spacer instead of in-flow toggle controls when the panel is closed so refresh doesn’t slide under the fixed toggle.

^{Reviewed by Cursor Bugbot for commit 62badc9. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Align titlebar control clusters on a shared 1px inset across all views

• Wraps right panel controls in sheet mode with a mr-px flex container in ChatView.tsx to match the shared inset.
• Updates PullRequestsRouteView to always render the titlebar control cluster when pull requests are supported, and inserts a fixed-width spacer when the right panel is closed to prevent header controls from shifting.
• Removes the conditional --workspace-topbar-height CSS variable override from RightPanelTabs in non-inline mode.
• Increases panel toggle and maximize/restore icon sizes from size-3.5 to size-4 in PanelLayoutControls.tsx.

^{Macroscope summarized 62badc9.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8a984a65-ade6-45ee-9357-cdac4f84e42c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	11.3 KiB	11.3 KiB	−32 B (−0.3%)	15.1 KiB	✅
Codex	Thread snapshot wire	5.5 KiB	5.5 KiB	−5 B (−0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	5.9 KiB	5.9 KiB	−27 B (−0.4%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	49.7 KiB	49.7 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	16	16	0 (0.0%)	21	✅
Claude	Total thread wire	11.3 KiB	11.3 KiB	−18 B (−0.2%)	15.1 KiB	✅
Claude	Thread snapshot wire	5.5 KiB	5.5 KiB	0 B (0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	5.9 KiB	5.8 KiB	−18 B (−0.3%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	50.6 KiB	50.6 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	16	16	0 (0.0%)	21	✅

Baseline: 21a3669 · PR result: 62badc9 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 94.6 KiB
• Claude decoded thread snapshot: 95.4 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{Bugbot Autofix is ON, but a cloud agent failed to start.}

^{Reviewed by Cursor Bugbot for commit 62badc9. Configure here.}

[cursor]

PR toggle overlaps refresh on safe-area

Medium Severity

The panel toggle is now absolutely placed with workspace-titlebar-controls, whose right inset includes safe-area-inset-right, but the closed-state header spacer and px-3/px-5 padding do not. On notched or landscape devices with a non-zero safe area, that shifts the toggle left over the refresh control. The overlay is z-50, so refresh can stop receiving clicks. Chat’s closed header already pads with the same safe-area token, which is why the thread view does not hit this.

Additional Locations (1)

• apps/web/src/routes/_chat.pull-requests.tsx#L1829-L1838

 

^{Reviewed by Cursor Bugbot for commit 62badc9. Configure here.}

[macroscopeapp]

Approvability

Verdict: Approved 62badc9

This PR makes mechanical CSS alignment adjustments (1px margins, icon size tweaks) to ensure titlebar control clusters sit at consistent insets across views. Changes are low-risk styling tweaks. Note: a Medium-severity finding about safe-area overlap on notched devices meets the blocking threshold and requires resolution.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Before / after

Captured on an isolated dev instance (viewport 1400×900; sheet at 900×815), same seeded state on both sides. main tip 21a3669cee vs this branch.

Thread view — right panel closed

Before	After

Icons step up from size-3.5 to size-4, matching the sidebar trigger; the trigger picks up the mirrored ml-px.

Thread view — inline panel open

Before	After

The cluster no longer shifts when the panel opens — one shared inset in both states, with the maximize control growing leftward.

Sheet open (narrow viewport)

Before	After

Before: the compact tab bar re-centers the controls ~4px higher (and 1px tighter) than their closed-state position, so they jump on every open. After: the sheet tab bar keeps the titlebar height and the cluster stays put.

Pull requests page

Before	After

Refresh + panel toggle sit at the same shared titlebar inset as the thread view's controls, and the toggle no longer moves between an in-flow slot and an absolute anchor when the panel toggles.

_{Full-resolution captures on the assets/pr-6592-titlebar-shots branch.}