fix(web): add web app manifest so installed app keeps its scope - #4306
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved Adds a static web app manifest file for PWA support. This is a simple configuration-only change with no runtime code modifications - just a JSON file specifying display properties and existing icon references. You can customize Macroscope's approvability policy. Learn more. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3cbb8eb. Configure here.
Dismissing prior approval to re-evaluate 1d66bcb
apps/web ships no manifest, so iOS infers the navigation scope of an installed home screen app from whichever URL was saved. Saving a deep link collapses scope to that single path, and every other route is treated as out of scope and handed off to an in-app browser view. Declare scope and start_url at the origin root with display standalone. Icons reuse the existing asset filenames so the publish-time brand overrides in scripts/lib/brand-assets.ts keep applying per release channel. Fixes pingdotgg#4305
APP_DISPLAY_NAME resolves per channel ("T3 Code (Nightly)", "(Alpha)",
"(Dev)") from the hosted channel or the desktop bridge, and
DocumentTitleSync keeps document.title in sync with it at runtime.
A static name/short_name in public/ cannot follow that, so a nightly
install would show the production label next to nightly-branded icons.
Making the manifest channel-aware would require generating it at build
time, since Vite does not template files in public/.
name and short_name are optional, so omitting them lets the Home Screen
label fall back to document.title, which is already correct per channel.
0431f68 to
394bf16
Compare
## What's Changed * fix(desktop): route mouse thumb buttons to the in-app browser by @akosbalogh in pingdotgg/t3code#4459 * fix(web): keep the final segment of directory paths with a trailing separator by @jorvarea in pingdotgg/t3code#5460 * Keep block code plain when copying from rendered markdown by @yashranaway in pingdotgg/t3code#4468 * fix(web): add web app manifest so installed app keeps its scope by @Albro3459 in pingdotgg/t3code#4306 * Skip user hooks during Claude capability probes by @yashranaway in pingdotgg/t3code#4466 * fix(mobile): use Android monospace font family by @tastelessjolt in pingdotgg/t3code#4609 * fix(desktop): timestamps follow the OS locale instead of en-US by @brzzdev in pingdotgg/t3code#6190 * fix(web): keep multi-select questions open after the first click by @RaitP1 in pingdotgg/t3code#6646 * fix(web): stop clipping the changed-files expand hover on Windows by @mrmg in pingdotgg/t3code#6545 * fix(server): allow long-running git pushes by @devchaudhary24k in pingdotgg/t3code#6499 * fix(desktop): keep probing backend readiness while the process is alive by @lgwacker in pingdotgg/t3code#5526 * fix(server): allow install scripts in npm-global provider updates by @hey-jj in pingdotgg/t3code#5646 * fix: detect SSH remotes with non-git user prefixes (e.g. gitlab@) by @JackatDJL in pingdotgg/t3code#3649 * fix(web): describe what Ultracode does in the Reasoning picker by @delltrak in pingdotgg/t3code#6092 * fix(server): settle pending user-input requests when a Claude session stops by @AaronAbuUsama in pingdotgg/t3code#5127 * fix(server): stop replaying a command receipt for a different aggregate by @ostapondo in pingdotgg/t3code#5246 * fix(server): settle snoozed threads immediately by @0bkevin in pingdotgg/t3code#5379 * fix(mobile): prevent crash on sign out in settings by @shubhu121 in pingdotgg/t3code#4899 * fix(mobile): local-checkout threads record their branch so PR badges show by @Zeus-Deus in pingdotgg/t3code#4986 * fix(web): contain long approval commands by @Serendeep in pingdotgg/t3code#6503 * feat(web): make right panel maximize bindable by @husseinraoouf in pingdotgg/t3code#5091 * fix(server): respect inherited OPENCODE_CONFIG_CONTENT by @jonocodes in pingdotgg/t3code#4242 * fix(marketing): detect Mac chip on homepage download button by @mahdibm-dev in pingdotgg/t3code#4197 * Keep the server alive when a response write hits a dead socket by @yashranaway in pingdotgg/t3code#4470 * Limit physical key fallback to non-Latin layout output by @yashranaway in pingdotgg/t3code#4469 * fix: restore CLAUDE.md symlink target by @NgoQuocViet2001 in pingdotgg/t3code#3929 * fix(clients): default clone destination to folder plus repo name by @inayayousfi in pingdotgg/t3code#5989 * fix(web): keep timestamp date and time in the same locale by @juliusmarminge in pingdotgg/t3code#7081 * feat(desktop): add signal macOS DMG installer background by @Brechard in pingdotgg/t3code#6201 ## New Contributors * @akosbalogh made their first contribution in pingdotgg/t3code#4459 * @jorvarea made their first contribution in pingdotgg/t3code#5460 * @yashranaway made their first contribution in pingdotgg/t3code#4468 * @Albro3459 made their first contribution in pingdotgg/t3code#4306 * @tastelessjolt made their first contribution in pingdotgg/t3code#4609 * @brzzdev made their first contribution in pingdotgg/t3code#6190 * @RaitP1 made their first contribution in pingdotgg/t3code#6646 * @devchaudhary24k made their first contribution in pingdotgg/t3code#6499 * @lgwacker made their first contribution in pingdotgg/t3code#5526 * @JackatDJL made their first contribution in pingdotgg/t3code#3649 * @delltrak made their first contribution in pingdotgg/t3code#6092 * @AaronAbuUsama made their first contribution in pingdotgg/t3code#5127 * @0bkevin made their first contribution in pingdotgg/t3code#5379 * @shubhu121 made their first contribution in pingdotgg/t3code#4899 * @Zeus-Deus made their first contribution in pingdotgg/t3code#4986 * @husseinraoouf made their first contribution in pingdotgg/t3code#5091 * @jonocodes made their first contribution in pingdotgg/t3code#4242 * @mahdibm-dev made their first contribution in pingdotgg/t3code#4197 * @NgoQuocViet2001 made their first contribution in pingdotgg/t3code#3929 * @inayayousfi made their first contribution in pingdotgg/t3code#5989 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260815.1101...v0.0.34-nightly.20260815.1102 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260815.1102

What Changed
apps/web/public/manifest.webmanifestdeclaringscopeandstart_urlat the origin root, withdisplay: standalone.<link rel="manifest" href="/manifest.webmanifest" />toapps/web/index.html.Two files, one line of HTML. No new dependencies, no service worker, no new binary assets, no runtime logic, no CSS changes.
Why
Fixes #4305.
apps/webcurrently ships no web app manifest, so thescopemember is never declared. With noscope, iOS infers the navigation scope of an installed Home Screen app from whichever URL was saved.The app redirects the origin root to the last-opened thread, so the URL captured by "Add to Home Screen" is usually
/<environmentId>/<threadId>. Scope collapses to that single thread path, and every subsequent navigation is treated as out of scope and handed off to an in-app browser view, ending the standalone session.Declaring
scope: "/"makes every route on the origin part of the app.Why the icons reuse existing filenames
scripts/lib/brand-assets.tsswaps web icons by target filename per release channel (nightly-web-apple-touch-180.pngandt3-black-web-apple-touch-180.pngboth land asapple-touch-icon.png).The manifest therefore references the existing
apple-touch-icon.pngandfavicon-32x32.pngrather than adding a new icon asset, so publish-time brand overrides keep applying and nightly builds do not ship the production mark.Testing
Verified against a real
t3 servebuild (0.0.29-nightly.20260722.878) served over HTTPS, on iOS 26.5 / Safari.Server side:
Mime.getType()inapps/server/src/http.tsresolves.webmanifestcorrectly, so no MIME handling changes are needed.Device: added to the Home Screen from a deep-linked thread URL (
/<environmentId>/<threadId>), the case that previously broke. Before the change, navigating to another thread left standalone mode and opened an in-app browser view. After the change, navigation stays inside the installed app across threads and Settings.Deliberately out of scope
apple-mobile-web-app-*meta tags. Safari 17+ honorsdisplay: standalonefrom the manifest directly.Note
Low Risk
Static manifest and one HTML link only; no auth, routing, or runtime logic changes.
Overview
Fixes iOS Home Screen installs losing standalone mode when users add the app from a deep-linked thread URL by declaring an origin-wide navigation scope.
Adds
manifest.webmanifestwithid,start_url, andscopeset to/,display: standalone, theme/background colors, and icons that reuse existingfavicon-32x32.pngandapple-touch-icon.pngso release-channel brand swaps keep working.index.htmllinks the manifest with<link rel="manifest" href="/manifest.webmanifest" />.Reviewed by Cursor Bugbot for commit 394bf16. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add web app manifest to preserve scope when app is installed
Adds manifest.webmanifest and links it in index.html. The manifest sets
id,start_url, andscopeto/, uses standalone display mode, and declares PNG icons at 32×32 and 180×180 with dark theme colors.Macroscope summarized 394bf16.