Skip to content

fix(server): settle snoozed threads immediately - #5379

Merged
juliusmarminge merged 4 commits into
pingdotgg:mainfrom
0bkevin:fix/5377-settle-snoozed-thread
Aug 15, 2026
Merged

fix(server): settle snoozed threads immediately#5379
juliusmarminge merged 4 commits into
pingdotgg:mainfrom
0bkevin:fix/5377-settle-snoozed-thread

Conversation

@0bkevin

@0bkevin 0bkevin commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Settling a snoozed thread persisted the settled override while leaving its snooze active. Because snooze takes precedence in client lifecycle classification, the row stayed in Snoozed until it was woken.

The thread decider now emits thread.unsnoozed alongside thread.settled whenever the thread is snoozed, using the same lifecycle timestamp. This moves the row to Settled immediately, preserves the existing unpin behavior, and lets a repeated settle repair legacy settled-and-snoozed state.

Verification:

  • pnpm exec vp test run apps/server/src/orchestration/decider.settled.test.ts (14 tests)
  • pnpm exec vp test run apps/server/src/orchestration/decider.settled.test.ts apps/server/src/orchestration/decider.snoozed.test.ts (24 tests)
  • pnpm --filter t3 exec tsgo --noEmit
  • targeted lint and format checks for both changed files
  • git diff --check
  • isolated web UI pass: snooze via “In 1 hour,” settle from the Snoozed row, confirm immediate placement under Settled without waking, then reload and confirm persistence

Closes #5377

Made with GPT-5.6 Sol using the Codex harness in T3 Code.


Note

Low Risk
Localized orchestration decider behavior with focused tests; no auth, data migration, or broad API surface changes.

Overview
Settling a snoozed thread now clears snooze in the same command, so the inbox row moves to Settled instead of staying under Snoozed because snooze won lifecycle classification.

The thread.settle handler in the orchestration decider still emits thread.settled (and thread.unpinned when pinned), and also emits thread.unsnoozed with reason 'user' when snoozedUntil is set. Pin and snooze companions are collected together, so a pinned-and-snoozed settle produces [thread.settled, thread.unpinned, thread.unsnoozed]. Awake threads still get only thread.settled; a repeat settle on legacy settled+snoozed state can repair by unsnoozing without changing settled timestamps incorrectly.

Tests in decider.settled.test.ts cover snoozed-only, legacy repair, and pinned+snoozed cases.

Reviewed by Cursor Bugbot for commit 660295a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix thread settling to immediately unsnooze snoozed threads

  • When settling a thread, decider.ts now emits thread.unsnoozed (with reason 'user') alongside thread.settled when the thread is snoozed.
  • A pinned thread still emits thread.unpinned; both companion events can now be emitted together in the sequence [thread.settled, ...companions].
  • Behavioral Change: previously, settling a snoozed thread left the snooze state intact; now it is cleared as part of the same operation.

Macroscope summarized 660295a.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 145679c0-a3da-4a7b-a9de-8d4fd85229c4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Aug 5, 2026
@macroscopeapp

macroscopeapp Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved a5636e3

Straightforward bug fix that extends the settle command to also clear snoozed state, following the existing pattern for clearing pinned state. The change is small, self-contained, and well-tested.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge enabled auto-merge (squash) August 15, 2026 10:44
@juliusmarminge
juliusmarminge merged commit 07e668d into pingdotgg:main Aug 15, 2026
14 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 15, 2026
## What's Changed
* fix(desktop): route mouse thumb buttons to the in-app browser by @akosbalogh in pingdotgg/t3code#4459
* fix(web): keep the final segment of directory paths with a trailing separator by @jorvarea in pingdotgg/t3code#5460
* Keep block code plain when copying from rendered markdown by @yashranaway in pingdotgg/t3code#4468
* fix(web): add web app manifest so installed app keeps its scope by @Albro3459 in pingdotgg/t3code#4306
* Skip user hooks during Claude capability probes by @yashranaway in pingdotgg/t3code#4466
* fix(mobile): use Android monospace font family by @tastelessjolt in pingdotgg/t3code#4609
* fix(desktop): timestamps follow the OS locale instead of en-US by @brzzdev in pingdotgg/t3code#6190
* fix(web): keep multi-select questions open after the first click by @RaitP1 in pingdotgg/t3code#6646
* fix(web): stop clipping the changed-files expand hover on Windows by @mrmg in pingdotgg/t3code#6545
* fix(server): allow long-running git pushes by @devchaudhary24k in pingdotgg/t3code#6499
* fix(desktop): keep probing backend readiness while the process is alive by @lgwacker in pingdotgg/t3code#5526
* fix(server): allow install scripts in npm-global provider updates by @hey-jj in pingdotgg/t3code#5646
* fix: detect SSH remotes with non-git user prefixes (e.g. gitlab@) by @JackatDJL in pingdotgg/t3code#3649
* fix(web): describe what Ultracode does in the Reasoning picker by @delltrak in pingdotgg/t3code#6092
* fix(server): settle pending user-input requests when a Claude session stops by @AaronAbuUsama in pingdotgg/t3code#5127
* fix(server): stop replaying a command receipt for a different aggregate by @ostapondo in pingdotgg/t3code#5246
* fix(server): settle snoozed threads immediately by @0bkevin in pingdotgg/t3code#5379
* fix(mobile): prevent crash on sign out in settings by @shubhu121 in pingdotgg/t3code#4899
* fix(mobile): local-checkout threads record their branch so PR badges show by @Zeus-Deus in pingdotgg/t3code#4986
* fix(web): contain long approval commands by @Serendeep in pingdotgg/t3code#6503
* feat(web): make right panel maximize bindable by @husseinraoouf in pingdotgg/t3code#5091
* fix(server): respect inherited OPENCODE_CONFIG_CONTENT by @jonocodes in pingdotgg/t3code#4242
* fix(marketing): detect Mac chip on homepage download button by @mahdibm-dev in pingdotgg/t3code#4197
* Keep the server alive when a response write hits a dead socket by @yashranaway in pingdotgg/t3code#4470
* Limit physical key fallback to non-Latin layout output by @yashranaway in pingdotgg/t3code#4469
* fix: restore CLAUDE.md symlink target by @NgoQuocViet2001 in pingdotgg/t3code#3929
* fix(clients): default clone destination to folder plus repo name by @inayayousfi in pingdotgg/t3code#5989
* fix(web): keep timestamp date and time in the same locale by @juliusmarminge in pingdotgg/t3code#7081
* feat(desktop): add signal macOS DMG installer background by @Brechard in pingdotgg/t3code#6201

## New Contributors
* @akosbalogh made their first contribution in pingdotgg/t3code#4459
* @jorvarea made their first contribution in pingdotgg/t3code#5460
* @yashranaway made their first contribution in pingdotgg/t3code#4468
* @Albro3459 made their first contribution in pingdotgg/t3code#4306
* @tastelessjolt made their first contribution in pingdotgg/t3code#4609
* @brzzdev made their first contribution in pingdotgg/t3code#6190
* @RaitP1 made their first contribution in pingdotgg/t3code#6646
* @devchaudhary24k made their first contribution in pingdotgg/t3code#6499
* @lgwacker made their first contribution in pingdotgg/t3code#5526
* @JackatDJL made their first contribution in pingdotgg/t3code#3649
* @delltrak made their first contribution in pingdotgg/t3code#6092
* @AaronAbuUsama made their first contribution in pingdotgg/t3code#5127
* @0bkevin made their first contribution in pingdotgg/t3code#5379
* @shubhu121 made their first contribution in pingdotgg/t3code#4899
* @Zeus-Deus made their first contribution in pingdotgg/t3code#4986
* @husseinraoouf made their first contribution in pingdotgg/t3code#5091
* @jonocodes made their first contribution in pingdotgg/t3code#4242
* @mahdibm-dev made their first contribution in pingdotgg/t3code#4197
* @NgoQuocViet2001 made their first contribution in pingdotgg/t3code#3929
* @inayayousfi made their first contribution in pingdotgg/t3code#5989

**Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260815.1101...v0.0.34-nightly.20260815.1102

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260815.1102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Settling a snoozed thread is deferred until the thread wakes

2 participants