Fix mobile command popover glass rendering - #6370
Conversation
- Replace the direct liquid-glass/fallback rendering with `GlassSurface` for consistent popup glass rendering
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
Bugbot Autofix is ON, but a cloud agent failed to start.
Reviewed by Cursor Bugbot for commit 059d083. Configure here.
| > | ||
| {props.children} | ||
| </View> | ||
| </GlassSurface> |
There was a problem hiding this comment.
Clear glass fights default chrome
Medium Severity
PopoverSurface requests glassEffectStyle="clear" on GlassSurface but leaves chrome at its default. That paints --color-glass-surface, a border, and shadow/elevation onto the clear glass path, and on unsupported platforms it replaces the prior near-opaque composer-matched panel with a more transparent elevated card. Other floating GlassSurface call sites pass chrome="none" and supply their own fallback chrome.
Reviewed by Cursor Bugbot for commit 059d083. Configure here.
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
ApprovabilityVerdict: Approved 059d083 Simple UI refactor replacing inline glass effect logic with the shared You can customize Macroscope's approvability policy. Learn more. |
## What's Changed * fix(web): align update toast release notes link by @t3-code[bot] in pingdotgg/t3code#6322 * fix(web): render tooltips above dropdowns by @extoci in pingdotgg/t3code#6241 * fix(web): open modified PR clicks in browser by @t3-code[bot] in pingdotgg/t3code#6278 * Fix mobile command popover glass rendering by @juliusmarminge in pingdotgg/t3code#6370 * test(mobile): seed snoozed showcase threads by @PixPMusic in pingdotgg/t3code#5155 * fix(web): preserve appearance mode when changing themes by @extoci in pingdotgg/t3code#6343 * feat(connect): deregister account environments from any client by @StiensWout in pingdotgg/t3code#4844 * feat(web): pull request surfaces — filters & qualifiers, all-server listing, update branch, reactions, in-place editing, smarter diffs by @Bil0000 in pingdotgg/t3code#6039 **Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260812.1077...v0.0.34-nightly.20260812.1079 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260812.1079


What Changed
Updated the mobile composer command popover to use the shared
GlassSurfacecomponent instead of rendering Liquid Glass or a manual fallback surface directly.Why
Using the shared glass surface keeps the popover's rendering consistent across supported and unsupported platforms while removing duplicated glass and fallback styling logic.
UI Changes
The command popover's visual surface implementation changed. Before/after screenshots are not included.
Checklist
Note
Low Risk
Localized UI surface swap in the composer popover with no auth, data, or API changes; visual parity may differ slightly where GlassSurface’s platform fallback differs from the old manual styles.
Overview
Refactors the composer command popover surface so it no longer branches on
@callstack/liquid-glassor hand-rolledViewfallback styles inPopoverSurface.PopoverSurfacenow wraps its children in the sharedGlassSurfacewithglassEffectStyle="clear"and the same light/dark tint values as before, while keeping the existing border radius and overflow on the outer style.Reviewed by Cursor Bugbot for commit 059d083. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix glass rendering in mobile command popover
Replaces the conditional
LiquidGlassView/Viewrendering in ComposerCommandPopover.tsx with a singleGlassSurfacewrapper usingglassEffectStyle="clear"and a dark-mode-awaretintColor. This removes theisLiquidGlassSupportedcheck and the explicitbackgroundColor/border styling from the fallback path.Macroscope summarized 059d083.