Skip to content

fix(marketing): detect Mac chip on homepage download button - #4197

Merged
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
mahdibm-dev:fix/homepage-mac-arch-detection
Aug 15, 2026
Merged

fix(marketing): detect Mac chip on homepage download button#4197
juliusmarminge merged 2 commits into
pingdotgg:mainfrom
mahdibm-dev:fix/homepage-mac-arch-detection

Conversation

@mahdibm-dev

@mahdibm-dev mahdibm-dev commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Problem

On an Intel Mac, the hero Download for macOS button on t3.codes serves the arm64 DMG, which won't launch — macOS reports "can't run on this Mac" (Intel Macs can't run arm64 binaries, and Rosetta only translates the other direction).

In apps/marketing/src/pages/index.astro, detectPlatform() hardcoded arch: "arm64" for all Macs, so pickAsset() always preferred -arm64.dmg. navigator.userAgent reports "Intel Mac OS X" on both Intel and Apple Silicon Macs, so the chip can't be told apart from the UA string alone.

Closes #4196

Fix

Add detectMacArch(), which probes the GPU via the WebGL WEBGL_debug_renderer_info renderer string:

  • renderer contains "Apple"arm64 (Apple Silicon)
  • renderer contains intel/amd/radeon/nvidia/geforcex64 (Intel)
  • inconclusive / WebGL unavailable → default to arm64 (matches prior behavior; most current Macs are Apple Silicon)

detectPlatform() now calls it instead of hardcoding the arch. The /download page already lists both builds explicitly, so it needed no change.

UI note (per CONTRIBUTING.md)

This is a behavior-only change — the button's text and styling are unchanged, so before/after screenshots would be identical. Only the download URL it resolves to changes:

Machine Before After
Intel Mac T3-Code-*-arm64.dmg (won't launch) T3-Code-*-x64.dmg
Apple Silicon T3-Code-*-arm64.dmg T3-Code-*-arm64.dmg (unchanged)

Testing

  • pnpm --filter @t3tools/marketing typecheck (astro check) → 0 errors, 0 warnings, 0 hints.
  • On an Intel Mac (MacBookPro16,1), the WebGL renderer resolves to an Intel GPU, so the button now points at the -x64.dmg asset; Apple Silicon still resolves to -arm64.dmg.

🤖 Generated with Claude Code


Note

Low Risk
Marketing-site client-side download URL selection only; no auth or backend changes, with a conservative x64 fallback when detection is unclear.

Overview
Fixes the marketing homepage Download for macOS link so Intel Macs get the -x64.dmg instead of always preferring -arm64.dmg.

detectPlatform() no longer hardcodes arch: "arm64" for every Mac. It calls new detectMacArch(), which reads the WebGL UNMASKED_RENDERER_WEBGL string (when WEBGL_debug_renderer_info is available) and passes it to macArchFromGpuRenderer.

That helper classifies renderers as x64 when Intel/AMD/Radeon/Nvidia markers appear (checked first, including ANGLE strings that mention both Apple and Intel), arm64 when the string matches Apple M\d, and x64 for ambiguous values like Safari’s generic “Apple GPU” or when probing fails—so Intel users aren’t offered an arm64 build that won’t run.

Unit tests cover Apple Silicon, Intel-priority, and ambiguous/empty renderer cases.

Reviewed by Cursor Bugbot for commit ddab7a2. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Detect Mac chip architecture on homepage download button via WebGL GPU renderer

  • Previously, macOS platform detection always returned arm64; it now probes the GPU renderer via WebGL and maps it to arm64 (Apple Silicon) or x64 (Intel/AMD/etc.).
  • Adds macArchFromGpuRenderer which matches Apple M<digit> strings for arm64, Intel/AMD/Radeon/Nvidia/GeForce for x64, and defaults to x64 for ambiguous values (e.g. Safari's generic 'Apple GPU').
  • detectMacArch creates a canvas, queries the WEBGL_debug_renderer_info extension, and falls back to x64 if probing fails.
  • Behavioral Change: macOS users on Intel Macs will now be offered the x64 download instead of arm64.

Macroscope summarized ddab7a2.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3c793dbe-86aa-44ef-a88b-dca5c4e548e0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the size:S 10-29 changed lines (additions + deletions). label Jul 20, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Jul 20, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 01253b7

Self-contained marketing page fix that adds Mac architecture detection for the download button. The change is well-tested, has a safe fallback (x64 for ambiguous cases), and doesn't affect any sensitive code paths.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge force-pushed the fix/homepage-mac-arch-detection branch from a4a2760 to d014a4b Compare August 15, 2026 11:00
@github-actions github-actions Bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Aug 15, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d014a4b. Configure here.

Comment thread apps/marketing/src/pages/index.astro Outdated
@macroscopeapp
macroscopeapp Bot dismissed their stale review August 15, 2026 11:45

Dismissing prior approval to re-evaluate 01253b7

@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:S 10-29 changed lines (additions + deletions). labels Aug 15, 2026
@juliusmarminge
juliusmarminge enabled auto-merge (squash) August 15, 2026 11:46
mahdibm-dev and others added 2 commits August 15, 2026 14:13
The hero "Download for macOS" button hardcoded arch: "arm64", so Intel
Macs were handed an arm64 build that won't launch ("can't run on this
Mac"). Detect Apple Silicon vs Intel via the WebGL GPU renderer, since
navigator.userAgent reports "Intel" on both chip types.

Fixes pingdotgg#4196

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-authored-by: codex <codex@users.noreply.github.com>
@juliusmarminge
juliusmarminge force-pushed the fix/homepage-mac-arch-detection branch from 01253b7 to ddab7a2 Compare August 15, 2026 12:14
@juliusmarminge
juliusmarminge merged commit 04f2309 into pingdotgg:main Aug 15, 2026
13 of 14 checks passed
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 15, 2026
## What's Changed
* fix(desktop): route mouse thumb buttons to the in-app browser by @akosbalogh in pingdotgg/t3code#4459
* fix(web): keep the final segment of directory paths with a trailing separator by @jorvarea in pingdotgg/t3code#5460
* Keep block code plain when copying from rendered markdown by @yashranaway in pingdotgg/t3code#4468
* fix(web): add web app manifest so installed app keeps its scope by @Albro3459 in pingdotgg/t3code#4306
* Skip user hooks during Claude capability probes by @yashranaway in pingdotgg/t3code#4466
* fix(mobile): use Android monospace font family by @tastelessjolt in pingdotgg/t3code#4609
* fix(desktop): timestamps follow the OS locale instead of en-US by @brzzdev in pingdotgg/t3code#6190
* fix(web): keep multi-select questions open after the first click by @RaitP1 in pingdotgg/t3code#6646
* fix(web): stop clipping the changed-files expand hover on Windows by @mrmg in pingdotgg/t3code#6545
* fix(server): allow long-running git pushes by @devchaudhary24k in pingdotgg/t3code#6499
* fix(desktop): keep probing backend readiness while the process is alive by @lgwacker in pingdotgg/t3code#5526
* fix(server): allow install scripts in npm-global provider updates by @hey-jj in pingdotgg/t3code#5646
* fix: detect SSH remotes with non-git user prefixes (e.g. gitlab@) by @JackatDJL in pingdotgg/t3code#3649
* fix(web): describe what Ultracode does in the Reasoning picker by @delltrak in pingdotgg/t3code#6092
* fix(server): settle pending user-input requests when a Claude session stops by @AaronAbuUsama in pingdotgg/t3code#5127
* fix(server): stop replaying a command receipt for a different aggregate by @ostapondo in pingdotgg/t3code#5246
* fix(server): settle snoozed threads immediately by @0bkevin in pingdotgg/t3code#5379
* fix(mobile): prevent crash on sign out in settings by @shubhu121 in pingdotgg/t3code#4899
* fix(mobile): local-checkout threads record their branch so PR badges show by @Zeus-Deus in pingdotgg/t3code#4986
* fix(web): contain long approval commands by @Serendeep in pingdotgg/t3code#6503
* feat(web): make right panel maximize bindable by @husseinraoouf in pingdotgg/t3code#5091
* fix(server): respect inherited OPENCODE_CONFIG_CONTENT by @jonocodes in pingdotgg/t3code#4242
* fix(marketing): detect Mac chip on homepage download button by @mahdibm-dev in pingdotgg/t3code#4197
* Keep the server alive when a response write hits a dead socket by @yashranaway in pingdotgg/t3code#4470
* Limit physical key fallback to non-Latin layout output by @yashranaway in pingdotgg/t3code#4469
* fix: restore CLAUDE.md symlink target by @NgoQuocViet2001 in pingdotgg/t3code#3929
* fix(clients): default clone destination to folder plus repo name by @inayayousfi in pingdotgg/t3code#5989
* fix(web): keep timestamp date and time in the same locale by @juliusmarminge in pingdotgg/t3code#7081
* feat(desktop): add signal macOS DMG installer background by @Brechard in pingdotgg/t3code#6201

## New Contributors
* @akosbalogh made their first contribution in pingdotgg/t3code#4459
* @jorvarea made their first contribution in pingdotgg/t3code#5460
* @yashranaway made their first contribution in pingdotgg/t3code#4468
* @Albro3459 made their first contribution in pingdotgg/t3code#4306
* @tastelessjolt made their first contribution in pingdotgg/t3code#4609
* @brzzdev made their first contribution in pingdotgg/t3code#6190
* @RaitP1 made their first contribution in pingdotgg/t3code#6646
* @devchaudhary24k made their first contribution in pingdotgg/t3code#6499
* @lgwacker made their first contribution in pingdotgg/t3code#5526
* @JackatDJL made their first contribution in pingdotgg/t3code#3649
* @delltrak made their first contribution in pingdotgg/t3code#6092
* @AaronAbuUsama made their first contribution in pingdotgg/t3code#5127
* @0bkevin made their first contribution in pingdotgg/t3code#5379
* @shubhu121 made their first contribution in pingdotgg/t3code#4899
* @Zeus-Deus made their first contribution in pingdotgg/t3code#4986
* @husseinraoouf made their first contribution in pingdotgg/t3code#5091
* @jonocodes made their first contribution in pingdotgg/t3code#4242
* @mahdibm-dev made their first contribution in pingdotgg/t3code#4197
* @NgoQuocViet2001 made their first contribution in pingdotgg/t3code#3929
* @inayayousfi made their first contribution in pingdotgg/t3code#5989

**Full Changelog**: pingdotgg/t3code@v0.0.34-nightly.20260815.1101...v0.0.34-nightly.20260815.1102

Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.34-nightly.20260815.1102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Homepage "Download for macOS" button always serves arm64, breaking Intel Macs

2 participants