Type inference code review

[mernst]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

Updates Java 8 type-inference constraint handling for non-pertinent invocation arguments, null method-reference return types, complementary qualifier bounds, transitive dependencies, and checked-exception constraints. It also removes an obsolete commented statement and changes the Javadoc for checked-exception classification.

Possibly related PRs

• typetools/checker-framework#7729: Modifies related method-reference and invocation type-inference logic.
• typetools/checker-framework#7874: Changes the implementation context of CheckedExceptionsUtil.isCheckedException(...).
• typetools/checker-framework#7876: Contains corresponding updates to several type-inference functions.

Suggested reviewers: smillst

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/claude-code-review.yml:
- Line 27: Update the actions/checkout step in the workflow to reference a full
immutable commit SHA instead of the mutable v7 tag, and retain the checkout
action version in an adjacent comment.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 07572812-f2a7-4aea-8495-e7f77d3e7026

📥 Commits

Reviewing files that changed from the base of the PR and between 8f9e645 and 5d5ae21.

📒 Files selected for processing (1)

• .github/workflows/claude-code-review.yml

[mernst]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[mernst]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/claude-code-review.yml:
- Line 35: Remove allow-unsafe-pr-checkout from the privileged
pull_request_target workflow and prevent it from checking out or executing
pull-request-controlled code. Move PR checkout/review to an unprivileged
pull_request job, or retrieve the needed files through the GitHub API; retain
privileged permissions and Claude review secrets only in the job that does not
consume checked-out PR content.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2e6141fd-03ed-4126-82ce-a72521a38fda

📥 Commits

Reviewing files that changed from the base of the PR and between 5d5ae21 and 6468dbe.

📒 Files selected for processing (1)

• .github/workflows/claude-code-review.yml

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@framework/src/main/java/org/checkerframework/framework/util/typeinference8/util/CheckedExceptionsUtil.java`:
- Around line 305-311: Resolve the merge-conflict markers in the Javadoc for the
type parameter near CheckedExceptionsUtil by removing all <<<<<<<, |||||||, and
>>>>>>> lines and duplicate `@param` type entries. Keep one authoritative
description consistent with the method’s intended accepted exception-type range.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 1b6c1741-ebbe-4cda-8f92-ac011921e1cd

📥 Commits

Reviewing files that changed from the base of the PR and between 6468dbe and 188bd5f.

📒 Files selected for processing (2)

• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/InferenceFactory.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/util/CheckedExceptionsUtil.java