Skip to content

Handle the possibility that no valid parameterization exists - #7899

Open
mernst wants to merge 66 commits into
typetools:masterfrom
mernst:type-inference-8-review-2-9
Open

Handle the possibility that no valid parameterization exists#7899
mernst wants to merge 66 commits into
typetools:masterfrom
mernst:type-inference-8-review-2-9

Conversation

@mernst

@mernst mernst commented Jul 30, 2026

Copy link
Copy Markdown
Member

No description provided.

mernst added 30 commits July 25, 2026 13:21
mernst added 21 commits July 30, 2026 07:50
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 096304ba-295e-425a-8208-9632b910497c

📥 Commits

Reviewing files that changed from the base of the PR and between 1f061dc and 884ce29.

📒 Files selected for processing (8)
  • checker/tests/nullness/java8inference/NullnessGroundTargetType.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/InvocationTypeInference.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/constraint/Expression.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/AbstractType.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/Dependencies.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/InferenceFactory.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/QualifierVar.java
  • framework/tests/all-systems/java8inference/GroundTargetType.java
💤 Files with no reviewable changes (1)
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/AbstractType.java

📝 Walkthrough

Walkthrough

The pull request updates Java 8 lambda inference for wildcard-parameterized functional interfaces. It validates inferred type arguments against declared bounds, handles invalid or missing ground target types, and improves method-reference reduction. It also centralizes additional invocation constraints and updates supporting inference constraints and null checks. New tests cover bounded functional interfaces, nullness diagnostics, explicitly typed lambda parameters, and implicitly typed lambdas.

Possibly related PRs

Suggested reviewers: smillst

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 16.67% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant