Skip to content

Require every bound, not just some bound - #7880

Open
mernst wants to merge 65 commits into
typetools:masterfrom
mernst:type-inference-8-review-1-6
Open

Require every bound, not just some bound#7880
mernst wants to merge 65 commits into
typetools:masterfrom
mernst:type-inference-8-review-1-6

Conversation

@mernst

@mernst mernst commented Jul 30, 2026

Copy link
Copy Markdown
Member

Merge after #7877.

mernst added 30 commits July 25, 2026 13:21
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 08ea3a59-5506-4483-aa7f-9ab5ea032b59

📥 Commits

Reviewing files that changed from the base of the PR and between 61e20da and d72a504.

📒 Files selected for processing (11)
  • checker/tests/nullness/java8inference/ThrowsBoundRuntimeException.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/InvocationTypeInference.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/bound/BoundSet.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/constraint/Expression.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/AbstractType.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/Dependencies.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/InferenceFactory.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/QualifierVar.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/VariableBounds.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/util/CheckedExceptionsUtil.java
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/util/Resolution.java
💤 Files with no reviewable changes (1)
  • framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/AbstractType.java

📝 Walkthrough

Walkthrough

The pull request corrects several Java 8 type-inference paths. It updates bound incorporation, qualifier constraints, upper-bound and wildcard handling, dependency expansion, method-reference reduction, and argument constraint creation. It also fixes annotated exception processing and null checked-exception scans. RuntimeException fallback resolution now requires all proper upper bounds to accept it. A nullness test covers throws-bound inference for nullable and non-null exception types.

Possibly related PRs

Suggested reviewers: smillst

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants