Convert assert to either BugInCF or reduction to false

[mernst]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d08cb685-41b1-4d78-be3f-f012fefe7500

📥 Commits

Reviewing files that changed from the base of the PR and between 882cc9e and 655d3a0.

📒 Files selected for processing (10)

• framework/src/main/java/org/checkerframework/framework/util/typeinference8/InvocationTypeInference.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/bound/BoundSet.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/constraint/Expression.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/AbstractType.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/Dependencies.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/InferenceFactory.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/InferenceType.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/QualifierVar.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/VariableBounds.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/util/Resolution.java

💤 Files with no reviewable changes (1)

• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/AbstractType.java

---

📝 Walkthrough

Walkthrough

The pull request hardens Java 8 type inference by replacing assertion-only checks with BugInCF failures, handling false bound sets during lambda and invocation constraint reduction, and accepting null method-reference return types as void. It also adjusts non-pertinent argument constraint generation, qualifier constraint kinds, dependency expansion, checked-exception iterator usage, parameterized type validation, and removes a stale comment.

Possibly related PRs

• typetools/checker-framework#7864: Refactors the same InvocationTypeInference.createC handling for non-pertinent arguments.
• typetools/checker-framework#7894: Overlaps in createC and null method-reference return handling.
• typetools/checker-framework#7895: Shares multiple type-inference8 changes, including dependency, qualifier, and expression handling.

Suggested reviewers: smillst

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}