Use object equality, not reference equality

[mernst]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 69a03af2-663d-45e1-8240-fb8f98f4ca40

📥 Commits

Reviewing files that changed from the base of the PR and between ea39f24 and 6d9cb26.

📒 Files selected for processing (8)

• framework/src/main/java/org/checkerframework/framework/util/typeinference8/InvocationTypeInference.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/constraint/Expression.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/AbstractType.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/Dependencies.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/InferenceFactory.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/Qualifier.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/QualifierVar.java
• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/VariableBounds.java

💤 Files with no reviewable changes (1)

• framework/src/main/java/org/checkerframework/framework/util/typeinference8/types/AbstractType.java

---

📝 Walkthrough

Walkthrough

The PR updates Java 8 type inference logic. Invocation constraint creation delegates additional argument handling to an existing helper. Method-reference reduction accepts absent functional return types. Dependency expansion skips missing variables. Checked-exception processing reuses annotated thrown types. Qualifier comparison now uses annotation equivalence, and qualifier constraints use semantic equality and qualifier-specific constraint kinds.

Possibly related PRs

• typetools/checker-framework#7864: Shares changes across the same type-inference files and methods.
• typetools/checker-framework#7877: Overlaps on invocation, method-reference, and qualifier constraint handling.
• typetools/checker-framework#7884: Shares changes to invocation, method-reference, dependency, exception, and qualifier constraint logic.

Suggested reviewers: smillst

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}