build: track PDL files as inputs in inspector GN build#62888
Merged
aduh95 merged 1 commit intonodejs:mainfrom May 4, 2026
Merged
build: track PDL files as inputs in inspector GN build#62888aduh95 merged 1 commit intonodejs:mainfrom
aduh95 merged 1 commit intonodejs:mainfrom
Conversation
The node_protocol_generated_sources action was missing gypi_values.node_pdl_files from its inputs, causing Ninja to skip regeneration when PDL domain files changed.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
legendecas
approved these changes
Apr 22, 2026
addaleax
added
author ready
addaleax
approved these changes
Apr 24, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
cola119
approved these changes
May 4, 2026
cola119
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/62888 ✔ Done loading data for nodejs/node/pull/62888 ----------------------------------- PR info ------------------------------------ Title build: track PDL files as inputs in inspector GN build (#62888) Author Robo <hop2deep@gmail.com> (@deepak1556) Branch deepak1556:robo/fix_inspector_gn_config -> nodejs:main Labels c++, author ready Commits 1 - build: track PDL files as inputs in inspector GN build Committers 1 - deepak1556 <hop2deep@gmail.com> PR-URL: https://github.com/nodejs/node/pull/62888 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/62888 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 22 Apr 2026 10:44:49 GMT ✔ Approvals: 3 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/62888#pullrequestreview-4156730473 ✔ - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/62888#pullrequestreview-4173687441 ✔ - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/62888#pullrequestreview-4219787995 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-04-25T22:32:49Z: https://ci.nodejs.org/job/node-test-pull-request/72926/ - Querying data for job/node-test-pull-request/72926/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 62888 From https://github.com/nodejs/node * branch refs/pull/62888/merge -> FETCH_HEAD ✔ Fetched commits as f4c50a8d7103..254528612ee1 -------------------------------------------------------------------------------- [main 3dcec1fe95] build: track PDL files as inputs in inspector GN build Author: deepak1556 <hop2deep@gmail.com> Date: Wed Apr 22 19:42:30 2026 +0900 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- build: track PDL files as inputs in inspector GN buildhttps://github.com/nodejs/node/actions/runs/25318513986 |
Contributor
|
Landed in 6e2188e |
aduh95
pushed a commit
that referenced
this pull request
May 5, 2026
The `node_protocol_generated_sources` action was missing `gypi_values.node_pdl_files` from its inputs, causing Ninja to skip regeneration when PDL domain files changed. PR-URL: #62888 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
node_protocol_generated_sourcesaction was missinggypi_values.node_pdl_filesfrom its inputs, causing Ninja to skip regeneration when PDL domain files changed.Refs electron/electron#51239