Skip to content

test_runner: fix failing suite hooks when marked with todo#63097

Open
MoLow wants to merge 1 commit intonodejs:mainfrom
MoLow:fix-suite-todo-failed-hook
Open

test_runner: fix failing suite hooks when marked with todo#63097
MoLow wants to merge 1 commit intonodejs:mainfrom
MoLow:fix-suite-todo-failed-hook

Conversation

@MoLow
Copy link
Copy Markdown
Member

@MoLow MoLow commented May 3, 2026

No description provided.

Signed-off-by: Moshe Atlow <moshe@atlow.co.il>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 3, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@codecov
Copy link
Copy Markdown

codecov Bot commented May 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.66%. Comparing base (b2f6aa3) to head (0386189).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63097      +/-   ##
==========================================
+ Coverage   89.65%   89.66%   +0.01%     
==========================================
  Files         712      712              
  Lines      220512   220512              
  Branches    42289    42287       -2     
==========================================
+ Hits       197690   197717      +27     
+ Misses      14663    14656       -7     
+ Partials     8159     8139      -20     
Files with missing lines Coverage Δ
lib/internal/test_runner/utils.js 63.58% <100.00%> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants