Skip to content

module,win: fix long subpath import#62101

Merged
nodejs-github-bot merged 3 commits intonodejs:mainfrom
JaneaSystems:mefi-import-fix
Apr 3, 2026
Merged

module,win: fix long subpath import#62101
nodejs-github-bot merged 3 commits intonodejs:mainfrom
JaneaSystems:mefi-import-fix

Conversation

@StefanStojanovic
Copy link
Copy Markdown
Contributor

This change fixes the linked issue and adds a regression test.

Fixes: #62043

@StefanStojanovic StefanStojanovic added module Issues and PRs related to the module subsystem. windows Issues and PRs related to the Windows platform. labels Mar 4, 2026
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 4, 2026
@StefanStojanovic StefanStojanovic force-pushed the mefi-import-fix branch 2 times, most recently from 4c3bc3d to fe9c259 Compare March 4, 2026 13:55
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.70%. Comparing base (a9ac9b1) to head (8bc3929).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62101      +/-   ##
==========================================
- Coverage   89.70%   89.70%   -0.01%     
==========================================
  Files         695      695              
  Lines      214213   214220       +7     
  Branches    41021    41021              
==========================================
+ Hits       192167   192169       +2     
+ Misses      14113    14095      -18     
- Partials     7933     7956      +23     
Files with missing lines Coverage Δ
src/node_modules.cc 80.14% <100.00%> (+0.57%) ⬆️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/node_modules.cc Outdated
@Renegade334 Renegade334 added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Mar 19, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 19, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@StefanStojanovic StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 31, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@StefanStojanovic StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2026
@github-actions github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

Failed to start CI
[TypeError: fetch failed] {
  [cause]: [Error: getaddrinfo EAI_AGAIN api.github.com] {
    errno: -3001,
    code: 'EAI_AGAIN',
    syscall: 'getaddrinfo',
    hostname: 'api.github.com'
  }
}
https://github.com/nodejs/node/actions/runs/23894925856

@nodejs-github-bot

This comment was marked as outdated.

@Renegade334 Renegade334 removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Apr 2, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@StefanStojanovic StefanStojanovic added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@StefanStojanovic StefanStojanovic added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2026
@nodejs-github-bot nodejs-github-bot merged commit e419afd into nodejs:main Apr 3, 2026
66 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Landed in e419afd

aduh95 pushed a commit that referenced this pull request May 5, 2026
Fixes: #62043
PR-URL: #62101
Fixes: #62043
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
@wonu
Copy link
Copy Markdown

wonu commented May 5, 2026

Any chance this could be backported to v24.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. windows Issues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subpath imports (#) fail on Windows when package.json path >= 260 chars (MAX_PATH)

5 participants