crypto: reject unintended raw key format string input#62974
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Apr 28, 2026
Merged
crypto: reject unintended raw key format string input#62974nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
ChALkeR
reviewed
Apr 26, 2026
ChALkeR
approved these changes
Apr 26, 2026
Co-authored-by: Nikita Skovoroda <chalkerx@gmail.com>
panva
added
the
commit-queue-squash
ChALkeR
approved these changes
Apr 26, 2026
panva
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
tniessen
approved these changes
Apr 26, 2026
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62974 +/- ##
==========================================
- Coverage 89.66% 89.64% -0.02%
==========================================
Files 706 706
Lines 219391 219409 +18
Branches 42068 42079 +11
==========================================
- Hits 196712 196699 -13
- Misses 14578 14613 +35
+ Partials 8101 8097 -4
🚀 New features to boost your workflow:
|
panva
added
the
commit-queue
lpinca
approved these changes
Apr 27, 2026
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 3ee30d9 |
aduh95
pushed a commit
that referenced
this pull request
May 5, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: #62974 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As originally intended, raw formats !== strings.