Skip to content

[Merged by Bors] - feat(RingTheory):Add lemma about factorPow - #22369

Closed
Thmoas-Guan wants to merge 4 commits into
masterfrom
more-on-factorPow
Closed

[Merged by Bors] - feat(RingTheory):Add lemma about factorPow#22369
Thmoas-Guan wants to merge 4 commits into
masterfrom
more-on-factorPow

Conversation

@Thmoas-Guan

Copy link
Copy Markdown
Collaborator

Add two lemma about factorPow.


Open in Gitpod

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 27, 2025
@github-actions

github-actions Bot commented Feb 27, 2025

Copy link
Copy Markdown

PR summary 1ec6dfbfd3

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ Ideal.map_mk_comap_factor
+ Ideal.map_mk_comap_factorPow
+ factorPowSucc.isUnit_of_isUnit_image

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Comment thread Mathlib/RingTheory/Ideal/Quotient/PowTransition.lean Outdated

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; some superficial comments below

Comment thread Mathlib/RingTheory/Ideal/Quotient/PowTransition.lean Outdated
Comment thread Mathlib/RingTheory/Ideal/Quotient/PowTransition.lean Outdated
Comment thread Mathlib/RingTheory/Ideal/Quotient/PowTransition.lean Outdated
@riccardobrasca

Copy link
Copy Markdown
Member

Taking into account the above comments LGTM, thanks!

bors d+

@mathlib-bors

mathlib-bors Bot commented Feb 28, 2025

Copy link
Copy Markdown
Contributor

✌️ Thmoas-Guan can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@ghost ghost added the delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). label Feb 28, 2025
and fix naming
@Thmoas-Guan

Copy link
Copy Markdown
Collaborator Author

@riccardobrasca There are some bit more changes, can you have a look? Thanks
Also, do we need the version for factorPow instead of factorPowSucc for isUnit_of_IsUnit_image? I remember @jjdishere once mentioned a method to deal with it?

@riccardobrasca riccardobrasca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can always add another lemma later.

bors d+

Comment thread Mathlib/RingTheory/Ideal/Quotient/PowTransition.lean Outdated
@mathlib-bors

mathlib-bors Bot commented Mar 1, 2025

Copy link
Copy Markdown
Contributor

✌️ Thmoas-Guan can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
@Thmoas-Guan

Copy link
Copy Markdown
Collaborator Author

bors r+

mathlib-bors Bot pushed a commit that referenced this pull request Mar 1, 2025
@mathlib-bors

mathlib-bors Bot commented Mar 1, 2025

Copy link
Copy Markdown
Contributor

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title feat(RingTheory):Add lemma about factorPow [Merged by Bors] - feat(RingTheory):Add lemma about factorPow Mar 1, 2025
@mathlib-bors mathlib-bors Bot closed this Mar 1, 2025
@mathlib-bors
mathlib-bors Bot deleted the more-on-factorPow branch March 1, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants