[Merged by Bors] - feat(Algebra): lemma about is AdicComplete local ring - #22429
Closed
Thmoas-Guan wants to merge 9 commits into
Closed
[Merged by Bors] - feat(Algebra): lemma about is AdicComplete local ring#22429Thmoas-Guan wants to merge 9 commits into
Thmoas-Guan wants to merge 9 commits into
Conversation
PR summary 969d8a468eImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
mathlib4-dependent-issues-bot
added
the
blocked-by-other-PR
Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
Collaborator
Author
|
Is this place appropriate? If the place is correct the I would try to replace the same lemma in #21944 |
mathlib4-dependent-issues-bot
removed
the
blocked-by-other-PR
Collaborator
|
This PR/issue depends on:
|
grunweg
changed the title
Ruben-VandeVelde
left a comment
Ruben-VandeVelde
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Some minor suggestions below
| rcases IsUnit.exists_left_inv h with ⟨s, hs⟩ | ||
| absurd m.ne_top_iff_one.mp (Ideal.IsMaximal.ne_top hmax) | ||
| simp [← hs, Ideal.mul_mem_left m s mem] | ||
| · have mapu {n : ℕ} (npos : n > 0) : IsUnit (Ideal.Quotient.mk (m ^ n) r) := by |
Contributor
There was a problem hiding this comment.
Please use 0 < n throughout
Member
There was a problem hiding this comment.
Wait, didn't we have a linter for this?!
Member
|
Thanks! bors merge |
ghost
added
the
mathlib-bors Bot
pushed a commit
that referenced
this pull request
Mar 2, 2025
Prove that if a ring is adic complete with respect to a maximal ideal then very element outside it is unit and it follows that the ring is a local ring (complete local ring).
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prove that if a ring is adic complete with respect to a maximal ideal then very element outside it is unit and it follows that the ring is a local ring (complete local ring).