Skip to content

feat(RingTheory/Powerseries): Weierstrass preparation for complete local ring - #21944

Closed
Thmoas-Guan wants to merge 89 commits into
masterfrom
Weierstrass-preparation-aux
Closed

feat(RingTheory/Powerseries): Weierstrass preparation for complete local ring#21944
Thmoas-Guan wants to merge 89 commits into
masterfrom
Weierstrass-preparation-aux

Conversation

@Thmoas-Guan

@Thmoas-Guan Thmoas-Guan commented Feb 16, 2025

Copy link
Copy Markdown
Collaborator

@github-actions

github-actions Bot commented Feb 16, 2025

Copy link
Copy Markdown

PR summary b097aebb18

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.RingTheory.WeierstrassPreparation (new file) 1337

Declarations diff

+ CompleteLocalRing.weierstrass_preparation
+ PowerSeries.order_eq_of_eq_zero_iff
+ map_ne_top
+ preparation_lift
+ preparation_lift_triv

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 16, 2025
@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 16, 2025
Thmoas-Guan and others added 12 commits April 1, 2025 15:15
fix docstring and remove unused condition at the same time
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
extract common part
@Thmoas-Guan

Thmoas-Guan commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator Author

I extracted a common part of two proofs as PowerSeries.order_eq_of_eq_zero_iff, where do we expext to put this lemma?

@acmepjz

acmepjz commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator

I extracted a common part of two proofs as PowerSeries.order_eq_of_eq_zero_iff, where do we expext to put this lemma?

This lemma seems a bit ad-hoc IMHO... If you really need it then it definitely should go to the file where the PowerSeries.order is defined.

BTW do you think the following proof is better?

lemma PowerSeries.order_eq_of_eq_zero_iff {R S : Type*} [Semiring R] [Semiring S]
    {φ : PowerSeries R} {ψ : PowerSeries S} (h : ∀ i, coeff _ i φ = 0 ↔ coeff _ i ψ = 0) :
    φ.order = ψ.order := by
  have : φ = 0 ↔ ψ = 0 := by simp_rw [PowerSeries.ext_iff, map_zero, h]
  simp_rw [order]
  congr!
  exact h _

@Thmoas-Guan

Copy link
Copy Markdown
Collaborator Author

I extracted a common part of two proofs as PowerSeries.order_eq_of_eq_zero_iff, where do we expext to put this lemma?

This lemma seems a bit ad-hoc IMHO... If you really need it then it definitely should go to the file where the PowerSeries.order is defined.

BTW do you think the following proof is better?

lemma PowerSeries.order_eq_of_eq_zero_iff {R S : Type*} [Semiring R] [Semiring S]
    {φ : PowerSeries R} {ψ : PowerSeries S} (h : ∀ i, coeff _ i φ = 0 ↔ coeff _ i ψ = 0) :
    φ.order = ψ.order := by
  have : φ = 0 ↔ ψ = 0 := by simp_rw [PowerSeries.ext_iff, map_zero, h]
  simp_rw [order]
  congr!
  exact h _

I think this proof is better.
I add this lemma just because I don't want to stuff everything inside the main proof.
Should I just mark this lemma PowerSeries.order_eq_of_eq_zero_iff private?

@acmepjz

acmepjz commented Apr 3, 2025

Copy link
Copy Markdown
Collaborator

Should I just mark this lemma PowerSeries.order_eq_of_eq_zero_iff private?

I think this should be better.

@acmepjz

acmepjz commented May 3, 2025

Copy link
Copy Markdown
Collaborator

After discussion with @Thmoas-Guan , we decided to replace the contents of close this PR and open a new PR by my solution at https://github.com/acmepjz/lean-iwasawa/blob/master/Iwasawalib/RingTheory/PowerSeries/WeierstrassPreparation.lean.

@Thmoas-Guan

Copy link
Copy Markdown
Collaborator Author

This PR is replaced by the better setting of weierstrass division, thus closed. See #24584

@Thmoas-Guan Thmoas-Guan closed this May 4, 2025
@YaelDillies
YaelDillies deleted the Weierstrass-preparation-aux branch August 17, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-algebra Algebra (groups, rings, fields, etc) will-close-soon Unless something changes, we will close this PR soon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants