Skip to content

feat(RingTheory/Powerseries): Weierstrass preparation - #21859

Closed
Thmoas-Guan wants to merge 147 commits into
masterfrom
Weierstrass-preparation
Closed

feat(RingTheory/Powerseries): Weierstrass preparation#21859
Thmoas-Guan wants to merge 147 commits into
masterfrom
Weierstrass-preparation

Conversation

@Thmoas-Guan

@Thmoas-Guan Thmoas-Guan commented Feb 14, 2025

Copy link
Copy Markdown
Collaborator

@Thmoas-Guan Thmoas-Guan added the t-algebra Algebra (groups, rings, fields, etc) label Feb 14, 2025
@github-actions

github-actions Bot commented Feb 14, 2025

Copy link
Copy Markdown

PR summary 6c8ac7478d

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.RingTheory.WeierstrassPreparation (new file) 1337

Declarations diff

+ CompleteLocalRing.weierstrass_preparation
+ IsDiscreteValuationRing.weierstrass_preparation
+ IsDiscreteValuationRing.weierstrass_preparation_aux
+ PowerSeries.order_eq_of_eq_zero_iff
+ map_ne_top
+ preparation_lift
+ preparation_lift_triv

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@Thmoas-Guan

Copy link
Copy Markdown
Collaborator Author

There are a lot of lemmas twisted together, I may need some help to decompose this PR, thank for the helps.

@riccardobrasca

Copy link
Copy Markdown
Member

This PR is huge, is it possible to split it? For example, the first result can go in another file and you open a PR with prerequisites for the main theorem. Anyway thanks a lot, we surely want this!

@riccardobrasca riccardobrasca self-assigned this Feb 14, 2025
@Thmoas-Guan

Thmoas-Guan commented Feb 14, 2025

Copy link
Copy Markdown
Collaborator Author

This PR is huge, is it possible to split it? For example, the first result can go in another file and you open a PR with prerequisites for the main theorem. Anyway thanks a lot, we surely want this!

The problem is, the things after the complete local ring version doesn't take long, however it can reduce the lenth for about 100 to 150 lines. However I don't clearly know where should the first result go.
There are still a lot of part of this needing refinement. Thanks a lot if you can help.

@riccardobrasca

Copy link
Copy Markdown
Member

I am still looking only at the first lemma, and we actually already have it. It is basically Polynomial.lifts_and_degree_eq_and_monic

open Set

/--The canonical transition map from `R⧸m ^ b` to `R⧸m ^ a` when `a ≤ b`-/
def TransitionMap {a b : ℕ} (le : a ≤ b) : R⧸m ^ b →+* R⧸m ^ a :=

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also defined in #21582 (if I am not confused). @jjdishere can you confirm?

@jjdishere jjdishere Feb 14, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and this is more general than the definition R⧸m ^ (n + 1) →+* R⧸m ^ n in #21582 .

@Thmoas-Guan

Copy link
Copy Markdown
Collaborator Author

I am still looking only at the first lemma, and we actually already have it. It is basically Polynomial.lifts_and_degree_eq_and_monic

Sorry, my fault, I don't know why aesop didn't return me this.

@jjdishere

Copy link
Copy Markdown
Collaborator

I've discussed with @Thmoas-Guan about the intersection part of this PR and #21582 . He will try to split out the common part of this and #21582 into a new PR.

@mathlib4-dependent-issues-bot mathlib4-dependent-issues-bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Feb 15, 2025
@Thmoas-Guan

Copy link
Copy Markdown
Collaborator Author

This PR is replaced by the better setting of weierstrass division, thus closed. Would be developed soon based on #24584

@Thmoas-Guan Thmoas-Guan closed this May 4, 2025
@YaelDillies
YaelDillies deleted the Weierstrass-preparation branch August 17, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants