fix: warn if a plugin uses transformIndexHtml - #16394
Merged
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/28a1920ffcbf702d324ded116a6dc49607845ce8Open in |
🦋 Changeset detectedLatest commit: 28a1920 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
teemingc
commented
Jul 17, 2026
| ); | ||
| } else { | ||
| console.log(styleText(['bold', 'yellow'], '\nNo adapter specified')); | ||
| log.warn('\nNo adapter specified'); |
Member
Author
There was a problem hiding this comment.
Drive-by. Not sure why we don't use the logger class more
Rich-Harris
approved these changes
Jul 17, 2026
Rich-Harris
left a comment
Rich-Harris
left a comment
Member
There was a problem hiding this comment.
this wording seems fine — when we eventually get round to cataloguing the errors/warnings and having links on the site, we can add more detail about appType: 'custom' and so on but it probably doesn't make sense to have all that yet
teemingc
pushed a commit
that referenced
this pull request
Jul 18, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to version-3, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `version-3` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `version-3`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @sveltejs/kit@3.0.0-next.10 ### Major Changes - breaking: move `defineEnvVars` to `@sveltejs/kit/env` ([#16375](#16375)) ### Patch Changes - fix: treat `data:` protocol URLs as external for redirect ([#16392](#16392)) - perf: skip import graph collection outside client environments ([#16383](#16383)) - fix: warn if there are plugins using `transformIndexHtml` ([#16394](#16394)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #12391
Not sure how to word the warning message so I'm open to suggestions
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits