perf: skip import graph collection outside client environments - #16383
Merged
Rich-Harris merged 1 commit intoJul 17, 2026
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/1ae3a5c9286ca84219a1f8f6f200689f2d9a934eOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 1ae3a5c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
approved these changes
Jul 17, 2026
Rich-Harris
left a comment
Member
There was a problem hiding this comment.
this is great, thank you!
Rich-Harris
pushed a commit
that referenced
this pull request
Jul 17, 2026
follow up to #16383 Using `applyToEnvironment` is better here as the plugin isn't needed in the server environment if we're already using an `if (...)` guard to opt out early
teemingc
pushed a commit
that referenced
this pull request
Jul 18, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to version-3, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `version-3` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `version-3`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @sveltejs/kit@3.0.0-next.10 ### Major Changes - breaking: move `defineEnvVars` to `@sveltejs/kit/env` ([#16375](#16375)) ### Patch Changes - fix: treat `data:` protocol URLs as external for redirect ([#16392](#16392)) - perf: skip import graph collection outside client environments ([#16383](#16383)) - fix: warn if there are plugins using `transformIndexHtml` ([#16394](#16394)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part of #15461
vite-plugin-sveltekit-guardbuilds itsimport_mapin every environment, but the map is only read in theloadhook, which bails for non-client consumers before touching it. On the svelte.dev build that makes 69% of the guard'sresolveIdcalls (3,987 of 5,778) dead work, and the guard was the top entry in dominikg'sPLUGIN_TIMINGSreport in #13756. This adds the same consumer bail toresolveId.The error chains from #14155 are unaffected because the client environment collects its own edges. Measured on the svelte.dev build with
3.0.0-next.6and vite8.0.16(details in #15461 (comment)), ssr-side hook time drops from ~296s cumulative to 23ms, the build succeeds, and a planted two-hop$lib/serverviolation still fails with the full chain. There is no new test because the behavior is meant to be unobservable and the exact chain assertions already exist intest/apps/dev-only(dev) andtest/build-errors/server-only.spec.js(build), both green with this change.History for reviewers. #15439 added hook filters everywhere except this hook, which is blocked on vitejs/vite#21956. #15543 proposed this skip plus a node_modules importer skip and was closed pending kit 3. The ssr half was not fixed by kit 3. The node_modules half is not implemented here because it is unsafe, a library can legitimately import
$app/serverand its violation chain has to walk node_modules edges.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits