fix: incomplete URL scheme check code scanning alert - #16392
Merged
Conversation
…heck Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/d0f81658b096a062ca2f69f0c426120fd17028cdOpen in |
🦋 Changeset detectedLatest commit: f3ee810 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
teemingc
marked this pull request as ready for review
July 17, 2026 15:41
teemingc
changed the title
teemingc
changed the title
teemingc
changed the title
Rich-Harris
approved these changes
Jul 17, 2026
teemingc
pushed a commit
that referenced
this pull request
Jul 18, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to version-3, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `version-3` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `version-3`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @sveltejs/kit@3.0.0-next.10 ### Major Changes - breaking: move `defineEnvVars` to `@sveltejs/kit/env` ([#16375](#16375)) ### Patch Changes - fix: treat `data:` protocol URLs as external for redirect ([#16392](#16392)) - perf: skip import graph collection outside client environments ([#16383](#16383)) - fix: warn if there are plugins using `transformIndexHtml` ([#16394](#16394)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for https://github.com/sveltejs/kit/security/code-scanning/33
We don't care about the
vbscript:protocol since that only works on internet explorer. I've also tested running it on Safari/Firefox/Chrome and it's not recognised.data:on the other hand does allow running some arbitrary javascript:Taken from https://developer.mozilla.org/en-US/docs/Web/URI/Reference/Schemes/data#datatexthtml3cscript3ealert2827hi27293b3c2fscript3e