Ecstatic with tests

[zbynek]

Please ensure that your pull request fulfills these requirements:

• The pull request is being made against the master branch
• Tests for the changes have been added (for bug fixes / features)

What is the purpose of this pull request?

Remove dependency on ecstatic -- see #631 (this is based on @thornjad 's work, only the test code was fixed here + hack from #569 replaced by a nicer fix inside Ecstatic)

Fixes #568, fixes #518, fixes #35, fixes #276, fixes #689

[zbynek]

@thornjad all green 🎉 https://travis-ci.com/github/zbynek/http-server/builds/231702777

I dropped Node 6 from the list of CI tested platforms.

[thornjad]

🎉 thank you so much for the PR! I'll fit in looking over it whenever I get chances.

For the hack from #569, do you know where the fix inside ecstatic is? I don't remember hearing anything about it, but then again, ecstatic has gone through some drama that drowned out everything else.

[zbynek]

For #569 I've added the replacement into decodePathname directly. I think this way it allows you to have \ in filenames on Linux/Mac (as long as you pass them as %5C in URL) and everything gets normalized to / on windows.

Before this change the tests were failing on Windows with infinite redirect (because the hack was only active when loading http-server, and the tests only load core). Now the tests are passing on Windows which suggests that the fix works, but please double check that it makes sense.

[thornjad]

I would normally complain about the --mimetypes addition, but I'll let that go since it's already implemented in ecstatic and we're just exposing it.

Other than that, it looks like we have a merge conflict, then I think this looks good.

[thornjad]

For the conflict, I'd say just merge master, rm package-lock.json and npm i, that should give us a good package-lock again

[thornjad]

Didn't realize I had push permissions on your fork! I just merged master in. I'll see if I can get travis hooked up again so we can see tests easily

[thornjad]

Eh, looks like I don't have enough permissions to add the new Travis configuration (we were using a now-deprecated version)

[thornjad]

Huh, turns out Travis is paid now. I guess I'll see what we can get from it in this PR, then move to something better before the 0.13 release.

On my latest merge, it looks like fsevents is doing some complaining on non-Mac hosts, do you have any insight on that? It runs fine on my local Ubuntu system, so I'm not able to repro

[zbynek]

@thornjad travis is running on my branch. I changed the config to to use npm@7, it worked for all OS/Node combos except Win+Node 8: https://travis-ci.com/github/zbynek/http-server/builds/232553767

The last commit removes this combo from test matrix, I didn't manage to test it on Travis though (ran out of the free credits...), maybe you have more luck with your account.

[zbynek]

@thornjad do you want to merge as is or do you want to figure out free CI first?

[thornjad]

Eh, sorry yeah CI is the issue, I've run out of credits on Travis too. I'm thinking maybe yeah I'll just merge and figure out CI before releasing to npm