use extatic (a fork of ecstatic that will continue being maintained) - #541
use extatic (a fork of ecstatic that will continue being maintained)#541Xmader wants to merge 2 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
I'm not opposed to this, since it may provide a few benefits. We're very slowly working on rewriting http-server, possibly absorbing ecstatic's functionality into this repo, so this may end up being just a stop-gap for just the next two versions or so, would that be alright? Also, we need to merge or rebase master here, especially because there's been an important update to |
(since it has been fixed in extatic)
|
@thornjad is http-server now still relying on ecstatic, or this fork, or has "absorbed" the functionality? because the package.json here still seems to refer to a version prior the critical security fix, and which got fixed with a v4.1.3 release ecstatic, see jfhbrook/node-ecstatic@72044b8 and https://github.com/jfhbrook/node-ecstatic/releases/tag/4.1.3 (which doesn't however change the fact the original project is officially deprecated and not maintained anymore) The critical question here being, isn't http-server as well exposed to the above mentioned exploit threat? (actually asking as http-server is used in a customers projects for a currently-still-testing-setup, but still...) |
|
Closing in favor of #693 |
Please ensure that your pull request fulfills these requirements:
masterbranchWhat is the purpose of this pull request? (bug fix, enhancement, new feature,...)
Fixes #525
Fixes #502
What changes did you make?
use extatic (a fork of ecstatic that will continue being maintained) instead of the original ecstatic since ecstatic is unmaintained and deprecated
Provide some example code that this change will affect, if applicable:
N/A