Skip to content

support custom mime-type(s) via .types file - #152

Closed
dotnetCarpenter wants to merge 3 commits into
http-party:masterfrom
dotnetCarpenter:ecstatic
Closed

support custom mime-type(s) via .types file#152
dotnetCarpenter wants to merge 3 commits into
http-party:masterfrom
dotnetCarpenter:ecstatic

Conversation

@dotnetCarpenter

Copy link
Copy Markdown

This is my take on fixing #35, if my upstream PR lands.
I need some help though. I can't figure out how to test the feature with vows. If I start http-server, I can request files with custom mime-types but no matter what I do in http-server-test.js, I get an ECONNREFUSED. I'm pretty sure it's a race condition but I can't figure out how to fix it.

Any ideas?

@indexzero

Copy link
Copy Markdown
Member

Too bad you abandoned writing tests for this. I'm going to leave it open in case anyone feels compelled to write them (including myself).

@dotnetCarpenter

Copy link
Copy Markdown
Author

I might give it a shot next time I got spare time on my hands. Seems like the repo is busy at the moment - that's always encouraging.

@BigBlueHat

Copy link
Copy Markdown
Member

@dotnetCarpenter don't suppose you're still around and interested in revisiting this PR per chance? 😁

@dotnetCarpenter

dotnetCarpenter commented Apr 27, 2017 via email

Copy link
Copy Markdown
Author

@BigBlueHat

Copy link
Copy Markdown
Member

Thanks for getting this started @dotnetCarpenter! Given that the ecstatic supports it https://github.com/jfhbrook/node-ecstatic#optsmimetypes we should revisit this sometime.

I'll leave this open to track other variations or forks of this work.

Thanks again @dotnetCarpenter!

@thornjad

thornjad commented Jul 6, 2021

Copy link
Copy Markdown
Member

Should be implemented by #693, please open a new issue/PR if this is not the case

@thornjad thornjad closed this Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants