support custom mime-type(s) via .types file - #152
Closed
dotnetCarpenter wants to merge 3 commits into
Closed
Conversation
Member
|
Too bad you abandoned writing tests for this. I'm going to leave it open in case anyone feels compelled to write them (including myself). |
Author
|
I might give it a shot next time I got spare time on my hands. Seems like the repo is busy at the moment - that's always encouraging. |
Member
|
@dotnetCarpenter don't suppose you're still around and interested in revisiting this PR per chance? 😁 |
Author
|
My issue was only with the Vows test. The PR was working great but somehow
the timing was off with Vows. Maybe it's fixed by now. Unfortunately, I
don't have time in the foreseeable future to check it. But give it shot! :)
…On Tue, Apr 25, 2017 at 4:52 PM, BigBlueHat ***@***.***> wrote:
@dotnetCarpenter <https://github.com/dotnetCarpenter> don't suppose
you're still around and interested in revisiting this PR per chance? 😁
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#152 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACq87PQKaq3H-VDXq1YPrhdA6qmqW30ks5rzgi3gaJpZM4EYsDK>
.
|
Member
|
Thanks for getting this started @dotnetCarpenter! Given that the ecstatic supports it https://github.com/jfhbrook/node-ecstatic#optsmimetypes we should revisit this sometime. I'll leave this open to track other variations or forks of this work. Thanks again @dotnetCarpenter! |
Member
|
Should be implemented by #693, please open a new issue/PR if this is not the case |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my take on fixing #35, if my upstream PR lands.
I need some help though. I can't figure out how to test the feature with vows. If I start http-server, I can request files with custom mime-types but no matter what I do in http-server-test.js, I get an ECONNREFUSED. I'm pretty sure it's a race condition but I can't figure out how to fix it.
Any ideas?