[ci-fix] Needs review: deploy FileVersionInfo TestAssembly as Content on Apple NativeAOT (refs #130253)

[github-actions]

Workflow artifact: ci-fix
Artifact kind: help
Linked KBE: #130253

Important

Help-wanted / needs-review draft. This is a best-effort candidate fix that I could not build-validate in the agent environment (no Apple NativeAOT cross-build is available here). It is a genuine, non-muting change — it does not disable, skip, or [ActiveIssue] the test. Please validate on the Apple NativeAOT library-test legs before merging.

Root cause

On the Apple NativeAOT library-test legs (iossimulator / maccatalyst AllSubsets_NativeAOT, e.g. build 1494308), System.Diagnostics.Tests.FileVersionInfoTest.FileVersionInfo_CustomManagedAssembly fails with:

System.IO.FileNotFoundException : .../System.Diagnostics.FileVersionInfo.Tests.app/System.Diagnostics.FileVersionInfo.TestAssembly.dll

The test opens its companion assembly by file path to read PE version metadata — it never loads or executes it (FileVersionInfoTest.cs:25):

VerifyVersionInfo(Path.Combine(Directory.GetCurrentDirectory(), TestAssemblyFileName), ...);
// TestAssemblyFileName = "System.Diagnostics.FileVersionInfo.TestAssembly.dll"

In the test .csproj, for Apple mobile the TestAssembly was included as a plain <ProjectReference>. Under NativeAOT that assembly is compiled into the native image, so no loose .dll is deployed next to the app and Directory.GetCurrentDirectory()/...TestAssembly.dll does not exist → FileNotFoundException. Under Apple Mono the managed assembly is still deployed as a file, which is why the test passes there.

The existing [ActiveIssue(".../124344", IsAppleMobile && IsCoreCLR)] on this test does not apply here: PlatformDetection.IsCoreCLR => IsNotMonoRuntime && IsNotNativeAot is false under NativeAOT, so the test genuinely runs (and fails) on the NativeAOT leg.

These NativeAOT library tests on Apple mobile were newly enabled by #125437.

Candidate change

Deploy the TestAssembly as a Content data file on the Apple NativeAOT leg (exactly as already done for desktop), while keeping the plain project reference for Apple Mono, where the #46856 vfs-mapping workaround still applies:

• TargetsAppleMobile && UseNativeAotRuntime → Content copy (new).
• TargetsAppleMobile && !UseNativeAotRuntime (Mono) → plain reference (unchanged).
• Browser and desktop → unchanged.

Only the Apple-NativeAOT branch changes; the MSBuild conditions leave Mono Apple, browser, and desktop provably untouched, and never select both <ProjectReference> items at once.

What is unverified (why this is a draft)

• I could not run an Apple NativeAOT build here, so I have not confirmed the Content .dll actually lands at Directory.GetCurrentDirectory() inside the NativeAOT .app bundle, nor that the AppleAppBuilder NativeAOT library-mode path packages Content identically to Mono.
• Reasoning it should work: sibling Content files in this project (NativeLibrary.dll, NativeConsoleApp.exe) are already deployed and found on Apple, and under NativeAOT there is no managed-assembly vfs mapping for [wasm][aot] build tries to cross compile unrelated dlls from the publish folder #46856 to collide with — but this needs a CI run to confirm.

Validation

• Build-validated: No — Apple NativeAOT cross-build is not available in the agent environment.
• Requested: run System.Diagnostics.FileVersionInfo.Tests on the iossimulator / maccatalyst AllSubsets_NativeAOT legs and confirm FileVersionInfo_CustomManagedAssembly passes with no identical vfs mappings packaging error.

Suggested reviewers / area contacts

These tests were enabled on Apple NativeAOT by #125437 — @kotlarmilos, could you (or the mobile/NativeAOT folks) confirm the Content asset is bundled at the app's working directory under NativeAOT library mode? Area owners: @dotnet/area-system-diagnostics.

Note

This PR was generated by an AI/Copilot agent (ci-failure-fix) as a best-effort, non-muting candidate fix. Please review carefully before merging.

Note

🔒 Integrity filter blocked 17 items

The following items were blocked because they don't meet the GitHub integrity level.

• #128501 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #104998 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #104750 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #97491 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #76276 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #78999 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #76417 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #69571 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #62435 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #61444 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #35376 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #193 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #34218 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #38914 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• #44747 search_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• [ci-scan] Test failure: System.Threading.Tests.MutexTests.CrossProcess_NamedMutex_ConcurrentCreateOrOpen #130125 issue_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".
• ... and 1 more item

To allow these resources, lower min-integrity in your GitHub frontmatter:

tools:
  github:
    min-integrity: approved  # merged | approved | unapproved | none

Generated by CI Outer-Loop Failure Fixer · ● 9.3M · ◷

[MichalStrehovsky]

The workarounds for broken tooling (crossgen2, apple app builder, whatever is the problem on browser) are getting out of hand here.

If we don't want to fix the tools not to consider random Content as code (which it looks like we don't), we should instead embed the project as a resource and write it out to TEMP. This test is already writing to TEMP.

Something along the lines of:

    <ProjectReference Include="FileName.csproj">
      <ReferenceOutputAssembly>false</ReferenceOutputAssembly>
      <OutputItemType>EmbeddedResource</OutputItemType>
      <LogicalName>Filename.dll</LogicalName>
    </ProjectReference>

will embed the assembly as Filename.dll in managed resources. Then it can be dumped to TEMP and inspected. And all the workarounds deleted, instead of adding yet another axis of workarounds.

[kotlarmilos]

The workarounds for broken tooling (crossgen2, apple app builder, whatever is the problem on browser) are getting out of hand here.

If we don't want to fix the tools not to consider random Content as code (which it looks like we don't), we should instead embed the project as a resource and write it out to TEMP. This test is already writing to TEMP.

Something along the lines of:

    <ProjectReference Include="FileName.csproj">
      <ReferenceOutputAssembly>false</ReferenceOutputAssembly>
      <OutputItemType>EmbeddedResource</OutputItemType>
      <LogicalName>Filename.dll</LogicalName>
    </ProjectReference>

will embed the assembly as Filename.dll in managed resources. Then it can be dumped to TEMP and inspected. And all the workarounds deleted, instead of adding yet another axis of workarounds.

I agree, most of the mobile failures are infra related or caused by incorrect test packaging. I will try to keep the changes minimal and avoid introducing more complexity. Alternatively, I suggest disabling such tests.

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kotlarmilos]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Copilot]

Pull request overview

Updates the System.Diagnostics.FileVersionInfo tests to stop relying on a companion managed test assembly being deployed as a loose .dll file, by embedding that assembly into the test binary and extracting it to a temp file at runtime (to support scenarios like Apple NativeAOT where the .dll may not exist on disk).

Changes:

• Embed System.Diagnostics.FileVersionInfo.TestAssembly output into the test assembly as an EmbeddedResource.
• Update tests to write the embedded assembly bytes to a temp file and validate FileVersionInfo against that path (including Unix symlink tests).
• Remove the Apple Mono trimming descriptor file and related csproj wiring.

Show a summary per file

File	Description
src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/System.Diagnostics.FileVersionInfo.Tests.csproj	Switches the test-assembly project reference to produce an embedded resource instead of content/project-reference variants.
src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/FileVersionInfoTest.cs	Adds helper to extract embedded test assembly to a temp file; updates the custom-assembly test to use it.
src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/FileVersionInfoTest.Unix.cs	Updates symlink tests to use the extracted temp-file copy of the embedded test assembly.
src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/ILLink.Descriptors.xml	Removes the Apple Mono trimming descriptor that rooted the test assembly.

Copilot's findings

• Files reviewed: 4/4 changed files
• Comments generated: 2

[MichalStrehovsky]

Looks much cleaner!

[kotlarmilos]

/ba-g unrelated extra-platforms failures, no FileNotFoundException or missing assemblies