[mobile] Disable NativeAOT-specific test failures on Apple mobile by kotlarmilos · Pull Request #130168 · dotnet/runtime

kotlarmilos · 2026-07-03T09:14:18Z

Description

This disables a set of tests that fail only under the NativeAOT runtime on Apple mobile platforms while continuing to pass on CoreCLR and Mono. The failures come from keychain entitlement handling in NativeAOT app bundles, reflection and configuration-from-file behavior in Microsoft.Extensions.Hosting, and an HttpListener closed-connection case.

Gate tests that fail only under the NativeAOT runtime on Apple mobile platforms (iOS, tvOS, MacCatalyst). These pass on CoreCLR and Mono but fail on NativeAOT due to keychain entitlement handling in AOT app bundles (Pkcs), reflection/AOT differences (Microsoft.Extensions.Hosting configuration-from-file and EventSourceLogger), and other NativeAOT-only behavior. Conditioned on IsAppleMobile + IsNativeAot so coverage is retained on CoreCLR/Mono and non-Apple platforms. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…-nativeaot-apple-mobile-tests # Conflicts: # src/libraries/Microsoft.Extensions.Caching.Memory/tests/MemoryCacheSetAndRemoveTests.cs

Copilot

Pull request overview

This PR disables a set of library tests specifically for Apple mobile + NativeAOT by adding [ActiveIssue] gates to the affected test classes/methods, intending to keep coverage unchanged on CoreCLR/Mono and on non-Apple platforms.

Changes:

Add class-level [ActiveIssue] skips to multiple System.Security.Cryptography.Pkcs test classes when running on PlatformDetection.IsAppleMobile && PlatformDetection.IsNativeAot.
Add method-level [ActiveIssue] skips to failing tests in Microsoft.Extensions.Hosting, System.Net.HttpListener, System.Diagnostics.FileVersionInfo, and Microsoft.Extensions.Caching.Memory under the same Apple-mobile NativeAOT condition.
Centralize the suppression rationale via issue links in the new [ActiveIssue] attributes.

Show a summary per file

File	Description
src/libraries/System.Security.Cryptography.Pkcs/tests/SignedCms/SignerInfoTests.cs	Adds class-level `[ActiveIssue]` for Apple mobile NativeAOT.
src/libraries/System.Security.Cryptography.Pkcs/tests/SignedCms/SignedCmsTests.cs	Adds class-level `[ActiveIssue]` for Apple mobile NativeAOT.
src/libraries/System.Security.Cryptography.Pkcs/tests/SignedCms/CounterSigningDerOrder.cs	Adds class-level `[ActiveIssue]` for Apple mobile NativeAOT.
src/libraries/System.Security.Cryptography.Pkcs/tests/Rfc3161/TimestampTokenTests.cs	Adds class-level `[ActiveIssue]` for Apple mobile NativeAOT.
src/libraries/System.Security.Cryptography.Pkcs/tests/Rfc3161/TimestampRequestTests.cs	Adds class-level `[ActiveIssue]` for Apple mobile NativeAOT.
src/libraries/System.Security.Cryptography.Pkcs/tests/EnvelopedCms/DecryptTestsUsingExplicitPrivateKey.cs	Adds class-level `[ActiveIssue]` for Apple mobile NativeAOT.
src/libraries/System.Security.Cryptography.Pkcs/tests/EnvelopedCms/DecryptTestsUsingCertWithPrivateKey.cs	Adds class-level `[ActiveIssue]` for Apple mobile NativeAOT.
src/libraries/System.Security.Cryptography.Pkcs/tests/EnvelopedCms/DecryptTestsRsaPaddingModeTests.cs	Adds class-level `[ActiveIssue]` for Apple mobile NativeAOT.
src/libraries/System.Net.HttpListener/tests/HttpResponseStreamTests.cs	Adds method-level `[ActiveIssue]` for Apple mobile NativeAOT closed-connection scenarios.
src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/FileVersionInfoTest.cs	Adds method-level `[ActiveIssue]` for Apple mobile NativeAOT.
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostTests.cs	Adds method-level `[ActiveIssue]` for Apple mobile NativeAOT.
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostBuilderTests.cs	Adds method-level `[ActiveIssue]` for Apple mobile NativeAOT config-from-file scenario.
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostApplicationBuilderTests.cs	Adds method-level `[ActiveIssue]` for Apple mobile NativeAOT config-from-file scenario.
src/libraries/Microsoft.Extensions.Caching.Memory/tests/MemoryCacheSetAndRemoveTests.cs	Adds method-level `[ActiveIssue]` for Apple mobile NativeAOT.

Copilot's findings

Files reviewed: 13/13 changed files
Comments generated: 14

Use dotnet#126697 (test failures in .NET Apple mobile apps on NativeAOT) instead of dotnet#127786, which is scoped to System.Runtime.Tests single-file/static-link bundle failures and does not track these library test failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

kotlarmilos · 2026-07-03T09:27:20Z

/azp run runtime-extra-platforms

azure-pipelines · 2026-07-03T09:27:32Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Copilot's findings

Files reviewed: 13/13 changed files
Comments generated: 2

Copilot

Copilot's findings

Files reviewed: 13/13 changed files
Comments generated: 2

The Apple mobile NativeAOT tracking issue (dotnet#126697) lists FileVersionInfo_EmptyFVI as the failing FileVersionInfo test (it loads Assembly1.cs via a relative path that is not bundled into the .app). The gate was only applied to FileVersionInfo_CustomManagedAssembly, so add the same NativeAOT ActiveIssue gate to FileVersionInfo_EmptyFVI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

kotlarmilos · 2026-07-03T12:55:33Z

/azp run runtime-extra-platforms

azure-pipelines · 2026-07-03T12:55:50Z

Azure Pipelines successfully started running 1 pipeline(s).

The System.Net.HttpListener.Tests project is fully excluded for Apple mobile NativeAOT in tests.proj, so the per-test [ActiveIssue] annotations for the same configuration were dead. Keep the project-level exclusion as the single mechanism. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Copilot's findings

Files reviewed: 16/16 changed files
Comments generated: 2

Copilot

Copilot's findings

Files reviewed: 16/16 changed files
Comments generated: 1

kotlarmilos · 2026-07-09T09:13:30Z

/azp run runtime-extra-platforms

azure-pipelines · 2026-07-09T09:13:43Z

Azure Pipelines successfully started running 1 pipeline(s).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b83f3804-8c74-4dcb-a966-f80032c96f9a

Copilot

Copilot's findings

Comments suppressed due to low confidence (1)

src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/FileVersionInfoTest.cs:27

WriteEmbeddedResourceToFile assumes GetManifestResourceStream(resourceName) succeeds. If the embedded resource name ever changes (e.g., LogicalName mismatch), this will fail with a NullReferenceException at source.CopyTo, which is hard to diagnose in CI. Consider throwing a clear exception when the resource stream is null.

        {
            string path = GetTestFilePath();
            using (Stream source = typeof(FileVersionInfoTest).Assembly.GetManifestResourceStream(resourceName))
            using (FileStream destination = File.Create(path))
            {
                source.CopyTo(destination);
            }

Files reviewed: 14/14 changed files
Comments generated: 0 new

Copilot

Copilot's findings

Comments suppressed due to low confidence (1)

src/libraries/System.Diagnostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/FileVersionInfoTest.cs:26

WriteEmbeddedResourceToFile will currently throw a NullReferenceException if the embedded resource name is wrong (GetManifestResourceStream returns null). Since this method is now used with multiple resource names (including "Assembly1.cs"), it’s worth failing with a clear exception message to make CI failures actionable.

        private string WriteEmbeddedResourceToFile(string resourceName)
        {
            string path = GetTestFilePath();
            using (Stream source = typeof(FileVersionInfoTest).Assembly.GetManifestResourceStream(resourceName))
            using (FileStream destination = File.Create(path))
            {
                source.CopyTo(destination);
            }

Files reviewed: 14/14 changed files
Comments generated: 0 new

Copilot AI review requested due to automatic review settings July 3, 2026 09:14

github-actions Bot added the area-System.Security label Jul 3, 2026

dotnet-policy-service Bot assigned kotlarmilos Jul 3, 2026

Copilot started reviewing on behalf of kotlarmilos July 3, 2026 09:16 View session

Merge remote-tracking branch 'github-public/main' into mobile/disable…

3b59ce8

…-nativeaot-apple-mobile-tests # Conflicts: # src/libraries/Microsoft.Extensions.Caching.Memory/tests/MemoryCacheSetAndRemoveTests.cs

Copilot AI reviewed Jul 3, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 3, 2026 09:22

Copilot started reviewing on behalf of kotlarmilos July 3, 2026 09:22 View session

Copilot AI reviewed Jul 3, 2026

View reviewed changes

Comment thread src/libraries/System.Security.Cryptography.Pkcs/tests/SignedCms/SignedCmsTests.cs Outdated

Comment thread src/libraries/System.Security.Cryptography.Pkcs/tests/SignedCms/SignedCmsTests.cs Outdated

Copilot AI review requested due to automatic review settings July 3, 2026 09:29

Copilot started reviewing on behalf of kotlarmilos July 3, 2026 09:29 View session

Copilot AI reviewed Jul 3, 2026

View reviewed changes

Comment thread src/libraries/System.Security.Cryptography.Pkcs/tests/SignedCms/SignedCmsTests.cs

Comment thread ...ostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/FileVersionInfoTest.cs

kotlarmilos added area-Infrastructure os-ios Apple iOS and removed area-System.Security labels Jul 3, 2026

github-project-automation Bot added this to Runtime Infra Jul 3, 2026

kotlarmilos requested review from matouskozak and vitek-karas July 3, 2026 12:57

vitek-karas approved these changes Jul 3, 2026

View reviewed changes

Copilot started reviewing on behalf of kotlarmilos July 9, 2026 08:52 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread ...ostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/FileVersionInfoTest.cs

Comment thread src/libraries/tests.proj

Copilot AI review requested due to automatic review settings July 9, 2026 08:56

Copilot started reviewing on behalf of kotlarmilos July 9, 2026 09:00 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

Comment thread ...ostics.FileVersionInfo/tests/System.Diagnostics.FileVersionInfo.Tests/FileVersionInfoTest.cs Outdated

kotlarmilos mentioned this pull request Jul 9, 2026

[Apple mobile][NativeAOT] Construct the test publish folder instead of stripping extensions in AppleAppBuilder #130399

Open

kotlarmilos requested a review from MichalStrehovsky July 9, 2026 15:19

MichalStrehovsky approved these changes Jul 10, 2026

View reviewed changes

Merge main into mobile/disable-nativeaot-apple-mobile-tests

8b3c7bf

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b83f3804-8c74-4dcb-a966-f80032c96f9a

Copilot AI review requested due to automatic review settings July 10, 2026 09:13

Copilot started reviewing on behalf of kotlarmilos July 10, 2026 09:14 View session

Remove redundant FileVersionInfo comments

b05977e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b83f3804-8c74-4dcb-a966-f80032c96f9a

kotlarmilos requested a review from MichalStrehovsky July 10, 2026 09:23

kotlarmilos enabled auto-merge (squash) July 10, 2026 09:23

Copilot AI reviewed Jul 10, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 10, 2026 09:24

Copilot started reviewing on behalf of kotlarmilos July 10, 2026 09:24 View session

Copilot AI reviewed Jul 10, 2026

View reviewed changes

MichalStrehovsky approved these changes Jul 10, 2026

View reviewed changes

Copilot AI mentioned this pull request Jul 10, 2026

Increase vectorized Tan test tolerance #130469

Draft

kotlarmilos mentioned this pull request Jul 10, 2026

[ci-scan] Test failure: System.Globalization.Tests.IdnMappingGetUnicodeTests DllNotFoundException 'libSystem.Globalization.Native' on browser-wasm CoreCLR #130479

Open

kotlarmilos merged commit 5605993 into dotnet:main Jul 10, 2026
85 of 88 checks passed

github-project-automation Bot moved this to Done in Runtime Infra Jul 10, 2026

This was referenced Jul 10, 2026

System.Net.NameResolution.Tests DNS failures: Name or service not known #126641

Open

DnsGetHostAddresses_LocalhostWithTrailingDot_ReturnsLoopback - SocketException : Name or service not known #128759

Open

dotnet-maestro Bot mentioned this pull request Jul 11, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#7672

Merged

dotnet-milestone-bot Bot added this to the 11.0-preview7 milestone Jul 11, 2026

Uh oh!

Conversation

kotlarmilos commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kotlarmilos commented Jul 3, 2026

Uh oh!

azure-pipelines Bot commented Jul 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

kotlarmilos commented Jul 3, 2026

Uh oh!

azure-pipelines Bot commented Jul 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

kotlarmilos commented Jul 9, 2026

Uh oh!

azure-pipelines Bot commented Jul 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot's findings

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kotlarmilos commented Jul 3, 2026 •

edited

Loading