[skip ci] Fix optComputeAssertionGen dump newline.#193
Merged
Conversation
Contributor
Author
|
Looks like [skip ci] in the PR title doesn't work in that repo, cc @dotnet/runtime-infrastructure Do we have a new way to skip running tests on PRs that do not need them? |
Member
|
This seems to be specific for continuous integration builds not for PR builds. Maybe it has to be part of the commit message? |
Contributor
Author
|
Thanks @safern, I will try to do that in the next PR. |
MichalStrehovsky
added a commit
to MichalStrehovsky/runtime
that referenced
this pull request
Dec 9, 2021
Fixes dotnet#193. Since we don't have a module load event (everything is "loaded" at compile time), we can't get the same module initializer timing as CoreCLR. Since the spec allows running them at arbitrary time before accessing things within the module, we simply run them before `Main`. We order them so that if module X references module Y, we run Y's initializer before X. We could also potentially look into running them at compile time (same as other cctors).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before we were printing it like: