Skip to content

[skip ci] Fix optComputeAssertionGen dump newline.#193

Merged
sandreenko merged 1 commit into
dotnet:masterfrom
sandreenko:fixSomeDumps
Nov 22, 2019
Merged

[skip ci] Fix optComputeAssertionGen dump newline.#193
sandreenko merged 1 commit into
dotnet:masterfrom
sandreenko:fixSomeDumps

Conversation

@sandreenko

Copy link
Copy Markdown
Contributor

Before we were printing it like:

In BB03 New Global ArrBnds  Assertion: (0, 0) ($0,$0) [idx: {PhiDef($1, $2, $240)};len: {ARR_LENGTH($200)}] in range  index=#04, mask=0000000000000008
          <- extra new line here.
BB01 valueGen = 0000000000000000
BB02 valueGen = 0000000000000002 => BB06 valueGen = 0000000000000001,
BB03 valueGen = 000000000000000C
BB04 valueGen = 0000000000000000
BB05 valueGen = 0000000000000000
BB06 valueGen = 0000000000000000AssertionPropCallback::StartMerge: BB01 in ->  
0000000000000000 <- no newline here.

@sandreenko sandreenko added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Nov 21, 2019
@sandreenko sandreenko requested a review from briansull November 21, 2019 21:53
@sandreenko

Copy link
Copy Markdown
Contributor Author

Looks like [skip ci] in the PR title doesn't work in that repo, cc @dotnet/runtime-infrastructure

Do we have a new way to skip running tests on PRs that do not need them?

@safern

safern commented Nov 21, 2019

Copy link
Copy Markdown
Member

This seems to be specific for continuous integration builds not for PR builds.

https://docs.microsoft.com/en-us/azure/devops/pipelines/build/triggers?view=azure-devops&tabs=yaml#skipping-ci-for-individual-commits

Maybe it has to be part of the commit message?

@sandreenko

Copy link
Copy Markdown
Contributor Author

Thanks @safern, I will try to do that in the next PR.

@briansull briansull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandreenko sandreenko merged commit b4c4429 into dotnet:master Nov 22, 2019
@sandreenko sandreenko deleted the fixSomeDumps branch November 22, 2019 00:45
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
MichalStrehovsky added a commit to MichalStrehovsky/runtime that referenced this pull request Dec 9, 2021
Fixes dotnet#193.

Since we don't have a module load event (everything is "loaded" at compile time), we can't get the same module initializer timing as CoreCLR. Since the spec allows running them at arbitrary time before accessing things within the module, we simply run them before `Main`. We order them so that if module X references module Y, we run Y's initializer before X.

We could also potentially look into running them at compile time (same as other cctors).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants