add get-apos-doc-id and set-apos-doc-id tasks - #5136
Merged
Merged
Conversation
haroun
marked this pull request as ready for review
November 11, 2025 18:23
boutell
requested changes
Nov 11, 2025
* main: Pro 8541 switch locale empty doc (#5135)
boutell
requested changes
Nov 13, 2025
|
|
||
| // const req = self.apos.task.getReq({ mode: 'draft', locale }); | ||
| const aposLocale = new RegExp(`^${self.apos.util.regExpQuote(locale)}:`); | ||
| const criteria = _id |
Member
There was a problem hiding this comment.
One last thing, sorry... since the _id parameter has to be a full _id, which already contains the locale, there's no need to make locale mandatory or even part of the query when _id is present.
(Technically we don't need to make a query at all when _id is the argument, because _id already contains aposDocId, but I like the idea of making the query because it validates that the document actually does exist.)
* main: PRO-8708: bring back passing of the actual area options in the form developers expect to see them to custom insert menu item components (#5162) adds object of useful error when widget fails to render (#5141) add addMissingSchemaFields task (#5101) Pro 8360 box field (#5142) Pro 8671 fix localize modal (#5156) longPolling: false option (#5154) PRO-5472: file widget (#5126)
boutell
reviewed
Nov 19, 2025
| @@ -7,6 +7,7 @@ | |||
| * Add `@apostrophecms/migration:add-missing-schema-fields` task. This task does not run database migrations. | |||
Member
There was a problem hiding this comment.
How did this creep into this PR? It's not hurting anything
boutell
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
@apostrophecms/doc:get-apos-doc-idand@apostrophecms/doc:set-apos-doc-idtasksWhat are the specific steps to test this change?
@apostrophecms/doc:get-apos-doc-idand@apostrophecms/doc:set-apos-doc-idand check the resultsWhat kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: