Pro 8671 fix localize modal - #5156
Merged
Merged
Conversation
ValJed
force-pushed
the
pro-8671-fix-localize-modal
branch
from
November 13, 2025 13:41
d92bc1e to
39bc51b
Compare
ValJed
commented
Nov 13, 2025
| this.docTypesSeen.push(item.value); | ||
| this.wizard.values.relatedDocTypesToLocalize.data.push(item.value); | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
What the watcher on relatedDocTypes used to do, no need for a watcher here since we want to set it when related doc types are set in batch mode only.
| this.wizard.values.relatedDocTypesToLocalize.data.push(doc.type); | ||
| } | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
What the watcher on relatedDocs used to do, no need for a watcher here since relatedDocs is set by the method updateRelatedDocs all the time. Makes code more comprehensible.
myovchev
approved these changes
Nov 13, 2025
myovchev
left a comment
myovchev
left a comment
Contributor
There was a problem hiding this comment.
And there is also apos.getActiveLocale(). We really need to document "how to get current locale" once and for all.
Contributor
Author
|
@myovchev |
haroun
added a commit
that referenced
this pull request
Nov 19, 2025
* main: PRO-8708: bring back passing of the actual area options in the form developers expect to see them to custom insert menu item components (#5162) adds object of useful error when widget fails to render (#5141) add addMissingSchemaFields task (#5101) Pro 8360 box field (#5142) Pro 8671 fix localize modal (#5156) longPolling: false option (#5154) PRO-5472: file widget (#5126)
haroun
added a commit
that referenced
this pull request
Nov 19, 2025
* main: PRO-8708: bring back passing of the actual area options in the form developers expect to see them to custom insert menu item components (#5162) adds object of useful error when widget fails to render (#5141) add addMissingSchemaFields task (#5101) Pro 8360 box field (#5142) Pro 8671 fix localize modal (#5156) longPolling: false option (#5154) PRO-5472: file widget (#5126)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use
modalData.localeinAposI18nLocalizecomponent. This generates somehow a watcher to not be triggered so:moves
relatedDocTypesto data (recomputed only whenrelatedDocschange). Get rid of two watchers.What are the specific steps to test this change?
https://github.com/apostrophecms/testbed/actions/runs/19333410651 🟢
What kind of change does this PR introduce?
Make sure the PR fulfills these requirements: