Skip to content

PRO-8571: fix the astro section template library bug introduced in astro 4.9.0 - #5140

Merged
boutell merged 3 commits into
mainfrom
pro-8571
Nov 6, 2025
Merged

boutell merged 3 commits into
mainfrom
pro-8571

Conversation

@boutell

@boutell boutell commented Nov 5, 2025

Copy link
Copy Markdown
Member

No description provided.

@boutell
boutell requested a review from haroun November 5, 2025 16:57
@linear

linear Bot commented Nov 5, 2025

Copy link
Copy Markdown

headers: {
'apos-external-front-key': self.apos.externalFrontKey
'apos-external-front-key': self.apos.externalFrontKey,
// Without this Astro enforces CSRF protection starting in version 4.9.0

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course it is always appropriate to specify a content type here so I'm not really blaming Astro but they started enforcing it recently

@boutell
boutell requested a review from BoDonkey November 5, 2025 18:54
BoDonkey
BoDonkey previously approved these changes Nov 5, 2025
Comment thread modules/@apostrophecms/area/index.js Outdated
'apos-external-front-key': self.apos.externalFrontKey
'apos-external-front-key': self.apos.externalFrontKey,
// Without this Astro enforces CSRF protection starting in version 4.9.0
'content-type': 'application-json'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean this instead or I'm missing something?

Suggested change
'content-type': 'application-json'
'content-type': 'application/json'

@boutell

boutell commented Nov 6, 2025

Copy link
Copy Markdown
Member Author

Fixed that nasty typo, thank you!

@boutell
boutell merged commit 8c91749 into main Nov 6, 2025
9 checks passed
@boutell
boutell deleted the pro-8571 branch November 6, 2025 16:13
haroun added a commit that referenced this pull request Nov 11, 2025
…ation

* main:
  fix tooltip prop (#5139)
  Radio icon buttons (#5121)
  Fix typos in some files (#5144)
  PRO-8571: fix the astro section template library bug introduced in astro 4.9.0 (#5140)
  bump nodemailer to v7 (#5138)
  Pro 8563 translation (#5134)
  release 4.23.0 (#5132)
  change disabled layout translation (#5131)
  max width for micro color label (#5130)
  uses operation name for key and id (test purpose) (#5129)
  Fix native actions params (#5128)
  moves widget operations to backend (#5111)
haroun added a commit that referenced this pull request Nov 11, 2025
* main:
  fix tooltip prop (#5139)
  Radio icon buttons (#5121)
  Fix typos in some files (#5144)
  PRO-8571: fix the astro section template library bug introduced in astro 4.9.0 (#5140)
  bump nodemailer to v7 (#5138)
  Pro 8563 translation (#5134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants