RTC: Fix Yjs undo manager to update UI state when undo stack changes - #78864
Merged
Conversation
…hen the undo stack is modified
alecgeatches
added
[Type] Bug
|
Size Change: +408 B (0%) Total Size: 8.21 MB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
Author
|
The first change in this PR adds an The test failure is now accurately showing the Yjs undo manager adding an incorrect undo stack item in the editor. The next step is to ensure that async template syncs do not create an undo manager item to fix the test. |
…hanges have no intended change to roll into
|
Flaky tests detected in 518905a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/26833655856
|
alecgeatches
marked this pull request as ready for review
June 1, 2026 20:40
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
Author
|
@youknowriad I'd love for you to have a look at the changes in this PR. You identified the root cause specifically in your comment here when the sync manager was introduced, and now a small timing change in another PR (#78756) rediscovered the problem. Note that the solution here uses a sync manager callback instead of a store to communicate with core-data, which seems a bit simpler and aligns with the existing ways we communicate outside of the sync manager. |
youknowriad
reviewed
Jun 2, 2026
| updateOptions.undoIgnore = true; | ||
| } | ||
| updateParent( blocksForParent, updateOptions ); | ||
| } |
Contributor
There was a problem hiding this comment.
I don't understand why there are changes to the block-editor package and how they relate to the current PR?
Contributor
Author
There was a problem hiding this comment.
Good question, I didn't explain the flow.
useBlockSync is the place where block-editor changes are converted into the onInput / onChange callbacks that eventually call editEntityRecord. This is part of the plumbing into core data. Here's the flow:
-
We insert an async template and don't want it to create an undo item. The "ignore history in this undo" starts in
useInnerBlockTemplateSync, which calls__unstableMarkNextChangeAsNotPersistent( { history: 'ignore' } );. -
The block-editor store records that as the next block change’s history mode, and exposes it through a selector.
-
For the line you commented on above,
useBlockSyncbridges from block-editor to the core-dataonInputcallback. It reads the history mode and addsundoIgnore: truewhen the mode ishistory: 'ignore'to theonInputcallback. -
useEntityBlockEditor.onInputforwards those options intoeditEntityRecord. -
editEntityRecordunderstandsundoIgnore, and merges into the CRDT withLOCAL_UNDO_IGNORED_ORIGIN, so the Yjs document still receives the template change but the Yjs undo manager does not capture it.
The undoIgnore flag plumbing is used communicate to core-data to treat the template insertion differently than a normal cached block edit and have it avoid creating an undo item.
Contributor
There was a problem hiding this comment.
Sorry for the confusion, I was not pointing that line specifically, It's just that in my mind, the bug that I highlighted before has nothing to do with block-editor store, it was a core-data selector, so I don't understand how the changes to block-editor are related to that bug fix.
Contributor
Author
There was a problem hiding this comment.
Got it. In my mind, the connection to the original comment you left is this:
Should we try to address it or should we assume that if there's an undo or redo that is created something else in the "state" of core-data is probably changing at the same time (which triggers the selectors again). (Basically accept that the bug exists but is hidden, or hard to reproduce)
In dependent PR #78756, we made a small timing adjustment to CRDT updates which caused hasUndo and hasRedo to update in-time with the actual Yjs undo stack, which it was not doing before. This revealed that Yjs was incorrectly adding an undo stack item, but it wasn't reflected in the UI for the test because "core-data is probably changing at the same time" wasn't actually happening. Once we started correctly reflecting the undo state in the UI, the test promptly failed because we weren't supposed to be creating an undo item. The behavior was always wrong, but we didn't see it because undo stack UI updates weren't being dispatched. That's the problem you described.
This PR address both your comment and the break:
-
We're now ensuring that stack updates, regardless of timing, actually update UI state instead of relying on "probably changing" second-order effects.
-
One of the consequences of correct undo stack UI display is the failure of the
inner-blocks-templates.spec.jstest because of an incorrectly-created undo item. The rest of the changes in this PR are to address the underlying issue to allow Yjs to correctly skip an undo item for this particular case.The changes are largely in the block editor as the originator of the
__unstableMarkNextChangeAsNotPersistentsignal, and the place where we can understand the intended meaning of that signal.
youknowriad
reviewed
Jun 2, 2026
|
|
||
| // This reducer intentionally stores no data. It only changes reference so the | ||
| // registry notifies core-data subscribers to refresh sync undo manager state. | ||
| export function syncUndoManagerChangeReference( state = {}, action ) { |
Contributor
There was a problem hiding this comment.
I was expecting this state to be used somewhere, I don't see it used anywhere, am I missing something?
Contributor
There was a problem hiding this comment.
I guess what this does right now is that it forces the subscribe of the "store" to be called again, the problem though is that it doesn't force useSelect calls to rerender
A useSelect that does:
const undoManager = useSelect((select) => select('core-data').getUndoManager(), []); const undo = undoManager.getUndo()
fails to render.
A useSelect that does would
const undo = useSelect((select) => select('core-data').getUndoManager().getUndo(), []);
There's a way to potentially solve both by making getUndoManager return a "cloned" instance of the real undo manager when syncUndoManagerChangeReference changes. (use a memoized selector that does return {...getSyncManager()?.undoManager}
Contributor
Author
There was a problem hiding this comment.
That's a good point! I don't really like how the undoManager reference changes to show that the undo stack has changed, it's pretty indirect and maybe hard to understand. Most uses of undoManager are to call functions on it like .undo() or .addToScope(), and in those places a changing reference in response to undo stack changes doesn't make a lot of sense.
Working on a refactor that uses actual hasUndo/hasRedo state to update the UI instead so we don't need to mutate the underlying manager reference.
Contributor
Author
There was a problem hiding this comment.
Thanks, this helped to clean things up. I ended up changing the implementation in e201585 so we no longer rely on getUndoManager() mutation through a reference or spread.
Instead, the sync undo manager now sends undo/redo into core-data state, and the public hasUndo() / hasRedo() selectors read from that state when the sync manager is active. That gives the editor UI a direct state dependency to subscribe to, rather than relying on getUndoManager() returning a new reference.
So your code above:
const undoManager = useSelect((select) => select('core-data').getUndoManager(), []);
const undo = undoManager.getUndo()still won't update when a new undo/redo is available, but instead hasUndo and hasRedo are reactive:
const hasUndo = useSelect(( select ) => select('core-data').hasUndo(), []);This avoids the dummy reference/clone and the related side-effects. getUndoManager() still remains returns the actual manager object, while reactive UI depends on plain store state.
This does mean the first code snippet above will not be expected to re-render, because it selects the manager object rather than undo availability. But that seems okay for this PR, since the existing undo/redo UI uses hasEditorUndo() / hasEditorRedo() which is derived straight from core-data hasUndo() / hasRedo().
Contributor
There was a problem hiding this comment.
That seems like a better path forward indeed, but should we remove the getUndoManager selector or is it still needed?
Contributor
Author
There was a problem hiding this comment.
I think it is still needed, but it has a smaller role. We can now read hasUndo/hasRedo directly from core-data state, but actions still need getUndoManager() to perform the actual operations.
We still use it to pass actions into the undo manager like in editEntityRecord and undo/redo operations. The selector is also a good abstraction that picks the sync undo manager when RTC is active and falls back to the default WordPress undo manager otherwise. So still useful, I think.
…a changing undoManager reference
youknowriad
reviewed
Jun 3, 2026
| * as not persistent. | ||
| * | ||
| * By default, non-persistent changes may still merge into undo history. Use | ||
| * `history: 'ignore'` for derived changes that should never be captured by undo. |
Contributor
There was a problem hiding this comment.
I'm having a hard time understanding the difference between "non persistent" change and a change that is ignored from history. My memory might be failing me a bit.
Contributor
Author
There was a problem hiding this comment.
Good question, I think the terminology is confusing. My apologies in advance for the wall of text.
"Non-persistent" is the block-editor distinction between sending a block-editor change through onInput versus onChange (trunk link). A non-persistent/onInput change does not create a new undo stack item by itself, but can still end up in history. The most obvious use is in typing, where each character should update the editor immediately but should not create a separate undo level. Those are staged and later converted into a persistent change after a timeout so they create a new undo stack item.
However, these "non-persistent" markers are used with different purposes. Edit from the PR description:
Typically
__unstableMarkNextChangeAsNotPersistent()calls are proceeded by anonChange()call, and the flag is used to mark "merge the next operation into the prior item". However inuseInnerBlockTemplateSync()the non-persistent call is NOT paired with an existing change. On a fresh page load, which happens in the test, there is no prior undo item to roll changes into, and so the Yjs undo manager creates a fresh undo for the entity change anyway.
In other uses of __unstableMarkNextChangeAsNotPersistent(), the history behavior is implicitly merge, and the change is treated as an update that should be combined into another change.
Before this PR, both typing and template sync reach the undo layer with the same shape, non-persistent or isNewUndoLevel: false in the sync path. That is enough for the built-in WordPress undo manager because it has a staged-record concept. Cached records are held in stagedRecord and do not affect hasUndo() until they are later merged into history.
Yjs works differently. It observes CRDT transactions as they happen and modifies the local undo stack outside of the editor. We have tools to stopCapturing() and use local transactions to avoid creating undo items in Yjs (like in this PR), but we need enough information to avoid undo stack manipulation when we're transacting document changes. If a non-persistent change is initiated by the editor and there is no prior stack item to merge into (as in the test), without other context, Yjs will still create an undo stack item.
That is why this template still case can be fixed with the history: 'ignore' mode. The template update should still be applied and synced, but it has no user edit to merge into, so it needs to use an untracked origin and be skipped by undo history entirely. Implementing true WordPress-style staging for Yjs would require a forked undo-manager layer, or some rough manipulation of Yjs stack internals.
Contributor
There was a problem hiding this comment.
Ok I'm going to ping @ellatrix here just for awareness. This feels a bit complex and I just to want make sure we're not shooting ourselves in the foot by this extra complexity.
youknowriad
approved these changes
Jun 4, 2026
youknowriad
left a comment
youknowriad
left a comment
Contributor
There was a problem hiding this comment.
Approving to unblock this. Noting that I'd have preferred to avoid the block-editor package changes, but seems like there's no way around it.
Contributor
Author
|
Thank you @youknowriad! |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Jun 30, 2026
This updates the pinned commit hash of the Gutenberg repository from `14db4ab9395a9e96430eed678e4288a59eecbd15 ` (version `23.3.0`) to `14db4ab9395a9e96430eed678e4288a59eecbd15` (version `23.4.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v23.3.0..v23.4.0. The following commits are included: - Hide image dimension tools when a state is selected (WordPress/gutenberg#78670) - Changed labels to consistently use Patterns in favor of Block patterns (WordPress/gutenberg#56880) - Fix: Restrict parent page API search to post titles only (WordPress/gutenberg#78683) - Update AGENTS.md to mention additional pitfalls: (WordPress/gutenberg#78718) - Docs: Fix big_image_size_threshold xref typo (WordPress/gutenberg#76299) - Compose: Fully deprecate the 'pure' HoC (WordPress/gutenberg#78674) - Common CSS: avoid false-positive border-style on custom properties (WordPress/gutenberg#77476) - Compose: Fix SSR crash in useMediaQuery and useViewportMatch (WordPress/gutenberg#78725) - CI: Skip plugin repo release when SVN tag already exists (WordPress/gutenberg#78476) - Dashboard: Hello Dolly (WordPress/gutenberg#78648) - UI: `Tooltip.Provider` — forward upstream `closeDelay` and `timeout` props (WordPress/gutenberg#78642) - Compose: Support React 19 ref callback cleanups in `useMergeRefs` (WordPress/gutenberg#78685) - Add copilot-instructions.md file (WordPress/gutenberg#78584) - Dashboard: show ghost widgets visually & allow easy removal (WordPress/gutenberg#78502) - Bump fast-xml-builder from 1.0.0 to 1.2.0 (WordPress/gutenberg#78272) - Bump actions/stale (WordPress/gutenberg#78745) - Bump fast-xml-parser from 4.5.0 to 4.5.6 (WordPress/gutenberg#77167) - Bump actions/github-script from 8.0.0 to 9.0.0 in /.github/workflows (WordPress/gutenberg#78591) - @wordpress/theme: deduplicate addFallbackToVar helper (WordPress/gutenberg#78666) - Add Combobox primitives (WordPress/gutenberg#78399) - Editor: Fix keyboard activation of the template actions preview (WordPress/gutenberg#78641) - Theme: drop `density` support from `@wordpress/theme` (WordPress/gutenberg#78741) - Tooltip migration: fields + media-editor + media-fields + global-styles-ui (4/5) (WordPress/gutenberg#78691) - List View: Expose block visibility label to assistive technology (WordPress/gutenberg#78640) - Hide paragraph Drop cap control when a state is selected (WordPress/gutenberg#78672) - Image cropper: round zoom control values and display as percentages (WordPress/gutenberg#78757) - Media Editor Modal: Try placing the save and cancel buttons in the footer (WordPress/gutenberg#78708) - Unset grid span defaults with viewport states enabled (WordPress/gutenberg#78709) - Media Editor: Remove resize handles toggle from crop panel (WordPress/gutenberg#78758) - Image Editor: focus return after closing image crop modal (WordPress/gutenberg#78711) - Add dashboard Events widget (WordPress/gutenberg#78553) - Writing flow: Delete at end of nested list item should merge into next block (WordPress/gutenberg#78742) - RTC: Re-render collaborators overlay when the block tree changes (WordPress/gutenberg#78636) - Dashboard: rename `widget-types` to `widget-primitives` and consolidate the widget contract (WordPress/gutenberg#78749) - Fix Gutenberg plugin assuming its directory is named "gutenberg" (WordPress/gutenberg#78705) - Codemods: Remove one-shot Tooltip migration codemod (WordPress/gutenberg#78669) - Dashboard: rename `WidgetChrome` to `DashboardWidgetChrome` (WordPress/gutenberg#78751) - Paragraph: Strip stale block-support classes from className during align attribute migration (WordPress/gutenberg#78731) - Global Styles: Fix CSS not applying to Custom CSS textarea in Advanced panel (WordPress/gutenberg#78773) - scripts: Use require.resolve for SVG loaders to fix pnpm compat (WordPress/gutenberg#78777) - Post list: Remove close button from Quick Edit drawer (WordPress/gutenberg#78730) - Revert "Gate client-side media processing as plugin-only (WordPress/gutenberg#76700)" (WordPress/gutenberg#76751) - Tooltip migration: boot consumers + shell-level Tooltip.Provider (5/5) (WordPress/gutenberg#78692) - Dashboard: replace `surface` with `host` in widget contract docs (WordPress/gutenberg#78778) - Shortcode block: Fix editor crash when selecting transform menu (WordPress/gutenberg#78770) - Make `@wordpress/nux` a no-op compatibility package (WordPress/gutenberg#77773) - Tests: Temporarily disable REST index output-format assertions (WordPress/gutenberg#78788) - Hide Cover overlay controls for viewport states (WordPress/gutenberg#78763) - Fix type of `$block_instance` parameter in `block_core_image_render_lightbox()` (WordPress/gutenberg#78790) - TypeScript: Migrate server-side-render package to TS (WordPress/gutenberg#71383) - feat: Migrate performance results to tools release (WordPress/gutenberg#78761) - wp-build: Fix black flash on wp-admin pages before hydration (WordPress/gutenberg#78493) - Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774) - Dashboard: Use Howdy greeting for page title (WordPress/gutenberg#78740) - Block Editor: Refactor Inserter to a function component (WordPress/gutenberg#78766) - Dashboard: Move layout settings to customize toolbar (WordPress/gutenberg#78738) - Build: update changelog (WordPress/gutenberg#78807) - Icons: rename timeToRead to time (WordPress/gutenberg#78804) - RTC: Prevent slower polling filters (WordPress/gutenberg#78811) - Button.Icon: Fix clipped icons (WordPress/gutenberg#78614) - Bump docker/login-action (WordPress/gutenberg#78819) - RTC: Return forbidden rooms together (WordPress/gutenberg#78748) - Update browserslist (WordPress/gutenberg#78840) - Try allowing transforms to a variation of another block (WordPress/gutenberg#78713) - Elements: Guard against non-string className in render filter (WordPress/gutenberg#78841) - e2e-test-utils-playwright: add src to published NPM files (WordPress/gutenberg#78847) - Editor: Refactor 'PostPublishButton' into function component (WordPress/gutenberg#78737) - Dashboard: Promote WidgetRender into widget-primitives (WordPress/gutenberg#78821) - Notes: Show default avatar in the indicator when user avatars are disabled (WordPress/gutenberg#78849) - Revert "Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774)" (WordPress/gutenberg#78854) - Media: Send Document-Isolation-Policy header on the site preview frame (WordPress/gutenberg#78404) - Revert navigation morph & playlist commits pushed directly to trunk (WordPress/gutenberg#78857) - Fix Update button staying active when changes are reverted. (WordPress/gutenberg#78567) - Docs: Fix and improve documentation (WordPress/gutenberg#78686) - Abilities: Add validation tests pinning behavior for WP-specific schema keywords (WordPress/gutenberg#78783) - Tools: migrate docs/tool into tools/docs workspace (WordPress/gutenberg#78870) - Dashboard: Fix Add widget error on non-secure HTTP origins (WordPress/gutenberg#78850) - Docs: Fix @wordpress/data README fragment links (WordPress/gutenberg#78866) - bin: Remove obsolete bin/setup-local-env.sh (WordPress/gutenberg#78871) - Boot navigation: wrap items in a list role for valid listitem semantics (WordPress/gutenberg#78829) - wp-build: Document generated page hooks per WordPress standards. (WordPress/gutenberg#78826) - Update CODEOWNERS for tooling directories (WordPress/gutenberg#78874) - Block Visibility: Keep hide-everywhere working after a block opts out of visibility support (WordPress/gutenberg#78780) - Dashboard: Replace grid row height controls with size presets. (WordPress/gutenberg#78735) - Prevent font-size propagation in Navigation items causing `em` compounding (WordPress/gutenberg#77419) - Media Editor Modal: Reorder details fields so the editable regular layout fields appear at the top (WordPress/gutenberg#78792) - Fix media editor sidebar close button label (WordPress/gutenberg#78895) - Dashboard: event widget iteration (WordPress/gutenberg#78815) - Playlist Block: Add visualization style selector (WordPress/gutenberg#76147) - [Content Types]: Fix extra Page padding causing vertical scrollbar (WordPress/gutenberg#78661) - Remove migrated dependencies from root package.json (WordPress/gutenberg#78813) - Packages: Declare missing `@types/react` dependency (WordPress/gutenberg#78882) - Fix collapsed experiment cards not stretching to full width (WordPress/gutenberg#78910) - Element: add polyfills for render, hydrate, unmountComponentAtNode (WordPress/gutenberg#78899) - Revert "wp-build: Replace getter-based exports with data properties" (WordPress/gutenberg#78917) - React: add ReactCurrentOwner polyfill (WordPress/gutenberg#78923) - Fix playlist metadata edits recreating player (WordPress/gutenberg#78876) - Media Editor: Fix sidebar overflowing the modal between the small and medium breakpoints (WordPress/gutenberg#78931) - Media: Move client-side media compat file to wordpress-7.1 directory (WordPress/gutenberg#78852) - env: Replace extract-zip with adm-zip to fix hang on Node 24.16 (WordPress/gutenberg#78828) - Media Editor: refactor modal layout (WordPress/gutenberg#78896) - Optimize wp-env source downloads with Git partial clones (WordPress/gutenberg#78918) - Fix: Escape URLs in block render functions using `esc_url()` (WordPress/gutenberg#78912) - Blocks: Allow the Login/out block as an inner block in the Navigation Submenu block (WordPress/gutenberg#75497) - Fix sprintf format specifiers in post-date and read-more blocks (WordPress/gutenberg#78933) - Refactor: Remove jest/test deps from root package.json (WordPress/gutenberg#78801) - Upload Media: Add retry with exponential backoff and network resilience (WordPress/gutenberg#76765) - Build Scripts: Fix Windows path handling in dev script (WordPress/gutenberg#78939) - Revert React 19 upgrade (WordPress/gutenberg#78940) - Fix: block auto-complete for AI API Keys in Connectors (WordPress/gutenberg#78946) - Dashboard: Opinionated grid columns with container breakpoints (WordPress/gutenberg#78732) - Skip including inactive or experimental routes when building for WordPress Core (WordPress/gutenberg#76715) - RTC: Fix Yjs undo manager to update UI state when undo stack changes (WordPress/gutenberg#78864) - Storybook: Enhance Theme Provider example with admin-ui Page. (WordPress/gutenberg#78814) - RTC: Fix CRDT deferred updates resulting in jumbled typing (WordPress/gutenberg#78756) - Add playlist track length setting (WordPress/gutenberg#78954) - Add aspect ratio control to media editor mobile toolbar (WordPress/gutenberg#78935) - Media Editor: Replace the zoom slider with +/- buttons (WordPress/gutenberg#78928) - Use omit-unchanged for compressed-size-action (WordPress/gutenberg#78976) - DataViewsPicker: Add a new `pickerActivity` layout (WordPress/gutenberg#78941) - refactor: move babel dependencies to workspace configuration (WordPress/gutenberg#78974) - feat: Migrate the browserlintrc file to `packages/postcss-plugins-preset` (WordPress/gutenberg#78764) - Storybook: Declare workspace dependencies for theme example story. (WordPress/gutenberg#78979) - Refactor: Move React dependencies from root to workspaces (WordPress/gutenberg#78981) - UI: Update `@base-ui/react` to `1.5.0` (WordPress/gutenberg#78448) - ui/AlertDialog: Fix footer layout style override (WordPress/gutenberg#78953) - Font Library: Fix focus issue when navigating (WordPress/gutenberg#78671) - Docs: Auto-generate per-block API reference pages from block.json (WordPress/gutenberg#77612) - Patterns: fix focus loss when dismissing Create pattern dialog (WordPress/gutenberg#78957) - Show media upload progress in a snackbar (WordPress/gutenberg#77249) - Upload Media: Gate very large images out of client-side processing (WordPress/gutenberg#78949) - Media: Add UltraHDR (ISO 21496-1) gain map support (WordPress/gutenberg#74873) - Site Editor: Apply the user's admin color scheme (WordPress/gutenberg#78397) - Navigation Link: fix duplicate block html attributes in editor (WordPress/gutenberg#78973) - Added Missing Global Documentation (WordPress/gutenberg#78997) - Post Revisions: Upgrade `diff` from v4 to v8 (WordPress/gutenberg#77992) - Theme: Increase stroke1 contrast target to 2.9 (WordPress/gutenberg#77599) - Tooltip: Use md border radius for portaled popups. (WordPress/gutenberg#78983) - Framework: Remove invalid stale nested npm package references (WordPress/gutenberg#79014) - Theme package: Add element size design tokens (WordPress/gutenberg#76545) - Inserter: use forwardRef for refs (WordPress/gutenberg#79006) - RTC: Add separate doc persistence endpoint (WordPress/gutenberg#78891) - DataViews: Add DataViews components to components manifest (WordPress/gutenberg#78960) - Media Editor: Keep crop handles operable on large images (WordPress/gutenberg#79011) - Media editor: tweak paddings and margins (WordPress/gutenberg#79009) - Media Editor: Remove lag when toggling the sidebar (WordPress/gutenberg#79024) - Elements: Align class name parsing with custom CSS implementation (WordPress/gutenberg#79023) - CI: Suppress lint:js warnings on static checks (WordPress/gutenberg#79025) - Remove React Native implementation, framework, and dependencies (WordPress/gutenberg#78747) - e2e-test-utils-playwright: start transpiling again, but faster (WordPress/gutenberg#79026) - CI: Remove Validate Gradle Wrapper workflow (WordPress/gutenberg#79030) - Remove dead native code branches from Platform usages (WordPress/gutenberg#79031) - Remove orphaned README files for deleted native-only components (WordPress/gutenberg#79035) - Remove orphaned mobile bug report issue template (WordPress/gutenberg#79038) - Inserter: Fix error being thrown for spoken message when inserting default/direct block (WordPress/gutenberg#79004) - Editor: Remove dead native guard in block removal warnings (WordPress/gutenberg#79039) - Preserve nested list when deleting a selection across sibling list items (WordPress/gutenberg#78776) - Remove platform-docs Docusaurus site (WordPress/gutenberg#79034) - Align dependency versions across workspaces (WordPress/gutenberg#77954) - RichText: Remove dead native-only prop filtering (WordPress/gutenberg#79037) - Navigable Container: Hoist getFocusableContext out of the component (WordPress/gutenberg#79029) - Tools: Lint dependency version consistency with Syncpack (WordPress/gutenberg#77950) - Extract entity view config into a filterable API (WordPress/gutenberg#78977) - Rich text: use subscribeDelegatedListener for element event listeners (WordPress/gutenberg#79047) - theme/ThemeProvider: rename `color.bg` prop to `color.background` (WordPress/gutenberg#79007) - Format Library: Migrate to recommended `@wordpress/ui` components (WordPress/gutenberg#79059) - Syncpack: ban `classnames` from being reintroduced (WordPress/gutenberg#79061) - UI: Update CSS cascade layers to use nesting (WordPress/gutenberg#78959) - Docs: Remove stale mobile references from tooling and primitives docs (WordPress/gutenberg#79041) - Release: Drop mobile-specific changelog omit rules (WordPress/gutenberg#79042) - Bump actions/checkout (WordPress/gutenberg#79033) - `ColorPalette`: don't render when custom colors disabled and no colors passed (WordPress/gutenberg#72402) - Bump minimatch and lerna (WordPress/gutenberg#76750) - Image block: don't show crop icon while image is uploading (WordPress/gutenberg#79103) - Add React 19 as an experimental flag (WordPress/gutenberg#79077) - Media modal: small tweak to gutters (WordPress/gutenberg#79168) - Add more React internals polyfills (WordPress/gutenberg#79142) - Media editor modal: Fix keyboard resizing for locked aspect-ratio crops (WordPress/gutenberg#79207) - Fix responsive element styles front end output (WordPress/gutenberg#79135) (WordPress/gutenberg#79215) Props adamsilverstein, jorbin, westonruter, wildworks. Fixes #65368. git-svn-id: https://develop.svn.wordpress.org/trunk@62584 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Jun 30, 2026
This updates the pinned commit hash of the Gutenberg repository from `14db4ab9395a9e96430eed678e4288a59eecbd15 ` (version `23.3.0`) to `14db4ab9395a9e96430eed678e4288a59eecbd15` (version `23.4.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v23.3.0..v23.4.0. The following commits are included: - Hide image dimension tools when a state is selected (WordPress/gutenberg#78670) - Changed labels to consistently use Patterns in favor of Block patterns (WordPress/gutenberg#56880) - Fix: Restrict parent page API search to post titles only (WordPress/gutenberg#78683) - Update AGENTS.md to mention additional pitfalls: (WordPress/gutenberg#78718) - Docs: Fix big_image_size_threshold xref typo (WordPress/gutenberg#76299) - Compose: Fully deprecate the 'pure' HoC (WordPress/gutenberg#78674) - Common CSS: avoid false-positive border-style on custom properties (WordPress/gutenberg#77476) - Compose: Fix SSR crash in useMediaQuery and useViewportMatch (WordPress/gutenberg#78725) - CI: Skip plugin repo release when SVN tag already exists (WordPress/gutenberg#78476) - Dashboard: Hello Dolly (WordPress/gutenberg#78648) - UI: `Tooltip.Provider` — forward upstream `closeDelay` and `timeout` props (WordPress/gutenberg#78642) - Compose: Support React 19 ref callback cleanups in `useMergeRefs` (WordPress/gutenberg#78685) - Add copilot-instructions.md file (WordPress/gutenberg#78584) - Dashboard: show ghost widgets visually & allow easy removal (WordPress/gutenberg#78502) - Bump fast-xml-builder from 1.0.0 to 1.2.0 (WordPress/gutenberg#78272) - Bump actions/stale (WordPress/gutenberg#78745) - Bump fast-xml-parser from 4.5.0 to 4.5.6 (WordPress/gutenberg#77167) - Bump actions/github-script from 8.0.0 to 9.0.0 in /.github/workflows (WordPress/gutenberg#78591) - @wordpress/theme: deduplicate addFallbackToVar helper (WordPress/gutenberg#78666) - Add Combobox primitives (WordPress/gutenberg#78399) - Editor: Fix keyboard activation of the template actions preview (WordPress/gutenberg#78641) - Theme: drop `density` support from `@wordpress/theme` (WordPress/gutenberg#78741) - Tooltip migration: fields + media-editor + media-fields + global-styles-ui (4/5) (WordPress/gutenberg#78691) - List View: Expose block visibility label to assistive technology (WordPress/gutenberg#78640) - Hide paragraph Drop cap control when a state is selected (WordPress/gutenberg#78672) - Image cropper: round zoom control values and display as percentages (WordPress/gutenberg#78757) - Media Editor Modal: Try placing the save and cancel buttons in the footer (WordPress/gutenberg#78708) - Unset grid span defaults with viewport states enabled (WordPress/gutenberg#78709) - Media Editor: Remove resize handles toggle from crop panel (WordPress/gutenberg#78758) - Image Editor: focus return after closing image crop modal (WordPress/gutenberg#78711) - Add dashboard Events widget (WordPress/gutenberg#78553) - Writing flow: Delete at end of nested list item should merge into next block (WordPress/gutenberg#78742) - RTC: Re-render collaborators overlay when the block tree changes (WordPress/gutenberg#78636) - Dashboard: rename `widget-types` to `widget-primitives` and consolidate the widget contract (WordPress/gutenberg#78749) - Fix Gutenberg plugin assuming its directory is named "gutenberg" (WordPress/gutenberg#78705) - Codemods: Remove one-shot Tooltip migration codemod (WordPress/gutenberg#78669) - Dashboard: rename `WidgetChrome` to `DashboardWidgetChrome` (WordPress/gutenberg#78751) - Paragraph: Strip stale block-support classes from className during align attribute migration (WordPress/gutenberg#78731) - Global Styles: Fix CSS not applying to Custom CSS textarea in Advanced panel (WordPress/gutenberg#78773) - scripts: Use require.resolve for SVG loaders to fix pnpm compat (WordPress/gutenberg#78777) - Post list: Remove close button from Quick Edit drawer (WordPress/gutenberg#78730) - Revert "Gate client-side media processing as plugin-only (WordPress/gutenberg#76700)" (WordPress/gutenberg#76751) - Tooltip migration: boot consumers + shell-level Tooltip.Provider (5/5) (WordPress/gutenberg#78692) - Dashboard: replace `surface` with `host` in widget contract docs (WordPress/gutenberg#78778) - Shortcode block: Fix editor crash when selecting transform menu (WordPress/gutenberg#78770) - Make `@wordpress/nux` a no-op compatibility package (WordPress/gutenberg#77773) - Tests: Temporarily disable REST index output-format assertions (WordPress/gutenberg#78788) - Hide Cover overlay controls for viewport states (WordPress/gutenberg#78763) - Fix type of `$block_instance` parameter in `block_core_image_render_lightbox()` (WordPress/gutenberg#78790) - TypeScript: Migrate server-side-render package to TS (WordPress/gutenberg#71383) - feat: Migrate performance results to tools release (WordPress/gutenberg#78761) - wp-build: Fix black flash on wp-admin pages before hydration (WordPress/gutenberg#78493) - Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774) - Dashboard: Use Howdy greeting for page title (WordPress/gutenberg#78740) - Block Editor: Refactor Inserter to a function component (WordPress/gutenberg#78766) - Dashboard: Move layout settings to customize toolbar (WordPress/gutenberg#78738) - Build: update changelog (WordPress/gutenberg#78807) - Icons: rename timeToRead to time (WordPress/gutenberg#78804) - RTC: Prevent slower polling filters (WordPress/gutenberg#78811) - Button.Icon: Fix clipped icons (WordPress/gutenberg#78614) - Bump docker/login-action (WordPress/gutenberg#78819) - RTC: Return forbidden rooms together (WordPress/gutenberg#78748) - Update browserslist (WordPress/gutenberg#78840) - Try allowing transforms to a variation of another block (WordPress/gutenberg#78713) - Elements: Guard against non-string className in render filter (WordPress/gutenberg#78841) - e2e-test-utils-playwright: add src to published NPM files (WordPress/gutenberg#78847) - Editor: Refactor 'PostPublishButton' into function component (WordPress/gutenberg#78737) - Dashboard: Promote WidgetRender into widget-primitives (WordPress/gutenberg#78821) - Notes: Show default avatar in the indicator when user avatars are disabled (WordPress/gutenberg#78849) - Revert "Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774)" (WordPress/gutenberg#78854) - Media: Send Document-Isolation-Policy header on the site preview frame (WordPress/gutenberg#78404) - Revert navigation morph & playlist commits pushed directly to trunk (WordPress/gutenberg#78857) - Fix Update button staying active when changes are reverted. (WordPress/gutenberg#78567) - Docs: Fix and improve documentation (WordPress/gutenberg#78686) - Abilities: Add validation tests pinning behavior for WP-specific schema keywords (WordPress/gutenberg#78783) - Tools: migrate docs/tool into tools/docs workspace (WordPress/gutenberg#78870) - Dashboard: Fix Add widget error on non-secure HTTP origins (WordPress/gutenberg#78850) - Docs: Fix @wordpress/data README fragment links (WordPress/gutenberg#78866) - bin: Remove obsolete bin/setup-local-env.sh (WordPress/gutenberg#78871) - Boot navigation: wrap items in a list role for valid listitem semantics (WordPress/gutenberg#78829) - wp-build: Document generated page hooks per WordPress standards. (WordPress/gutenberg#78826) - Update CODEOWNERS for tooling directories (WordPress/gutenberg#78874) - Block Visibility: Keep hide-everywhere working after a block opts out of visibility support (WordPress/gutenberg#78780) - Dashboard: Replace grid row height controls with size presets. (WordPress/gutenberg#78735) - Prevent font-size propagation in Navigation items causing `em` compounding (WordPress/gutenberg#77419) - Media Editor Modal: Reorder details fields so the editable regular layout fields appear at the top (WordPress/gutenberg#78792) - Fix media editor sidebar close button label (WordPress/gutenberg#78895) - Dashboard: event widget iteration (WordPress/gutenberg#78815) - Playlist Block: Add visualization style selector (WordPress/gutenberg#76147) - [Content Types]: Fix extra Page padding causing vertical scrollbar (WordPress/gutenberg#78661) - Remove migrated dependencies from root package.json (WordPress/gutenberg#78813) - Packages: Declare missing `@types/react` dependency (WordPress/gutenberg#78882) - Fix collapsed experiment cards not stretching to full width (WordPress/gutenberg#78910) - Element: add polyfills for render, hydrate, unmountComponentAtNode (WordPress/gutenberg#78899) - Revert "wp-build: Replace getter-based exports with data properties" (WordPress/gutenberg#78917) - React: add ReactCurrentOwner polyfill (WordPress/gutenberg#78923) - Fix playlist metadata edits recreating player (WordPress/gutenberg#78876) - Media Editor: Fix sidebar overflowing the modal between the small and medium breakpoints (WordPress/gutenberg#78931) - Media: Move client-side media compat file to wordpress-7.1 directory (WordPress/gutenberg#78852) - env: Replace extract-zip with adm-zip to fix hang on Node 24.16 (WordPress/gutenberg#78828) - Media Editor: refactor modal layout (WordPress/gutenberg#78896) - Optimize wp-env source downloads with Git partial clones (WordPress/gutenberg#78918) - Fix: Escape URLs in block render functions using `esc_url()` (WordPress/gutenberg#78912) - Blocks: Allow the Login/out block as an inner block in the Navigation Submenu block (WordPress/gutenberg#75497) - Fix sprintf format specifiers in post-date and read-more blocks (WordPress/gutenberg#78933) - Refactor: Remove jest/test deps from root package.json (WordPress/gutenberg#78801) - Upload Media: Add retry with exponential backoff and network resilience (WordPress/gutenberg#76765) - Build Scripts: Fix Windows path handling in dev script (WordPress/gutenberg#78939) - Revert React 19 upgrade (WordPress/gutenberg#78940) - Fix: block auto-complete for AI API Keys in Connectors (WordPress/gutenberg#78946) - Dashboard: Opinionated grid columns with container breakpoints (WordPress/gutenberg#78732) - Skip including inactive or experimental routes when building for WordPress Core (WordPress/gutenberg#76715) - RTC: Fix Yjs undo manager to update UI state when undo stack changes (WordPress/gutenberg#78864) - Storybook: Enhance Theme Provider example with admin-ui Page. (WordPress/gutenberg#78814) - RTC: Fix CRDT deferred updates resulting in jumbled typing (WordPress/gutenberg#78756) - Add playlist track length setting (WordPress/gutenberg#78954) - Add aspect ratio control to media editor mobile toolbar (WordPress/gutenberg#78935) - Media Editor: Replace the zoom slider with +/- buttons (WordPress/gutenberg#78928) - Use omit-unchanged for compressed-size-action (WordPress/gutenberg#78976) - DataViewsPicker: Add a new `pickerActivity` layout (WordPress/gutenberg#78941) - refactor: move babel dependencies to workspace configuration (WordPress/gutenberg#78974) - feat: Migrate the browserlintrc file to `packages/postcss-plugins-preset` (WordPress/gutenberg#78764) - Storybook: Declare workspace dependencies for theme example story. (WordPress/gutenberg#78979) - Refactor: Move React dependencies from root to workspaces (WordPress/gutenberg#78981) - UI: Update `@base-ui/react` to `1.5.0` (WordPress/gutenberg#78448) - ui/AlertDialog: Fix footer layout style override (WordPress/gutenberg#78953) - Font Library: Fix focus issue when navigating (WordPress/gutenberg#78671) - Docs: Auto-generate per-block API reference pages from block.json (WordPress/gutenberg#77612) - Patterns: fix focus loss when dismissing Create pattern dialog (WordPress/gutenberg#78957) - Show media upload progress in a snackbar (WordPress/gutenberg#77249) - Upload Media: Gate very large images out of client-side processing (WordPress/gutenberg#78949) - Media: Add UltraHDR (ISO 21496-1) gain map support (WordPress/gutenberg#74873) - Site Editor: Apply the user's admin color scheme (WordPress/gutenberg#78397) - Navigation Link: fix duplicate block html attributes in editor (WordPress/gutenberg#78973) - Added Missing Global Documentation (WordPress/gutenberg#78997) - Post Revisions: Upgrade `diff` from v4 to v8 (WordPress/gutenberg#77992) - Theme: Increase stroke1 contrast target to 2.9 (WordPress/gutenberg#77599) - Tooltip: Use md border radius for portaled popups. (WordPress/gutenberg#78983) - Framework: Remove invalid stale nested npm package references (WordPress/gutenberg#79014) - Theme package: Add element size design tokens (WordPress/gutenberg#76545) - Inserter: use forwardRef for refs (WordPress/gutenberg#79006) - RTC: Add separate doc persistence endpoint (WordPress/gutenberg#78891) - DataViews: Add DataViews components to components manifest (WordPress/gutenberg#78960) - Media Editor: Keep crop handles operable on large images (WordPress/gutenberg#79011) - Media editor: tweak paddings and margins (WordPress/gutenberg#79009) - Media Editor: Remove lag when toggling the sidebar (WordPress/gutenberg#79024) - Elements: Align class name parsing with custom CSS implementation (WordPress/gutenberg#79023) - CI: Suppress lint:js warnings on static checks (WordPress/gutenberg#79025) - Remove React Native implementation, framework, and dependencies (WordPress/gutenberg#78747) - e2e-test-utils-playwright: start transpiling again, but faster (WordPress/gutenberg#79026) - CI: Remove Validate Gradle Wrapper workflow (WordPress/gutenberg#79030) - Remove dead native code branches from Platform usages (WordPress/gutenberg#79031) - Remove orphaned README files for deleted native-only components (WordPress/gutenberg#79035) - Remove orphaned mobile bug report issue template (WordPress/gutenberg#79038) - Inserter: Fix error being thrown for spoken message when inserting default/direct block (WordPress/gutenberg#79004) - Editor: Remove dead native guard in block removal warnings (WordPress/gutenberg#79039) - Preserve nested list when deleting a selection across sibling list items (WordPress/gutenberg#78776) - Remove platform-docs Docusaurus site (WordPress/gutenberg#79034) - Align dependency versions across workspaces (WordPress/gutenberg#77954) - RichText: Remove dead native-only prop filtering (WordPress/gutenberg#79037) - Navigable Container: Hoist getFocusableContext out of the component (WordPress/gutenberg#79029) - Tools: Lint dependency version consistency with Syncpack (WordPress/gutenberg#77950) - Extract entity view config into a filterable API (WordPress/gutenberg#78977) - Rich text: use subscribeDelegatedListener for element event listeners (WordPress/gutenberg#79047) - theme/ThemeProvider: rename `color.bg` prop to `color.background` (WordPress/gutenberg#79007) - Format Library: Migrate to recommended `@wordpress/ui` components (WordPress/gutenberg#79059) - Syncpack: ban `classnames` from being reintroduced (WordPress/gutenberg#79061) - UI: Update CSS cascade layers to use nesting (WordPress/gutenberg#78959) - Docs: Remove stale mobile references from tooling and primitives docs (WordPress/gutenberg#79041) - Release: Drop mobile-specific changelog omit rules (WordPress/gutenberg#79042) - Bump actions/checkout (WordPress/gutenberg#79033) - `ColorPalette`: don't render when custom colors disabled and no colors passed (WordPress/gutenberg#72402) - Bump minimatch and lerna (WordPress/gutenberg#76750) - Image block: don't show crop icon while image is uploading (WordPress/gutenberg#79103) - Add React 19 as an experimental flag (WordPress/gutenberg#79077) - Media modal: small tweak to gutters (WordPress/gutenberg#79168) - Add more React internals polyfills (WordPress/gutenberg#79142) - Media editor modal: Fix keyboard resizing for locked aspect-ratio crops (WordPress/gutenberg#79207) - Fix responsive element styles front end output (WordPress/gutenberg#79135) (WordPress/gutenberg#79215) Props adamsilverstein, jorbin, westonruter, wildworks. Fixes #65368. Built from https://develop.svn.wordpress.org/trunk@62584 git-svn-id: http://core.svn.wordpress.org/trunk@61864 1a063a9b-81f0-0310-95a4-ce76da25c4cd
KhushalSainS
pushed a commit
to KhushalSainS/wordpress-develop
that referenced
this pull request
Jul 1, 2026
This updates the pinned commit hash of the Gutenberg repository from `14db4ab9395a9e96430eed678e4288a59eecbd15 ` (version `23.3.0`) to `14db4ab9395a9e96430eed678e4288a59eecbd15` (version `23.4.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v23.3.0..v23.4.0. The following commits are included: - Hide image dimension tools when a state is selected (WordPress/gutenberg#78670) - Changed labels to consistently use Patterns in favor of Block patterns (WordPress/gutenberg#56880) - Fix: Restrict parent page API search to post titles only (WordPress/gutenberg#78683) - Update AGENTS.md to mention additional pitfalls: (WordPress/gutenberg#78718) - Docs: Fix big_image_size_threshold xref typo (WordPress/gutenberg#76299) - Compose: Fully deprecate the 'pure' HoC (WordPress/gutenberg#78674) - Common CSS: avoid false-positive border-style on custom properties (WordPress/gutenberg#77476) - Compose: Fix SSR crash in useMediaQuery and useViewportMatch (WordPress/gutenberg#78725) - CI: Skip plugin repo release when SVN tag already exists (WordPress/gutenberg#78476) - Dashboard: Hello Dolly (WordPress/gutenberg#78648) - UI: `Tooltip.Provider` — forward upstream `closeDelay` and `timeout` props (WordPress/gutenberg#78642) - Compose: Support React 19 ref callback cleanups in `useMergeRefs` (WordPress/gutenberg#78685) - Add copilot-instructions.md file (WordPress/gutenberg#78584) - Dashboard: show ghost widgets visually & allow easy removal (WordPress/gutenberg#78502) - Bump fast-xml-builder from 1.0.0 to 1.2.0 (WordPress/gutenberg#78272) - Bump actions/stale (WordPress/gutenberg#78745) - Bump fast-xml-parser from 4.5.0 to 4.5.6 (WordPress/gutenberg#77167) - Bump actions/github-script from 8.0.0 to 9.0.0 in /.github/workflows (WordPress/gutenberg#78591) - @wordpress/theme: deduplicate addFallbackToVar helper (WordPress/gutenberg#78666) - Add Combobox primitives (WordPress/gutenberg#78399) - Editor: Fix keyboard activation of the template actions preview (WordPress/gutenberg#78641) - Theme: drop `density` support from `@wordpress/theme` (WordPress/gutenberg#78741) - Tooltip migration: fields + media-editor + media-fields + global-styles-ui (4/5) (WordPress/gutenberg#78691) - List View: Expose block visibility label to assistive technology (WordPress/gutenberg#78640) - Hide paragraph Drop cap control when a state is selected (WordPress/gutenberg#78672) - Image cropper: round zoom control values and display as percentages (WordPress/gutenberg#78757) - Media Editor Modal: Try placing the save and cancel buttons in the footer (WordPress/gutenberg#78708) - Unset grid span defaults with viewport states enabled (WordPress/gutenberg#78709) - Media Editor: Remove resize handles toggle from crop panel (WordPress/gutenberg#78758) - Image Editor: focus return after closing image crop modal (WordPress/gutenberg#78711) - Add dashboard Events widget (WordPress/gutenberg#78553) - Writing flow: Delete at end of nested list item should merge into next block (WordPress/gutenberg#78742) - RTC: Re-render collaborators overlay when the block tree changes (WordPress/gutenberg#78636) - Dashboard: rename `widget-types` to `widget-primitives` and consolidate the widget contract (WordPress/gutenberg#78749) - Fix Gutenberg plugin assuming its directory is named "gutenberg" (WordPress/gutenberg#78705) - Codemods: Remove one-shot Tooltip migration codemod (WordPress/gutenberg#78669) - Dashboard: rename `WidgetChrome` to `DashboardWidgetChrome` (WordPress/gutenberg#78751) - Paragraph: Strip stale block-support classes from className during align attribute migration (WordPress/gutenberg#78731) - Global Styles: Fix CSS not applying to Custom CSS textarea in Advanced panel (WordPress/gutenberg#78773) - scripts: Use require.resolve for SVG loaders to fix pnpm compat (WordPress/gutenberg#78777) - Post list: Remove close button from Quick Edit drawer (WordPress/gutenberg#78730) - Revert "Gate client-side media processing as plugin-only (WordPress/gutenberg#76700)" (WordPress/gutenberg#76751) - Tooltip migration: boot consumers + shell-level Tooltip.Provider (5/5) (WordPress/gutenberg#78692) - Dashboard: replace `surface` with `host` in widget contract docs (WordPress/gutenberg#78778) - Shortcode block: Fix editor crash when selecting transform menu (WordPress/gutenberg#78770) - Make `@wordpress/nux` a no-op compatibility package (WordPress/gutenberg#77773) - Tests: Temporarily disable REST index output-format assertions (WordPress/gutenberg#78788) - Hide Cover overlay controls for viewport states (WordPress/gutenberg#78763) - Fix type of `$block_instance` parameter in `block_core_image_render_lightbox()` (WordPress/gutenberg#78790) - TypeScript: Migrate server-side-render package to TS (WordPress/gutenberg#71383) - feat: Migrate performance results to tools release (WordPress/gutenberg#78761) - wp-build: Fix black flash on wp-admin pages before hydration (WordPress/gutenberg#78493) - Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774) - Dashboard: Use Howdy greeting for page title (WordPress/gutenberg#78740) - Block Editor: Refactor Inserter to a function component (WordPress/gutenberg#78766) - Dashboard: Move layout settings to customize toolbar (WordPress/gutenberg#78738) - Build: update changelog (WordPress/gutenberg#78807) - Icons: rename timeToRead to time (WordPress/gutenberg#78804) - RTC: Prevent slower polling filters (WordPress/gutenberg#78811) - Button.Icon: Fix clipped icons (WordPress/gutenberg#78614) - Bump docker/login-action (WordPress/gutenberg#78819) - RTC: Return forbidden rooms together (WordPress/gutenberg#78748) - Update browserslist (WordPress/gutenberg#78840) - Try allowing transforms to a variation of another block (WordPress/gutenberg#78713) - Elements: Guard against non-string className in render filter (WordPress/gutenberg#78841) - e2e-test-utils-playwright: add src to published NPM files (WordPress/gutenberg#78847) - Editor: Refactor 'PostPublishButton' into function component (WordPress/gutenberg#78737) - Dashboard: Promote WidgetRender into widget-primitives (WordPress/gutenberg#78821) - Notes: Show default avatar in the indicator when user avatars are disabled (WordPress/gutenberg#78849) - Revert "Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774)" (WordPress/gutenberg#78854) - Media: Send Document-Isolation-Policy header on the site preview frame (WordPress/gutenberg#78404) - Revert navigation morph & playlist commits pushed directly to trunk (WordPress/gutenberg#78857) - Fix Update button staying active when changes are reverted. (WordPress/gutenberg#78567) - Docs: Fix and improve documentation (WordPress/gutenberg#78686) - Abilities: Add validation tests pinning behavior for WP-specific schema keywords (WordPress/gutenberg#78783) - Tools: migrate docs/tool into tools/docs workspace (WordPress/gutenberg#78870) - Dashboard: Fix Add widget error on non-secure HTTP origins (WordPress/gutenberg#78850) - Docs: Fix @wordpress/data README fragment links (WordPress/gutenberg#78866) - bin: Remove obsolete bin/setup-local-env.sh (WordPress/gutenberg#78871) - Boot navigation: wrap items in a list role for valid listitem semantics (WordPress/gutenberg#78829) - wp-build: Document generated page hooks per WordPress standards. (WordPress/gutenberg#78826) - Update CODEOWNERS for tooling directories (WordPress/gutenberg#78874) - Block Visibility: Keep hide-everywhere working after a block opts out of visibility support (WordPress/gutenberg#78780) - Dashboard: Replace grid row height controls with size presets. (WordPress/gutenberg#78735) - Prevent font-size propagation in Navigation items causing `em` compounding (WordPress/gutenberg#77419) - Media Editor Modal: Reorder details fields so the editable regular layout fields appear at the top (WordPress/gutenberg#78792) - Fix media editor sidebar close button label (WordPress/gutenberg#78895) - Dashboard: event widget iteration (WordPress/gutenberg#78815) - Playlist Block: Add visualization style selector (WordPress/gutenberg#76147) - [Content Types]: Fix extra Page padding causing vertical scrollbar (WordPress/gutenberg#78661) - Remove migrated dependencies from root package.json (WordPress/gutenberg#78813) - Packages: Declare missing `@types/react` dependency (WordPress/gutenberg#78882) - Fix collapsed experiment cards not stretching to full width (WordPress/gutenberg#78910) - Element: add polyfills for render, hydrate, unmountComponentAtNode (WordPress/gutenberg#78899) - Revert "wp-build: Replace getter-based exports with data properties" (WordPress/gutenberg#78917) - React: add ReactCurrentOwner polyfill (WordPress/gutenberg#78923) - Fix playlist metadata edits recreating player (WordPress/gutenberg#78876) - Media Editor: Fix sidebar overflowing the modal between the small and medium breakpoints (WordPress/gutenberg#78931) - Media: Move client-side media compat file to wordpress-7.1 directory (WordPress/gutenberg#78852) - env: Replace extract-zip with adm-zip to fix hang on Node 24.16 (WordPress/gutenberg#78828) - Media Editor: refactor modal layout (WordPress/gutenberg#78896) - Optimize wp-env source downloads with Git partial clones (WordPress/gutenberg#78918) - Fix: Escape URLs in block render functions using `esc_url()` (WordPress/gutenberg#78912) - Blocks: Allow the Login/out block as an inner block in the Navigation Submenu block (WordPress/gutenberg#75497) - Fix sprintf format specifiers in post-date and read-more blocks (WordPress/gutenberg#78933) - Refactor: Remove jest/test deps from root package.json (WordPress/gutenberg#78801) - Upload Media: Add retry with exponential backoff and network resilience (WordPress/gutenberg#76765) - Build Scripts: Fix Windows path handling in dev script (WordPress/gutenberg#78939) - Revert React 19 upgrade (WordPress/gutenberg#78940) - Fix: block auto-complete for AI API Keys in Connectors (WordPress/gutenberg#78946) - Dashboard: Opinionated grid columns with container breakpoints (WordPress/gutenberg#78732) - Skip including inactive or experimental routes when building for WordPress Core (WordPress/gutenberg#76715) - RTC: Fix Yjs undo manager to update UI state when undo stack changes (WordPress/gutenberg#78864) - Storybook: Enhance Theme Provider example with admin-ui Page. (WordPress/gutenberg#78814) - RTC: Fix CRDT deferred updates resulting in jumbled typing (WordPress/gutenberg#78756) - Add playlist track length setting (WordPress/gutenberg#78954) - Add aspect ratio control to media editor mobile toolbar (WordPress/gutenberg#78935) - Media Editor: Replace the zoom slider with +/- buttons (WordPress/gutenberg#78928) - Use omit-unchanged for compressed-size-action (WordPress/gutenberg#78976) - DataViewsPicker: Add a new `pickerActivity` layout (WordPress/gutenberg#78941) - refactor: move babel dependencies to workspace configuration (WordPress/gutenberg#78974) - feat: Migrate the browserlintrc file to `packages/postcss-plugins-preset` (WordPress/gutenberg#78764) - Storybook: Declare workspace dependencies for theme example story. (WordPress/gutenberg#78979) - Refactor: Move React dependencies from root to workspaces (WordPress/gutenberg#78981) - UI: Update `@base-ui/react` to `1.5.0` (WordPress/gutenberg#78448) - ui/AlertDialog: Fix footer layout style override (WordPress/gutenberg#78953) - Font Library: Fix focus issue when navigating (WordPress/gutenberg#78671) - Docs: Auto-generate per-block API reference pages from block.json (WordPress/gutenberg#77612) - Patterns: fix focus loss when dismissing Create pattern dialog (WordPress/gutenberg#78957) - Show media upload progress in a snackbar (WordPress/gutenberg#77249) - Upload Media: Gate very large images out of client-side processing (WordPress/gutenberg#78949) - Media: Add UltraHDR (ISO 21496-1) gain map support (WordPress/gutenberg#74873) - Site Editor: Apply the user's admin color scheme (WordPress/gutenberg#78397) - Navigation Link: fix duplicate block html attributes in editor (WordPress/gutenberg#78973) - Added Missing Global Documentation (WordPress/gutenberg#78997) - Post Revisions: Upgrade `diff` from v4 to v8 (WordPress/gutenberg#77992) - Theme: Increase stroke1 contrast target to 2.9 (WordPress/gutenberg#77599) - Tooltip: Use md border radius for portaled popups. (WordPress/gutenberg#78983) - Framework: Remove invalid stale nested npm package references (WordPress/gutenberg#79014) - Theme package: Add element size design tokens (WordPress/gutenberg#76545) - Inserter: use forwardRef for refs (WordPress/gutenberg#79006) - RTC: Add separate doc persistence endpoint (WordPress/gutenberg#78891) - DataViews: Add DataViews components to components manifest (WordPress/gutenberg#78960) - Media Editor: Keep crop handles operable on large images (WordPress/gutenberg#79011) - Media editor: tweak paddings and margins (WordPress/gutenberg#79009) - Media Editor: Remove lag when toggling the sidebar (WordPress/gutenberg#79024) - Elements: Align class name parsing with custom CSS implementation (WordPress/gutenberg#79023) - CI: Suppress lint:js warnings on static checks (WordPress/gutenberg#79025) - Remove React Native implementation, framework, and dependencies (WordPress/gutenberg#78747) - e2e-test-utils-playwright: start transpiling again, but faster (WordPress/gutenberg#79026) - CI: Remove Validate Gradle Wrapper workflow (WordPress/gutenberg#79030) - Remove dead native code branches from Platform usages (WordPress/gutenberg#79031) - Remove orphaned README files for deleted native-only components (WordPress/gutenberg#79035) - Remove orphaned mobile bug report issue template (WordPress/gutenberg#79038) - Inserter: Fix error being thrown for spoken message when inserting default/direct block (WordPress/gutenberg#79004) - Editor: Remove dead native guard in block removal warnings (WordPress/gutenberg#79039) - Preserve nested list when deleting a selection across sibling list items (WordPress/gutenberg#78776) - Remove platform-docs Docusaurus site (WordPress/gutenberg#79034) - Align dependency versions across workspaces (WordPress/gutenberg#77954) - RichText: Remove dead native-only prop filtering (WordPress/gutenberg#79037) - Navigable Container: Hoist getFocusableContext out of the component (WordPress/gutenberg#79029) - Tools: Lint dependency version consistency with Syncpack (WordPress/gutenberg#77950) - Extract entity view config into a filterable API (WordPress/gutenberg#78977) - Rich text: use subscribeDelegatedListener for element event listeners (WordPress/gutenberg#79047) - theme/ThemeProvider: rename `color.bg` prop to `color.background` (WordPress/gutenberg#79007) - Format Library: Migrate to recommended `@wordpress/ui` components (WordPress/gutenberg#79059) - Syncpack: ban `classnames` from being reintroduced (WordPress/gutenberg#79061) - UI: Update CSS cascade layers to use nesting (WordPress/gutenberg#78959) - Docs: Remove stale mobile references from tooling and primitives docs (WordPress/gutenberg#79041) - Release: Drop mobile-specific changelog omit rules (WordPress/gutenberg#79042) - Bump actions/checkout (WordPress/gutenberg#79033) - `ColorPalette`: don't render when custom colors disabled and no colors passed (WordPress/gutenberg#72402) - Bump minimatch and lerna (WordPress/gutenberg#76750) - Image block: don't show crop icon while image is uploading (WordPress/gutenberg#79103) - Add React 19 as an experimental flag (WordPress/gutenberg#79077) - Media modal: small tweak to gutters (WordPress/gutenberg#79168) - Add more React internals polyfills (WordPress/gutenberg#79142) - Media editor modal: Fix keyboard resizing for locked aspect-ratio crops (WordPress/gutenberg#79207) - Fix responsive element styles front end output (WordPress/gutenberg#79135) (WordPress/gutenberg#79215) Props adamsilverstein, jorbin, westonruter, wildworks. Fixes #65368. git-svn-id: https://develop.svn.wordpress.org/trunk@62584 602fd350-edb4-49c9-b593-d223f7449a82
SteelWagstaff
pushed a commit
to SteelWagstaff/wordpress-develop
that referenced
this pull request
Jul 2, 2026
This updates the pinned commit hash of the Gutenberg repository from `14db4ab9395a9e96430eed678e4288a59eecbd15 ` (version `23.3.0`) to `14db4ab9395a9e96430eed678e4288a59eecbd15` (version `23.4.0`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v23.3.0..v23.4.0. The following commits are included: - Hide image dimension tools when a state is selected (WordPress/gutenberg#78670) - Changed labels to consistently use Patterns in favor of Block patterns (WordPress/gutenberg#56880) - Fix: Restrict parent page API search to post titles only (WordPress/gutenberg#78683) - Update AGENTS.md to mention additional pitfalls: (WordPress/gutenberg#78718) - Docs: Fix big_image_size_threshold xref typo (WordPress/gutenberg#76299) - Compose: Fully deprecate the 'pure' HoC (WordPress/gutenberg#78674) - Common CSS: avoid false-positive border-style on custom properties (WordPress/gutenberg#77476) - Compose: Fix SSR crash in useMediaQuery and useViewportMatch (WordPress/gutenberg#78725) - CI: Skip plugin repo release when SVN tag already exists (WordPress/gutenberg#78476) - Dashboard: Hello Dolly (WordPress/gutenberg#78648) - UI: `Tooltip.Provider` — forward upstream `closeDelay` and `timeout` props (WordPress/gutenberg#78642) - Compose: Support React 19 ref callback cleanups in `useMergeRefs` (WordPress/gutenberg#78685) - Add copilot-instructions.md file (WordPress/gutenberg#78584) - Dashboard: show ghost widgets visually & allow easy removal (WordPress/gutenberg#78502) - Bump fast-xml-builder from 1.0.0 to 1.2.0 (WordPress/gutenberg#78272) - Bump actions/stale (WordPress/gutenberg#78745) - Bump fast-xml-parser from 4.5.0 to 4.5.6 (WordPress/gutenberg#77167) - Bump actions/github-script from 8.0.0 to 9.0.0 in /.github/workflows (WordPress/gutenberg#78591) - @wordpress/theme: deduplicate addFallbackToVar helper (WordPress/gutenberg#78666) - Add Combobox primitives (WordPress/gutenberg#78399) - Editor: Fix keyboard activation of the template actions preview (WordPress/gutenberg#78641) - Theme: drop `density` support from `@wordpress/theme` (WordPress/gutenberg#78741) - Tooltip migration: fields + media-editor + media-fields + global-styles-ui (4/5) (WordPress/gutenberg#78691) - List View: Expose block visibility label to assistive technology (WordPress/gutenberg#78640) - Hide paragraph Drop cap control when a state is selected (WordPress/gutenberg#78672) - Image cropper: round zoom control values and display as percentages (WordPress/gutenberg#78757) - Media Editor Modal: Try placing the save and cancel buttons in the footer (WordPress/gutenberg#78708) - Unset grid span defaults with viewport states enabled (WordPress/gutenberg#78709) - Media Editor: Remove resize handles toggle from crop panel (WordPress/gutenberg#78758) - Image Editor: focus return after closing image crop modal (WordPress/gutenberg#78711) - Add dashboard Events widget (WordPress/gutenberg#78553) - Writing flow: Delete at end of nested list item should merge into next block (WordPress/gutenberg#78742) - RTC: Re-render collaborators overlay when the block tree changes (WordPress/gutenberg#78636) - Dashboard: rename `widget-types` to `widget-primitives` and consolidate the widget contract (WordPress/gutenberg#78749) - Fix Gutenberg plugin assuming its directory is named "gutenberg" (WordPress/gutenberg#78705) - Codemods: Remove one-shot Tooltip migration codemod (WordPress/gutenberg#78669) - Dashboard: rename `WidgetChrome` to `DashboardWidgetChrome` (WordPress/gutenberg#78751) - Paragraph: Strip stale block-support classes from className during align attribute migration (WordPress/gutenberg#78731) - Global Styles: Fix CSS not applying to Custom CSS textarea in Advanced panel (WordPress/gutenberg#78773) - scripts: Use require.resolve for SVG loaders to fix pnpm compat (WordPress/gutenberg#78777) - Post list: Remove close button from Quick Edit drawer (WordPress/gutenberg#78730) - Revert "Gate client-side media processing as plugin-only (WordPress/gutenberg#76700)" (WordPress/gutenberg#76751) - Tooltip migration: boot consumers + shell-level Tooltip.Provider (5/5) (WordPress/gutenberg#78692) - Dashboard: replace `surface` with `host` in widget contract docs (WordPress/gutenberg#78778) - Shortcode block: Fix editor crash when selecting transform menu (WordPress/gutenberg#78770) - Make `@wordpress/nux` a no-op compatibility package (WordPress/gutenberg#77773) - Tests: Temporarily disable REST index output-format assertions (WordPress/gutenberg#78788) - Hide Cover overlay controls for viewport states (WordPress/gutenberg#78763) - Fix type of `$block_instance` parameter in `block_core_image_render_lightbox()` (WordPress/gutenberg#78790) - TypeScript: Migrate server-side-render package to TS (WordPress/gutenberg#71383) - feat: Migrate performance results to tools release (WordPress/gutenberg#78761) - wp-build: Fix black flash on wp-admin pages before hydration (WordPress/gutenberg#78493) - Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774) - Dashboard: Use Howdy greeting for page title (WordPress/gutenberg#78740) - Block Editor: Refactor Inserter to a function component (WordPress/gutenberg#78766) - Dashboard: Move layout settings to customize toolbar (WordPress/gutenberg#78738) - Build: update changelog (WordPress/gutenberg#78807) - Icons: rename timeToRead to time (WordPress/gutenberg#78804) - RTC: Prevent slower polling filters (WordPress/gutenberg#78811) - Button.Icon: Fix clipped icons (WordPress/gutenberg#78614) - Bump docker/login-action (WordPress/gutenberg#78819) - RTC: Return forbidden rooms together (WordPress/gutenberg#78748) - Update browserslist (WordPress/gutenberg#78840) - Try allowing transforms to a variation of another block (WordPress/gutenberg#78713) - Elements: Guard against non-string className in render filter (WordPress/gutenberg#78841) - e2e-test-utils-playwright: add src to published NPM files (WordPress/gutenberg#78847) - Editor: Refactor 'PostPublishButton' into function component (WordPress/gutenberg#78737) - Dashboard: Promote WidgetRender into widget-primitives (WordPress/gutenberg#78821) - Notes: Show default avatar in the indicator when user avatars are disabled (WordPress/gutenberg#78849) - Revert "Icons: maintain absolute stroke-width regardless of icon-size (WordPress/gutenberg#78774)" (WordPress/gutenberg#78854) - Media: Send Document-Isolation-Policy header on the site preview frame (WordPress/gutenberg#78404) - Revert navigation morph & playlist commits pushed directly to trunk (WordPress/gutenberg#78857) - Fix Update button staying active when changes are reverted. (WordPress/gutenberg#78567) - Docs: Fix and improve documentation (WordPress/gutenberg#78686) - Abilities: Add validation tests pinning behavior for WP-specific schema keywords (WordPress/gutenberg#78783) - Tools: migrate docs/tool into tools/docs workspace (WordPress/gutenberg#78870) - Dashboard: Fix Add widget error on non-secure HTTP origins (WordPress/gutenberg#78850) - Docs: Fix @wordpress/data README fragment links (WordPress/gutenberg#78866) - bin: Remove obsolete bin/setup-local-env.sh (WordPress/gutenberg#78871) - Boot navigation: wrap items in a list role for valid listitem semantics (WordPress/gutenberg#78829) - wp-build: Document generated page hooks per WordPress standards. (WordPress/gutenberg#78826) - Update CODEOWNERS for tooling directories (WordPress/gutenberg#78874) - Block Visibility: Keep hide-everywhere working after a block opts out of visibility support (WordPress/gutenberg#78780) - Dashboard: Replace grid row height controls with size presets. (WordPress/gutenberg#78735) - Prevent font-size propagation in Navigation items causing `em` compounding (WordPress/gutenberg#77419) - Media Editor Modal: Reorder details fields so the editable regular layout fields appear at the top (WordPress/gutenberg#78792) - Fix media editor sidebar close button label (WordPress/gutenberg#78895) - Dashboard: event widget iteration (WordPress/gutenberg#78815) - Playlist Block: Add visualization style selector (WordPress/gutenberg#76147) - [Content Types]: Fix extra Page padding causing vertical scrollbar (WordPress/gutenberg#78661) - Remove migrated dependencies from root package.json (WordPress/gutenberg#78813) - Packages: Declare missing `@types/react` dependency (WordPress/gutenberg#78882) - Fix collapsed experiment cards not stretching to full width (WordPress/gutenberg#78910) - Element: add polyfills for render, hydrate, unmountComponentAtNode (WordPress/gutenberg#78899) - Revert "wp-build: Replace getter-based exports with data properties" (WordPress/gutenberg#78917) - React: add ReactCurrentOwner polyfill (WordPress/gutenberg#78923) - Fix playlist metadata edits recreating player (WordPress/gutenberg#78876) - Media Editor: Fix sidebar overflowing the modal between the small and medium breakpoints (WordPress/gutenberg#78931) - Media: Move client-side media compat file to wordpress-7.1 directory (WordPress/gutenberg#78852) - env: Replace extract-zip with adm-zip to fix hang on Node 24.16 (WordPress/gutenberg#78828) - Media Editor: refactor modal layout (WordPress/gutenberg#78896) - Optimize wp-env source downloads with Git partial clones (WordPress/gutenberg#78918) - Fix: Escape URLs in block render functions using `esc_url()` (WordPress/gutenberg#78912) - Blocks: Allow the Login/out block as an inner block in the Navigation Submenu block (WordPress/gutenberg#75497) - Fix sprintf format specifiers in post-date and read-more blocks (WordPress/gutenberg#78933) - Refactor: Remove jest/test deps from root package.json (WordPress/gutenberg#78801) - Upload Media: Add retry with exponential backoff and network resilience (WordPress/gutenberg#76765) - Build Scripts: Fix Windows path handling in dev script (WordPress/gutenberg#78939) - Revert React 19 upgrade (WordPress/gutenberg#78940) - Fix: block auto-complete for AI API Keys in Connectors (WordPress/gutenberg#78946) - Dashboard: Opinionated grid columns with container breakpoints (WordPress/gutenberg#78732) - Skip including inactive or experimental routes when building for WordPress Core (WordPress/gutenberg#76715) - RTC: Fix Yjs undo manager to update UI state when undo stack changes (WordPress/gutenberg#78864) - Storybook: Enhance Theme Provider example with admin-ui Page. (WordPress/gutenberg#78814) - RTC: Fix CRDT deferred updates resulting in jumbled typing (WordPress/gutenberg#78756) - Add playlist track length setting (WordPress/gutenberg#78954) - Add aspect ratio control to media editor mobile toolbar (WordPress/gutenberg#78935) - Media Editor: Replace the zoom slider with +/- buttons (WordPress/gutenberg#78928) - Use omit-unchanged for compressed-size-action (WordPress/gutenberg#78976) - DataViewsPicker: Add a new `pickerActivity` layout (WordPress/gutenberg#78941) - refactor: move babel dependencies to workspace configuration (WordPress/gutenberg#78974) - feat: Migrate the browserlintrc file to `packages/postcss-plugins-preset` (WordPress/gutenberg#78764) - Storybook: Declare workspace dependencies for theme example story. (WordPress/gutenberg#78979) - Refactor: Move React dependencies from root to workspaces (WordPress/gutenberg#78981) - UI: Update `@base-ui/react` to `1.5.0` (WordPress/gutenberg#78448) - ui/AlertDialog: Fix footer layout style override (WordPress/gutenberg#78953) - Font Library: Fix focus issue when navigating (WordPress/gutenberg#78671) - Docs: Auto-generate per-block API reference pages from block.json (WordPress/gutenberg#77612) - Patterns: fix focus loss when dismissing Create pattern dialog (WordPress/gutenberg#78957) - Show media upload progress in a snackbar (WordPress/gutenberg#77249) - Upload Media: Gate very large images out of client-side processing (WordPress/gutenberg#78949) - Media: Add UltraHDR (ISO 21496-1) gain map support (WordPress/gutenberg#74873) - Site Editor: Apply the user's admin color scheme (WordPress/gutenberg#78397) - Navigation Link: fix duplicate block html attributes in editor (WordPress/gutenberg#78973) - Added Missing Global Documentation (WordPress/gutenberg#78997) - Post Revisions: Upgrade `diff` from v4 to v8 (WordPress/gutenberg#77992) - Theme: Increase stroke1 contrast target to 2.9 (WordPress/gutenberg#77599) - Tooltip: Use md border radius for portaled popups. (WordPress/gutenberg#78983) - Framework: Remove invalid stale nested npm package references (WordPress/gutenberg#79014) - Theme package: Add element size design tokens (WordPress/gutenberg#76545) - Inserter: use forwardRef for refs (WordPress/gutenberg#79006) - RTC: Add separate doc persistence endpoint (WordPress/gutenberg#78891) - DataViews: Add DataViews components to components manifest (WordPress/gutenberg#78960) - Media Editor: Keep crop handles operable on large images (WordPress/gutenberg#79011) - Media editor: tweak paddings and margins (WordPress/gutenberg#79009) - Media Editor: Remove lag when toggling the sidebar (WordPress/gutenberg#79024) - Elements: Align class name parsing with custom CSS implementation (WordPress/gutenberg#79023) - CI: Suppress lint:js warnings on static checks (WordPress/gutenberg#79025) - Remove React Native implementation, framework, and dependencies (WordPress/gutenberg#78747) - e2e-test-utils-playwright: start transpiling again, but faster (WordPress/gutenberg#79026) - CI: Remove Validate Gradle Wrapper workflow (WordPress/gutenberg#79030) - Remove dead native code branches from Platform usages (WordPress/gutenberg#79031) - Remove orphaned README files for deleted native-only components (WordPress/gutenberg#79035) - Remove orphaned mobile bug report issue template (WordPress/gutenberg#79038) - Inserter: Fix error being thrown for spoken message when inserting default/direct block (WordPress/gutenberg#79004) - Editor: Remove dead native guard in block removal warnings (WordPress/gutenberg#79039) - Preserve nested list when deleting a selection across sibling list items (WordPress/gutenberg#78776) - Remove platform-docs Docusaurus site (WordPress/gutenberg#79034) - Align dependency versions across workspaces (WordPress/gutenberg#77954) - RichText: Remove dead native-only prop filtering (WordPress/gutenberg#79037) - Navigable Container: Hoist getFocusableContext out of the component (WordPress/gutenberg#79029) - Tools: Lint dependency version consistency with Syncpack (WordPress/gutenberg#77950) - Extract entity view config into a filterable API (WordPress/gutenberg#78977) - Rich text: use subscribeDelegatedListener for element event listeners (WordPress/gutenberg#79047) - theme/ThemeProvider: rename `color.bg` prop to `color.background` (WordPress/gutenberg#79007) - Format Library: Migrate to recommended `@wordpress/ui` components (WordPress/gutenberg#79059) - Syncpack: ban `classnames` from being reintroduced (WordPress/gutenberg#79061) - UI: Update CSS cascade layers to use nesting (WordPress/gutenberg#78959) - Docs: Remove stale mobile references from tooling and primitives docs (WordPress/gutenberg#79041) - Release: Drop mobile-specific changelog omit rules (WordPress/gutenberg#79042) - Bump actions/checkout (WordPress/gutenberg#79033) - `ColorPalette`: don't render when custom colors disabled and no colors passed (WordPress/gutenberg#72402) - Bump minimatch and lerna (WordPress/gutenberg#76750) - Image block: don't show crop icon while image is uploading (WordPress/gutenberg#79103) - Add React 19 as an experimental flag (WordPress/gutenberg#79077) - Media modal: small tweak to gutters (WordPress/gutenberg#79168) - Add more React internals polyfills (WordPress/gutenberg#79142) - Media editor modal: Fix keyboard resizing for locked aspect-ratio crops (WordPress/gutenberg#79207) - Fix responsive element styles front end output (WordPress/gutenberg#79135) (WordPress/gutenberg#79215) Props adamsilverstein, jorbin, westonruter, wildworks. Fixes #65368. git-svn-id: https://develop.svn.wordpress.org/trunk@62584 602fd350-edb4-49c9-b593-d223f7449a82
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a human-written PR description. Two main changes:
Add
onUndoStackChange()callback to sync manager handlers so that Yjs undo stack operations necessarily communicate with the core-data store and update editor UI when Yjs adds an undo item or changes the undo stack. This was added in 7985ed0, which caused theinner-blocks-templates.spec.jstest to fail correctly below in https://github.com/WordPress/gutenberg/actions/runs/26774227868/job/78921451086.Add a flag to
__unstableMarkNextChangeAsNotPersistent()to indicate whether history should be merged with a prior undo stack item (history = 'merge') or should be completely ignored (history = 'ignore').Typically
__unstableMarkNextChangeAsNotPersistent()calls are proceeded by anonChange()call, and the flag is used to mark "merge the next operation into the existing undo stack". However inuseInnerBlockTemplateSync()the non-persistent call is NOT paired with an existing change. On a fresh page load, which happens in the test, there is no prior undo item to roll changes into, and so the Yjs undo manager creates a fresh undo for the entity change anyway.Change
hasUndo()/hasRedo()in core-data to react to sync undo manager updates.Why?
This change is necessary to merge another PR which changes CRDT timing in #78756. The change in CRDT timing caused the
inner-blocks-templates.spec.jstest to fail for legitimate reasons related to a now-visible dirty undo stack and uncovered the original bug discussion.How?
See this original called shot from @youknowriad in https://github.com/WordPress/gutenberg/pull/72407/changes#r2580214235:
In short, when the Yjs undo manager adds a new item to the stack, it doesn't notify the UI that something has changed so it can re-render the undo/redo UI toolbar actions. We relied on the fact that typically other things are also changing in core data, so UI state will probably get updated anyway. This seemed to work okay, but a timing change in an unrelated PR #78756 uncovered this problem again and caused the
inner-blocks-templates.spec.jstest to fail.Previously the
inner-blocks-templates.spec.jstest was passing because of the deferred CRDT update, so even though Yjs is incorrectly adding an undo level from an async template addition, it wasn't registered in the UI because the Yjs UndoManager stack add operation fires after the UI finishes rendering. So an undo is still available (incorrectly), but it wasn't reflected in the UI which is what the test checks for.The second
__unstableMarkNextChangeAsNotPersistent()allows Yjs to understand when an item should be merged with a prior stack item (the typical case) or should always be ignored (the inner template sync case). Nearly all existing calls are implicitlyhistory = 'merge', with the exception of async template loading. The Yjs undo manager doesn't have the concept of a "staged" but not-yet-committed undo item like the built-in manager, and this gives us enough context to know if a cached edit should be committed to storage.Testing Instructions
The main failure and fix can be verified in CI:
inner-blocks-templates.spec.jstest to correctly start failing in https://github.com/WordPress/gutenberg/actions/runs/26774227868/job/78921451086.historyflag to__unstableMarkNextChangeAsNotPersistent()which Yjs can use to drop async template edits in undo history (a065a76, tests in 0069b18).inner-blocks-templates.spec.jsand all other tests now succeed.Use of AI Tools
AI assistance: Yes
Tool(s): Codex + Claude Code
Used for: Drilling deep into the problem, writing a fix