Improve error message for `which(fn, types)` by apaz-cli · Pull Request #47369 · JuliaLang/julia

apaz-cli · 2022-10-28T15:16:11Z

Error messages for MethodError are much more helpful in determining why the method was not successfully dispatched than simply "No unique matching method found."

Fixes #47322

vtjnash · 2022-10-28T21:58:17Z

Marking for triage, for discussion of whether MethodError is appropriate here. Since it is not true in the strict since of the runtime error, but it is an error that seems to be essentially what #47322 requested, and it does get the fancy printing that was desired there. Unless what was desired was just a very minimal mention of whether it had an ambiguity (which might just involve some plumbing to have the ambig boolean computed by ml_matches be included in the error message here)

JeffBezanson · 2022-11-10T20:55:42Z

Suggestion from triage: stringify the MethodError to wrap it in an ErrorException that adds some text like "call would result in the following method error:".

StefanKarpinski · 2022-11-12T14:12:00Z

Wouldn't it make more sense to wrap the actual method error and then display it correctly?

apaz-cli · 2022-11-15T15:03:42Z

Test for #47559 yoinked from #47566, thanks @Seelengrab ❤️ 🙂

apaz-cli · 2022-11-17T16:38:38Z

After CI runs, there should still be one failing test, which is part of SparseArrays. I've submitted a PR above, and mentioned this PR in it.

We should also run pkgeval to try to find anything else that this breaks.

Also, is this sort of change to MethodError something that we should triage? If we don't want to change how MethodError prints, a062067 is a complete implementation that passes tests.

maleadt · 2022-11-17T19:24:54Z

@nanosoldier runtests(ALL, vs = ":master")

nanosoldier · 2022-11-18T11:36:08Z

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

maleadt · 2022-11-18T11:39:21Z

Quite some errors because master is 1.10 and this branch 1.9 (JuliaCI/Nanosoldier.jl#131).

KristofferC · 2022-11-18T11:39:37Z

Looking at the logs this is running on a quite old Julia commit. Running on merge commit with PkgEval would be nice :P

vtjnash · 2022-11-18T12:24:15Z

Those are a Pkg bug and not just a branch difference though, right? Eg https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/e9ab711_vs_5f0da83/Casacore.primary.log

maleadt · 2022-11-18T16:25:54Z

Rebased. This is also a good PR to test some new PkgEval features, so sorry for the noise (I'll delete those comments afterwards):

@nanosoldier runtests(["AnyMOD", "Casacore", "ClimaTimeSteppers", "CxxWrap", "DickeModel", "FMIFlux", "HomalgProject", "MParT", "Oscar", "Polymake", "QML", "QSimulator", "RangeEnclosures", "SDPA", "Singular", "StaticTools", "TuringGLM", "Z3", "openPMD", "ADI", "AIBECS", "AffineInvariantMCMC", "AlgebraicMultigrid", "ArrayLayouts", "AstroIC", "AstroIO", "AtomGraphs", "AvailablePotentialEnergyFramework", "BIGUQ", "BM3DDenoise", "Baytes", "BetaML", "Bio3DView", "BlobTracking", "BlockDecomposition", "BlockTriangularForm", "Boltz", "BrokenRecord", "CDLmotif", "CSDP", "CairoMakie", "CartesianJoin", "Catlab", "Causal", "CausalInference", "CellSegmentation", "ChainPlots", "ChaoticEncryption", "CineFiles", "CitableImage", "ClimateERA", "ClimateModels", "CollisionDetection", "ColorTypes", "CorrelationFunctions", "CorrelationTrackers", "CumulantsFeatures", "CumulantsUpdates", "DINCAE", "DLMReader", "DSP", "DataAssimilationBenchmarks", "DeconvOptim", "DifferentiableCollisions", "DifferentiableTrajectoryOptimization", "Discord", "Dojo", "DojoEnvironments", "DrelTools", "DrillMudsThermalProps", "EFTfitter", "EasyABM", "EditorsRepo", "EulerCharacteristic", "EvoDynamics", "ExplainableAI", "ExtremeLearning", "FHIRClientXML", "FMI", "FaceDetection", "FastMakie", "FastRunningMedian", "FastVision", "FatDatasets", "FeedbackNets", "FileIO", "FlowAtlas", "FlowWorkspace", "FourierFlows", "FourierGPE", "FunctionTabulations", "GAP", "GCMAES", "GEMPIC", "GMT", "Gaugefields", "GaussianMixtureRegressions", "GaussianMixtures", "GeneralizedSylvesterSolver", "GeophysicalFlows", "GraphDataFrameBridge", "Graphene", "GreenFunc", "GridapGmsh", "HypertextLiteral", "ImageUtils", "ImagineFormat", "InMemoryDatasets", "IndependentComponentAnalysis", "IndividualDisplacements", "InteractiveDynamics", "InventoryManagement", "IsotopeTableDF", "IterativeLQR", "IterativeRefinement", "JLD2", "JavisNB", "JobSchedulers", "Juice", "JunctionTrees", "Jutul", "JutulDarcy", "Knet", "KnetLayers", "KnetNLPModels", "KomaMRI", "KroneckerTools", "LIBSVM", "LabelledGraphs", "LatticeDiracOperators", "LatticeQCD", "LazyAlgebra", "Leaflet", "Lehmann", "LightOSM", "LinearInterpolators", "MCMCDebugging", "MPIMapReduce", "MPIReco", "MPITestImages", "MRICoilSensitivities", "MRIFiles", "MRIReco", "MRISimulation", "MRIsim", "MagmaThermoKinematics", "ManifestUtilities", "MaterialReconstruction", "MatrixMerge", "MendelImpute", "MetaGraphs", "MetaGraphsNext", "Mitosis", "MolecularGraphKernels", "MonolithicFEMVLFS", "MultiScaleTreeGraph", "MultilayerGraphs", "MultiscaleGraphSignalTransforms", "MutualInformationImageRegistration", "NbodyGradient", "NeidArchive", "NeutronTransport", "NewsLookout", "NighttimeLights", "Nonconvex", "Nullables", "ODEHybrid", "OSMMakie", "OSQP", "OVERT", "Observers", "OceanStateEstimation", "Oceanostics", "PDENLPModels", "POMDPStressTesting", "PSSFSS", "ParameterEstimocean", "Parsers", "PassiveTracerFlows", "Peridynamics", "PharmaceuticalClassification", "Photodynamics", "PlanktonIndividuals", "PlantBiophysics", "PlantGeom", "PlutoStaticHTML", "PointEstimateMethod", "PoreMatMod", "PorousMaterials", "PowerAnalytics", "PowerModelsAnalytics", "PowerSystemsMaps", "ProbabilisticCircuits", "Probably", "PubChemCrawler", "QXContexts", "QXTools", "QXZoo", "RandomMatrices", "RandomMatrixDistributions", "RankRevealing", "RayTracing", "RecoverPose", "RegularizationTools", "Reproduce", "ReusableFunctions", "RiskAdjustedLinearizations", "RoMEPlotting", "RobustPmap", "SMLMData", "SMLMFrameConnection", "SMLMSim", "SUNRepresentations", "Seleroute", "SimpleSolvers", "SmoothingSplines", "SnowyOwl", "SocialSamplingTheory", "SolverBenchmark", "SpecTools", "SpeedyWeather", "SpinGlassNetworks", "SpinGlassPEPS", "StableTrees", "StatisticalGraphics", "TcpInstruments", "TeneT", "TensorBoardLogger", "TensorGames", "TensorKitManifolds", "UnifiedPseudopotentialFormat", "UserConfig", "VisualGeometryDatasets", "WGPUgfx", "WhereTraits", "YaoQX"])

nanosoldier · 2022-11-18T17:54:57Z

Your job failed. cc @maleadt

maleadt · 2022-11-18T18:10:49Z

@nanosoldier runtests(["AnyMOD", "Casacore", "ClimaTimeSteppers", "CxxWrap", "DickeModel", "FMIFlux", "HomalgProject", "MParT", "Oscar", "Polymake", "QML", "QSimulator", "RangeEnclosures", "SDPA", "Singular", "StaticTools", "TuringGLM", "Z3", "openPMD", "ADI", "AIBECS", "AffineInvariantMCMC", "AlgebraicMultigrid", "ArrayLayouts", "AstroIC", "AstroIO", "AtomGraphs", "AvailablePotentialEnergyFramework", "BIGUQ", "BM3DDenoise", "Baytes", "BetaML", "Bio3DView", "BlobTracking", "BlockDecomposition", "BlockTriangularForm", "Boltz", "BrokenRecord", "CDLmotif", "CSDP", "CairoMakie", "CartesianJoin", "Catlab", "Causal", "CausalInference", "CellSegmentation", "ChainPlots", "ChaoticEncryption", "CineFiles", "CitableImage", "ClimateERA", "ClimateModels", "CollisionDetection", "ColorTypes", "CorrelationFunctions", "CorrelationTrackers", "CumulantsFeatures", "CumulantsUpdates", "DINCAE", "DLMReader", "DSP", "DataAssimilationBenchmarks", "DeconvOptim", "DifferentiableCollisions", "DifferentiableTrajectoryOptimization", "Discord", "Dojo", "DojoEnvironments", "DrelTools", "DrillMudsThermalProps", "EFTfitter", "EasyABM", "EditorsRepo", "EulerCharacteristic", "EvoDynamics", "ExplainableAI", "ExtremeLearning", "FHIRClientXML", "FMI", "FaceDetection", "FastMakie", "FastRunningMedian", "FastVision", "FatDatasets", "FeedbackNets", "FileIO", "FlowAtlas", "FlowWorkspace", "FourierFlows", "FourierGPE", "FunctionTabulations", "GAP", "GCMAES", "GEMPIC", "GMT", "Gaugefields", "GaussianMixtureRegressions", "GaussianMixtures", "GeneralizedSylvesterSolver", "GeophysicalFlows", "GraphDataFrameBridge", "Graphene", "GreenFunc", "GridapGmsh", "HypertextLiteral", "ImageUtils", "ImagineFormat", "InMemoryDatasets", "IndependentComponentAnalysis", "IndividualDisplacements", "InteractiveDynamics", "InventoryManagement", "IsotopeTableDF", "IterativeLQR", "IterativeRefinement", "JLD2", "JavisNB", "JobSchedulers", "Juice", "JunctionTrees", "Jutul", "JutulDarcy", "Knet", "KnetLayers", "KnetNLPModels", "KomaMRI", "KroneckerTools", "LIBSVM", "LabelledGraphs", "LatticeDiracOperators", "LatticeQCD", "LazyAlgebra", "Leaflet", "Lehmann", "LightOSM", "LinearInterpolators", "MCMCDebugging", "MPIMapReduce", "MPIReco", "MPITestImages", "MRICoilSensitivities", "MRIFiles", "MRIReco", "MRISimulation", "MRIsim", "MagmaThermoKinematics", "ManifestUtilities", "MaterialReconstruction", "MatrixMerge", "MendelImpute", "MetaGraphs", "MetaGraphsNext", "Mitosis", "MolecularGraphKernels", "MonolithicFEMVLFS", "MultiScaleTreeGraph", "MultilayerGraphs", "MultiscaleGraphSignalTransforms", "MutualInformationImageRegistration", "NbodyGradient", "NeidArchive", "NeutronTransport", "NewsLookout", "NighttimeLights", "Nonconvex", "Nullables", "ODEHybrid", "OSMMakie", "OSQP", "OVERT", "Observers", "OceanStateEstimation", "Oceanostics", "PDENLPModels", "POMDPStressTesting", "PSSFSS", "ParameterEstimocean", "Parsers", "PassiveTracerFlows", "Peridynamics", "PharmaceuticalClassification", "Photodynamics", "PlanktonIndividuals", "PlantBiophysics", "PlantGeom", "PlutoStaticHTML", "PointEstimateMethod", "PoreMatMod", "PorousMaterials", "PowerAnalytics", "PowerModelsAnalytics", "PowerSystemsMaps", "ProbabilisticCircuits", "Probably", "PubChemCrawler", "QXContexts", "QXTools", "QXZoo", "RandomMatrices", "RandomMatrixDistributions", "RankRevealing", "RayTracing", "RecoverPose", "RegularizationTools", "Reproduce", "ReusableFunctions", "RiskAdjustedLinearizations", "RoMEPlotting", "RobustPmap", "SMLMData", "SMLMFrameConnection", "SMLMSim", "SUNRepresentations", "Seleroute", "SimpleSolvers", "SmoothingSplines", "SnowyOwl", "SocialSamplingTheory", "SolverBenchmark", "SpecTools", "SpeedyWeather", "SpinGlassNetworks", "SpinGlassPEPS", "StableTrees", "StatisticalGraphics", "TcpInstruments", "TeneT", "TensorBoardLogger", "TensorGames", "TensorKitManifolds", "UnifiedPseudopotentialFormat", "UserConfig", "VisualGeometryDatasets", "WGPUgfx", "WhereTraits", "YaoQX"])

KristofferC · 2022-11-18T18:20:21Z

Those are a Pkg bug and not just a branch difference though, right?

My point is that the bug is fixed on master Julia but not on this branch.

nanosoldier · 2022-11-18T19:48:47Z

Your job failed. cc @maleadt

maleadt · 2022-11-18T19:51:58Z

@nanosoldier runtests(["AnyMOD", "Casacore", "ClimaTimeSteppers", "CxxWrap", "DickeModel", "FMIFlux", "HomalgProject", "MParT", "Oscar", "Polymake", "QML", "QSimulator", "RangeEnclosures", "SDPA", "Singular", "StaticTools", "TuringGLM", "Z3", "openPMD", "ADI", "AIBECS", "AffineInvariantMCMC", "AlgebraicMultigrid", "ArrayLayouts", "AstroIC", "AstroIO", "AtomGraphs", "AvailablePotentialEnergyFramework", "BIGUQ", "BM3DDenoise", "Baytes", "BetaML", "Bio3DView", "BlobTracking", "BlockDecomposition", "BlockTriangularForm", "Boltz", "BrokenRecord", "CDLmotif", "CSDP", "CairoMakie", "CartesianJoin", "Catlab", "Causal", "CausalInference", "CellSegmentation", "ChainPlots", "ChaoticEncryption", "CineFiles", "CitableImage", "ClimateERA", "ClimateModels", "CollisionDetection", "ColorTypes", "CorrelationFunctions", "CorrelationTrackers", "CumulantsFeatures", "CumulantsUpdates", "DINCAE", "DLMReader", "DSP", "DataAssimilationBenchmarks", "DeconvOptim", "DifferentiableCollisions", "DifferentiableTrajectoryOptimization", "Discord", "Dojo", "DojoEnvironments", "DrelTools", "DrillMudsThermalProps", "EFTfitter", "EasyABM", "EditorsRepo", "EulerCharacteristic", "EvoDynamics", "ExplainableAI", "ExtremeLearning", "FHIRClientXML", "FMI", "FaceDetection", "FastMakie", "FastRunningMedian", "FastVision", "FatDatasets", "FeedbackNets", "FileIO", "FlowAtlas", "FlowWorkspace", "FourierFlows", "FourierGPE", "FunctionTabulations", "GAP", "GCMAES", "GEMPIC", "GMT", "Gaugefields", "GaussianMixtureRegressions", "GaussianMixtures", "GeneralizedSylvesterSolver", "GeophysicalFlows", "GraphDataFrameBridge", "Graphene", "GreenFunc", "GridapGmsh", "HypertextLiteral", "ImageUtils", "ImagineFormat", "InMemoryDatasets", "IndependentComponentAnalysis", "IndividualDisplacements", "InteractiveDynamics", "InventoryManagement", "IsotopeTableDF", "IterativeLQR", "IterativeRefinement", "JLD2", "JavisNB", "JobSchedulers", "Juice", "JunctionTrees", "Jutul", "JutulDarcy", "Knet", "KnetLayers", "KnetNLPModels", "KomaMRI", "KroneckerTools", "LIBSVM", "LabelledGraphs", "LatticeDiracOperators", "LatticeQCD", "LazyAlgebra", "Leaflet", "Lehmann", "LightOSM", "LinearInterpolators", "MCMCDebugging", "MPIMapReduce", "MPIReco", "MPITestImages", "MRICoilSensitivities", "MRIFiles", "MRIReco", "MRISimulation", "MRIsim", "MagmaThermoKinematics", "ManifestUtilities", "MaterialReconstruction", "MatrixMerge", "MendelImpute", "MetaGraphs", "MetaGraphsNext", "Mitosis", "MolecularGraphKernels", "MonolithicFEMVLFS", "MultiScaleTreeGraph", "MultilayerGraphs", "MultiscaleGraphSignalTransforms", "MutualInformationImageRegistration", "NbodyGradient", "NeidArchive", "NeutronTransport", "NewsLookout", "NighttimeLights", "Nonconvex", "Nullables", "ODEHybrid", "OSMMakie", "OSQP", "OVERT", "Observers", "OceanStateEstimation", "Oceanostics", "PDENLPModels", "POMDPStressTesting", "PSSFSS", "ParameterEstimocean", "Parsers", "PassiveTracerFlows", "Peridynamics", "PharmaceuticalClassification", "Photodynamics", "PlanktonIndividuals", "PlantBiophysics", "PlantGeom", "PlutoStaticHTML", "PointEstimateMethod", "PoreMatMod", "PorousMaterials", "PowerAnalytics", "PowerModelsAnalytics", "PowerSystemsMaps", "ProbabilisticCircuits", "Probably", "PubChemCrawler", "QXContexts", "QXTools", "QXZoo", "RandomMatrices", "RandomMatrixDistributions", "RankRevealing", "RayTracing", "RecoverPose", "RegularizationTools", "Reproduce", "ReusableFunctions", "RiskAdjustedLinearizations", "RoMEPlotting", "RobustPmap", "SMLMData", "SMLMFrameConnection", "SMLMSim", "SUNRepresentations", "Seleroute", "SimpleSolvers", "SmoothingSplines", "SnowyOwl", "SocialSamplingTheory", "SolverBenchmark", "SpecTools", "SpeedyWeather", "SpinGlassNetworks", "SpinGlassPEPS", "StableTrees", "StatisticalGraphics", "TcpInstruments", "TeneT", "TensorBoardLogger", "TensorGames", "TensorKitManifolds", "UnifiedPseudopotentialFormat", "UserConfig", "VisualGeometryDatasets", "WGPUgfx", "WhereTraits", "YaoQX"])

nanosoldier · 2022-11-18T21:28:56Z

Your package evaluation job has completed - possible new issues were detected. A full report can be found here.

apaz-cli · 2022-11-22T17:28:10Z

PackageEval reveals that there are many packages with tests relying on parsing MethodError.
ColorTypes, FileIO, HypertextLiteral, and SparseArrays. I already submitted a PR to fix SparseArrays. I'm willing to submit more for the others if you think that's a good idea.

Apply these changes if JuliaLang/julia#47369 gets merged. The error message for MethodError currently applies to both calls to functions and `invoke()`, but did not specify which the error came from. Fixing this will break some tests, hence this PR.

The text of the MethodError message is not a stable API, so use the currently stable API of checking the field value. Discussion at JuliaLang/julia#47369. Co-authored-by: Jameson Nash <vtjnash@gmail.com>

ViralBShah · 2024-01-09T05:19:22Z

Do we want to update this and get it merged?

vtjnash · 2024-01-29T19:12:08Z

@ViralBShah yes, pushed an update with removing some changes and adding others. Just waiting for final review (of the exact text, not the implementation), if you want to look at it?

The `MethodError` printing has detailed text on what failed about this dispatch, which can be useful to someone trying to understand why `which` failed, given that `which` is simply a model of the dispatch done by `invoke`. Reuse that printing, but add a short custom header to it and convert to an ErrorException, per triage discussion that this would be clearest. Also add more text to `MethodError` to guide new users in interpreting the exact meaning of some of the cryptic text. Fixes JuliaLang#47322

inkydragon · 2024-02-03T01:09:41Z

CI: tests passed, ASAN timeout is unrelated.

apaz-cli force-pushed the ap/which branch from 3992e13 to aee41e1 Compare October 28, 2022 18:08

vtjnash added the triage This should be discussed on a triage call label Oct 28, 2022

JeffBezanson removed the triage This should be discussed on a triage call label Nov 10, 2022

apaz-cli force-pushed the ap/which branch 2 times, most recently from 6141895 to 9551f58 Compare November 12, 2022 00:03

vtjnash reviewed Nov 12, 2022

View reviewed changes

Comment thread base/reflection.jl Outdated

brenhinkeller added the error messages Better, more actionable error messages label Nov 17, 2022

apaz-cli mentioned this pull request Nov 17, 2022

Fix "no method matching" test JuliaSparse/SparseArrays.jl#288

Merged

JuliaLang deleted a comment from apaz-cli Nov 17, 2022

maleadt mentioned this pull request Nov 18, 2022

Compare against the merge-base if no vs is specified JuliaCI/Nanosoldier.jl#134

Merged

maleadt force-pushed the ap/which branch from e9ab711 to 924f790 Compare November 18, 2022 16:24

This was referenced Nov 23, 2022

Preemptively fix tests that are about to break JuliaGraphics/ColorTypes.jl#286

Closed

Preemptively fix tests that are about to break JuliaIO/FileIO.jl#366

Closed

Preemptively fix tests that are about to break JuliaPluto/HypertextLiteral.jl#32

Open

StefanKarpinski added the triage This should be discussed on a triage call label Jan 10, 2024

vtjnash force-pushed the ap/which branch from 924f790 to 7fbca2d Compare January 29, 2024 19:09

vtjnash added merge me PR is reviewed. Merge when all tests are passing and removed triage This should be discussed on a triage call labels Feb 1, 2024

vtjnash force-pushed the ap/which branch from 41a4692 to 81a159b Compare February 1, 2024 22:26

vtjnash merged commit fc06291 into JuliaLang:master Feb 3, 2024

inkydragon removed the merge me PR is reviewed. Merge when all tests are passing label Feb 3, 2024

vtjnash mentioned this pull request Feb 6, 2024

issue showing certain invoke MethodErrors with UnionAll #47559

Closed

LilithHafner mentioned this pull request Mar 3, 2024

MethodError hint offers no useful information in common case #53575

Closed

Uh oh!

Uh oh!

Conversation

apaz-cli commented Oct 28, 2022

Uh oh!

vtjnash commented Oct 28, 2022

Uh oh!

JeffBezanson commented Nov 10, 2022

Uh oh!

Uh oh!

StefanKarpinski commented Nov 12, 2022

Uh oh!

apaz-cli commented Nov 15, 2022

Uh oh!

apaz-cli commented Nov 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maleadt commented Nov 17, 2022

Uh oh!

nanosoldier commented Nov 18, 2022

Uh oh!

maleadt commented Nov 18, 2022

Uh oh!

KristofferC commented Nov 18, 2022

Uh oh!

vtjnash commented Nov 18, 2022

Uh oh!

maleadt commented Nov 18, 2022

Uh oh!

nanosoldier commented Nov 18, 2022

Uh oh!

maleadt commented Nov 18, 2022

Uh oh!

KristofferC commented Nov 18, 2022

Uh oh!

nanosoldier commented Nov 18, 2022

Uh oh!

maleadt commented Nov 18, 2022

Uh oh!

nanosoldier commented Nov 18, 2022

Uh oh!

apaz-cli commented Nov 22, 2022

Uh oh!

ViralBShah commented Jan 9, 2024

Uh oh!

vtjnash commented Jan 29, 2024

Uh oh!

inkydragon commented Feb 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

apaz-cli commented Nov 17, 2022 •

edited

Loading