Fix "no method matching" test#288
Merged
Merged
Conversation
Merge after the change to JuliaLang/julia@44367ce
vtjnash
reviewed
Nov 22, 2022
Codecov Report
@@ Coverage Diff @@
## main #288 +/- ##
==========================================
+ Coverage 93.76% 93.78% +0.01%
==========================================
Files 12 12
Lines 7334 7335 +1
==========================================
+ Hits 6877 6879 +2
+ Misses 457 456 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
@vtjnash is this good to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we're thinking about changing the
MethodErrormessage. Unfortunately, this breaks a lot of tests, including this one. Discussion at JuliaLang/julia#47369.If the change below does happen, merge this PR afterwards.JuliaLang/julia@44367ce