Preemptively fix tests that are about to break#366
Closed
apaz-cli wants to merge 3 commits into
Closed
Conversation
Apply these changes if JuliaLang/julia#47369 gets merged. The error message for MethodError currently applies to both calls to functions and `invoke()`, but did not specify which the error came from. Fixing this will break some tests, hence this PR.
Member
|
@apaz-cli Would you have the cycles to help update the tests here? Happy to give you commit access to these repos. |
Member
|
Tests are working with #398 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply these changes if JuliaLang/julia#47369 gets merged.
The error message for MethodError currently applies to both calls to functions and
invoke(), but did not specify which the error came from. Fixing this will break some tests, hence this PR.