Keep the display awake during archive operations - #17
Merged
Conversation
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.1.9-wakelock.1Why
Long-running mobile archive operations can allow the display to sleep. Restore and selective sync have the same requirement as backup, so all archive-operation entry points share one manager. Nested Fetch and Restore leases share the underlying platform wake lock.
While adding Restore coverage, the real-Obsidian E2E exposed that
Extractor.finalise()did not wait for its asynchronous file callbacks. Consequently,extract()could resolve, and its wake-lock lease could be released, before Vault writes had completed. The Extractor now tracks selected files, waits for their callbacks, and propagates write failures.The Screen Wake Lock API remains best effort. Unsupported or rejected requests do not prevent the operation from running, and this change does not provide background execution. Confirmation dialogues do not hold a lease.
Validation
npm cideno task test— 67 passeddeno task test:coverage—src/wakeLock.tsat 100% branch, function, and line coveragenpm run test:ui— 11 passednpm run lintnpm run prettyChecknpm run check:e2e:obsidiannpm run buildoctagonal-wheels@0.1.51: clean install, unit/UI/build checks, and local real-Obsidian E2E passedmanifest.json,package.json, andpackage-lock.jsonagree on0.1.9-wakelock.10.1.9-wakelock.1release checklist item passedThe existing unrelated Svelte
initialItemsbuild warning remains unchanged.Before merge
0.1.9-wakelock.1tag, Draft Release, release notes, and release assets0.1.9-wakelock.1as a prerelease without replacinglatest0.1.9-wakelock.1through BRAT and complete the mobile reviewoctagonal-wheels@0.1.51