Move OPENSSL_ENABLE_SHA1_SIGNATURES=1 to the test in question - #1515
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
w666
force-pushed
the
feature-disable-sha-1
branch
from
August 2, 2026 00:05
721387c to
22fcfcc
Compare
Collaborator
Contributor
Author
w666
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@w666
feature-disable-sha-1OPENSSL_ENABLE_SHA1_SIGNATURES=1into thesha1test in questionThis now passes on my system properly with vanilla
npm run testandnpm run cover.Notice the the base branch for merge is yours
feature-disable-sha-1and not inmasteras it's based off #1418. Once merged, it will help to finalize #1418 and its underlying issue completely. So merge this first into #1418, and then merge that intomaster.