Skip to content

Move OPENSSL_ENABLE_SHA1_SIGNATURES=1 to the test in question - #1515

Merged
w666 merged 4 commits into
vpulim:feature-disable-sha-1from
smokhov:feature-disable-sha-1
Aug 4, 2026
Merged

Move OPENSSL_ENABLE_SHA1_SIGNATURES=1 to the test in question#1515
w666 merged 4 commits into
vpulim:feature-disable-sha-1from
smokhov:feature-disable-sha-1

Conversation

@smokhov

@smokhov smokhov commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

@w666

  • I've sync'ed master with feature-disable-sha-1
  • Moved setting OPENSSL_ENABLE_SHA1_SIGNATURES=1 into the sha1 test in question

This now passes on my system properly with vanilla npm run test and npm run cover.

Notice the the base branch for merge is yours feature-disable-sha-1 and not in master as it's based off #1418. Once merged, it will help to finalize #1418 and its underlying issue completely. So merge this first into #1418, and then merge that into master.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 37bd5fa1-cf05-4767-b136-1556256bf2eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@w666
w666 force-pushed the feature-disable-sha-1 branch from 721387c to 22fcfcc Compare August 2, 2026 00:05
@w666

w666 commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

@smokhov I rebased #1418

@smokhov

smokhov commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

@smokhov I rebased #1418

Ty. Conflict fixed, ready to merge.

@w666
w666 merged commit 9215920 into vpulim:feature-disable-sha-1 Aug 4, 2026
4 checks passed
w666 added a commit that referenced this pull request Aug 4, 2026
…#1418)

* Move OPENSSL_ENABLE_SHA1_SIGNATURES=1 to the test (#1515)

---------

Co-authored-by: Vasily Martynov <vasily.martynov@orbitwellington.com>
Co-authored-by: Serguei Mokhov <mokhov@cse.concordia.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants