Skip to content

Remove OPENSSL_ENABLE_SHA1_SIGNATURES=1 as it is not required anymore - #1418

Merged
w666 merged 2 commits into
masterfrom
feature-disable-sha-1
Aug 4, 2026
Merged

Remove OPENSSL_ENABLE_SHA1_SIGNATURES=1 as it is not required anymore#1418
w666 merged 2 commits into
masterfrom
feature-disable-sha-1

Conversation

@w666

@w666 w666 commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

Close #1323

@w666
w666 force-pushed the feature-disable-sha-1 branch from adf3892 to 721387c Compare January 1, 2026 23:06
@smokhov

smokhov commented Jan 1, 2026

Copy link
Copy Markdown
Contributor

JFOI: it (the SSL test) still breaks without it on AlmaLinux 9, but I can workaround it by setting the var myself before running npm cover

@w666

w666 commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator Author

Ah, okay. It is fine with me to keep it.

I just investigated a bit and ubuntu 24 has this disabled as well and github actions has been migrated to ubuntu 24, so I assumed it should work in other distros too.

@smokhov

smokhov commented Jan 1, 2026

Copy link
Copy Markdown
Contributor

Ah, okay. It is fine with me to keep it.

I just investigated a bit and ubuntu 24 has this disabled as well and github actions has been migrated to ubuntu 24, so I assumed it should work in other distros too.

I think it's still OK to proceed with the removal as you indicated.

@w666
w666 force-pushed the feature-disable-sha-1 branch from 721387c to 22fcfcc Compare August 2, 2026 00:05
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f18a7dac-8cc3-4af5-8a98-7b106d65a245

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

---------

Co-authored-by: Vasily Martynov <vasily.martynov@orbitwellington.com>
@w666
w666 merged commit ebf5f12 into master Aug 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

investigate the need of OPENSSL_ENABLE_SHA1_SIGNATURES=1 in npm cover and npm test

3 participants