Node.js streams: Add forkpoint for prerenderToStream#92513
Merged
timneutkens merged 8 commits intocanaryfrom Apr 15, 2026
Merged
Node.js streams: Add forkpoint for prerenderToStream#92513timneutkens merged 8 commits intocanaryfrom
timneutkens merged 8 commits intocanaryfrom
Conversation
nextjs-bot
added
created-by: Turbopack team
This was referenced Apr 8, 2026
Contributor
Author
Contributor
Tests Passed |
Contributor
Stats from current PR🔴 1 regression
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (8 files)Files with changes:
View diffsapp-page-exp..ntime.dev.jsfailed to diffapp-page-exp..time.prod.jsfailed to diffapp-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsfailed to diffapp-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsDiff too large to display app-page.runtime.dev.jsfailed to diffapp-page.runtime.prod.jsDiff too large to display 📎 Tarball URL |
timneutkens
force-pushed
the
04-08-node.js_streams_add_forkpoint_for_renderwithrestartoncachemissinvalidation
branch
from
abc0342 to
77ee514
Compare
timneutkens
force-pushed
the
04-08-node.js_streams_add_forkpoint_for_prerendertostream
branch
from
ae5cd39 to
0f9ec8b
Compare
timneutkens
force-pushed
the
04-08-node.js_streams_add_forkpoint_for_renderwithrestartoncachemissinvalidation
branch
from
77ee514 to
7b7d028
Compare
timneutkens
force-pushed
the
04-08-node.js_streams_add_forkpoint_for_prerendertostream
branch
from
0f9ec8b to
08cebfa
Compare
timneutkens
force-pushed
the
04-08-node.js_streams_add_forkpoint_for_renderwithrestartoncachemissinvalidation
branch
from
7b7d028 to
eda1ad8
Compare
timneutkens
force-pushed
the
04-08-node.js_streams_add_forkpoint_for_prerendertostream
branch
from
08cebfa to
69f96e5
Compare
gnoff
approved these changes
Apr 14, 2026
Base automatically changed from
04-08-node.js_streams_add_forkpoint_for_renderwithrestartoncachemissinvalidation
to
canary
April 15, 2026 13:11
timneutkens
deleted the
04-08-node.js_streams_add_forkpoint_for_prerendertostream
branch
mmastrac
added a commit
that referenced
this pull request
Apr 15, 2026
The prerenderToStream legacy path was passing { waitForAllReady: true }
to renderFizzStream, which was added in #92513. With Node.js streams
enabled, renderToNodeFizzStream defers pipeable.pipe() to onAllReady,
but the pipeable was already being piped by an earlier callback, causing
React to throw "only supports piping to one writable stream".
The web stream path ignores this option (it's a no-op), which is why
the bug only manifests with __NEXT_USE_NODE_STREAMS=true.
Remove { waitForAllReady: true } from both the main and error Fizz
render calls in prerenderToStream. The prerender path already handles
stream completion separately.
Fixes production builds failing on /_not-found when the root layout
wraps children in <Suspense>.
4 tasks
timneutkens
added a commit
that referenced
this pull request
Apr 15, 2026
This reverts commit 3f66e1b.
timneutkens
added a commit
that referenced
this pull request
Apr 15, 2026
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Building on top of the changes in #92252. This PR implements similar fork points for prerenderToStream