Node.js streams: Add forkpoint for continueDynamicHTMLResume#92471
Merged
timneutkens merged 1 commit intocanaryfrom Apr 14, 2026
Merged
Conversation
nextjs-bot
added
created-by: Turbopack team
This was referenced Apr 7, 2026
Contributor
Author
timneutkens
changed the title
Contributor
Stats from current PR🔴 1 regression
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (8 files)Files with changes:
View diffsapp-page-exp..ntime.dev.jsfailed to diffapp-page-exp..time.prod.jsDiff too large to display app-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsDiff too large to display app-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsDiff too large to display app-page.runtime.dev.jsfailed to diffapp-page.runtime.prod.jsDiff too large to display 📎 Tarball URL |
timneutkens
force-pushed
the
04-07-node.js_streams_add_forkpoint_for_error_recovery
branch
from
d599e66 to
d3e5c9d
Compare
timneutkens
force-pushed
the
04-07-node.js_streams_add_forkpoint_for_continuedynamichtmlresumenode
branch
from
a5a1b5c to
a788070
Compare
This was referenced Apr 8, 2026
timneutkens
force-pushed
the
04-07-node.js_streams_add_forkpoint_for_continuedynamichtmlresumenode
branch
from
a788070 to
cf802b2
Compare
timneutkens
force-pushed
the
04-07-node.js_streams_add_forkpoint_for_error_recovery
branch
from
d3e5c9d to
4d88d2f
Compare
timneutkens
force-pushed
the
04-07-node.js_streams_add_forkpoint_for_continuedynamichtmlresumenode
branch
from
cf802b2 to
0720451
Compare
timneutkens
force-pushed
the
04-07-node.js_streams_add_forkpoint_for_error_recovery
branch
from
4d88d2f to
064e87d
Compare
gnoff
approved these changes
Apr 10, 2026
| ) | ||
| } | ||
|
|
||
| reactServerResult = new ReactServerResult( |
Contributor
There was a problem hiding this comment.
Are we keeping this class for this path? I thought we had implemented the replay stream class for this branch
Contributor
Author
There was a problem hiding this comment.
It uses ReplayableNodeStream under the hood when a nodestream is passed to it. Can switch it to use that directly if that's preferred.
Base automatically changed from
04-07-node.js_streams_add_forkpoint_for_error_recovery
to
canary
April 12, 2026 11:42
timneutkens
force-pushed
the
04-07-node.js_streams_add_forkpoint_for_continuedynamichtmlresumenode
branch
from
0720451 to
9c671c5
Compare
timneutkens
deleted the
04-07-node.js_streams_add_forkpoint_for_continuedynamichtmlresumenode
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Building on top of the changes in #92252. This PR implements similar fork points for continueDynamicHTMLResume