Node: add hkeys command - #2136
Merged
Merged
Conversation
GumpacG
approved these changes
Aug 15, 2024
Yury-Fridlyand
approved these changes
Aug 15, 2024
Yury-Fridlyand
left a comment
Yury-Fridlyand
left a comment
There was a problem hiding this comment.
LGTM assuming all comments addressed
| @@ -1,6 +1,5 @@ | |||
| # ignore that dir, because there are a lot of files which we don't manage, e.g. json files in cargo crates | |||
| rust-client/* | |||
| *.md | |||
Contributor
Author
There was a problem hiding this comment.
@adarovadya can you explain why this was added to the PR? I see it was you that added the ignore originally.
Signed-off-by: Adar Ovadia <adarov@amazon.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Adar Ovadia <adarov@amazon.com>
Signed-off-by: Adar Ovadia <adarov@amazon.com>
Signed-off-by: Adar Ovadia <adarov@amazon.com>
Signed-off-by: Adar Ovadia <adarov@amazon.com>
Signed-off-by: Adar Ovadia <adarov@amazon.com>
Signed-off-by: Adar Ovadia <adarov@amazon.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
acarbonetto
force-pushed
the
node/acarbo_add_hkeys
branch
from
August 15, 2024 19:46
6f4ea52 to
d22982a
Compare
affonsov
pushed a commit
that referenced
this pull request
Aug 21, 2026
* adds HKEYS command --------- Signed-off-by: Adar Ovadia <adarov@amazon.com> Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> Co-authored-by: Ubuntu <ubuntu@ip-172-31-20-143.eu-west-1.compute.internal> Co-authored-by: adarovadya <adarovadya@gmail.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Ubuntu <ubuntu@ip-172-31-41-43.eu-west-1.compute.internal> Co-authored-by: Adar Ovadia <adarov@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces: #1499