Skip to content

Node: adds HKEYS command - #1499

Closed
adarovadya wants to merge 7 commits into
valkey-io:mainfrom
adarovadya:hkeys-node
Closed

adarovadya wants to merge 7 commits into
valkey-io:mainfrom
adarovadya:hkeys-node

Conversation

@adarovadya

Copy link
Copy Markdown
Collaborator

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@adarovadya
adarovadya requested a review from a team as a code owner May 30, 2024 19:46
@adarovadya
adarovadya requested a review from shohamazon May 30, 2024 19:47
@Yury-Fridlyand Yury-Fridlyand added the node 🐢 Node.js wrapper label May 30, 2024

@Yury-Fridlyand Yury-Fridlyand left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add CHANGELOG entry

Comment thread node/src/BaseClient.ts Outdated
Comment thread node/src/Transaction.ts Outdated
Comment thread node/tests/SharedTests.ts Outdated
@adarovadya
adarovadya force-pushed the hkeys-node branch 2 times, most recently from ae7cc09 to 6e6dd88 Compare June 2, 2024 17:06
Comment thread node/.prettierignore Outdated
Comment thread CHANGELOG.md
Comment thread node/tests/SharedTests.ts
Comment thread node/src/Transaction.ts Outdated
Comment thread node/src/BaseClient.ts Outdated

@avifenesh avifenesh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments - they are minor

@avifenesh avifenesh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

Comment thread node/src/BaseClient.ts
@adarovadya
adarovadya requested a review from a team as a code owner July 11, 2024 10:38
Ubuntu and others added 6 commits July 11, 2024 10:39
Signed-off-by: Adar Ovadia <adarov@amazon.com>
Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Adar Ovadia <adarov@amazon.com>
Signed-off-by: Adar Ovadia <adarov@amazon.com>
Signed-off-by: Adar Ovadia <adarov@amazon.com>
Signed-off-by: Adar Ovadia <adarov@amazon.com>
Signed-off-by: Adar Ovadia <adarov@amazon.com>
Signed-off-by: Adar Ovadia <adarov@amazon.com>
Comment thread CHANGELOG.md
Comment thread node/src/BaseClient.ts
Comment thread node/src/Transaction.ts
@GumpacG

GumpacG commented Aug 20, 2024

Copy link
Copy Markdown
Contributor

Closing as #2136 took its place.

@GumpacG GumpacG closed this Aug 20, 2024
@adarovadya
adarovadya deleted the hkeys-node branch June 11, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

node 🐢 Node.js wrapper

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants