Skip to content

Various updates - #759

Merged
pkgw merged 4 commits into
tectonic-typesetting:masterfrom
pkgw:updates
Mar 29, 2021
Merged

Various updates#759
pkgw merged 4 commits into
tectonic-typesetting:masterfrom
pkgw:updates

Conversation

@pkgw

@pkgw pkgw commented Mar 27, 2021

Copy link
Copy Markdown
Collaborator

This PR addresses #754 and also touches things up for the new Rust release.

pkgw added 4 commits March 27, 2021 11:40
This addresses tectonic-typesetting#754, a hard-to-interpret failure and error message when
the engine tries to treat a directory named "latex" as the format file.
Here we change the filesystem code to simply ignore directories. I think
this is the best solution, since it means that we actually just run
correctly when such a directory exists, as opposed to failing but with a
more helpful error message.
It's been a while since I got Dependabot updates ... I think something
about the switch to the multi-crate setup may have made it stop running?
@codecov

codecov Bot commented Mar 27, 2021

Copy link
Copy Markdown

Codecov Report

Merging #759 (3825481) into master (c2557c2) will not change coverage.
The diff coverage is n/a.

❗ Current head 3825481 differs from pull request most recent head 925a9a1. Consider uploading reports for the commit 925a9a1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #759   +/-   ##
=======================================
  Coverage   46.81%   46.81%           
=======================================
  Files         119      119           
  Lines       53807    53807           
=======================================
  Hits        25189    25189           
  Misses      28618    28618           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2557c2...925a9a1. Read the comment docs.

@pkgw pkgw closed this Mar 29, 2021
@pkgw pkgw reopened this Mar 29, 2021
@pkgw

pkgw commented Mar 29, 2021

Copy link
Copy Markdown
Collaborator Author

The tectonic-on-arXiv changes here seem to all be due to the recent rounding fix (#758). It would be nice to be able to check my solution to #754 separately but I don't see any new build failures and I'm inclined to say that's good enough for me.

@pkgw
pkgw merged commit 94a6194 into tectonic-typesetting:master Mar 29, 2021
@pkgw
pkgw deleted the updates branch March 29, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant