Get an i686 build going - #758
Merged
Merged
Conversation
Hopefully this will help us catch any errors relating to 32-bit environments. Cf. tectonic-typesetting#749.
Codecov Report
@@ Coverage Diff @@
## master #758 +/- ##
=======================================
Coverage 46.81% 46.81%
=======================================
Files 119 119
Lines 53807 53807
=======================================
+ Hits 25188 25189 +1
+ Misses 28619 28618 -1
Continue to review full report at Codecov.
|
Collaborator
Author
|
The new i686 test is failing in the "right" place: in the |
We were generating slightly different outputs on x86_64 vs. i686 due to a floating-point rounding issue associated with the `unitsToPoints` function. The function used single-precision, and things start agreeing if we jump to double precision. So let's do that.
Collaborator
Author
|
i686 is working now! Current CI failures are something that seems to have started spontaneously, unrelated to this PR. |
Closed
It looks like we might need to update vcpkg to get those builds fully working again, *and* this is a good excuse to update the PR in the hopes that the new version of Rust (1.51) magically fixes the Windows test failures that popped up.
Collaborator
Author
|
Awwww heck yeah waiting actually worked! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re #749. The first commit adds i686 to the test framework, so the CI should fail due to the issue being reported in #749. That's what I get locally as well, at least.