merge: from 3.3.8 to main

[guanshengliang]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @guanshengliang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a series of enhancements and fixes, primarily focusing on improving the robustness of client-side monitoring, refining query planning for join operations, and standardizing documentation. The changes include more resilient handling of slow log files, a more intelligent approach to splitting join query plans, and a significant expansion of test coverage for join queries to validate their behavior under diverse conditions. These updates collectively aim to enhance system stability, improve query performance, and provide clearer documentation for user-defined functions.

Highlights

• Documentation Refinement: Standardized SQL code block formatting and capitalization in UDF documentation for improved clarity and consistency, and corrected a typo in a gcc command example.
• Enhanced Slow Log Handling: Improved the client monitor's readFile logic to robustly handle edge cases in slow log entries, such as excessively long or empty records, preventing potential parsing issues. The clientMonitorTest is now actively included in the build process to ensure these improvements are thoroughly tested.
• Query Planner Optimization for Joins: Introduced a new checkScanLogicNode function to refine the determination of subplan types (SCAN or MERGE) during single-table join planning, potentially leading to more efficient query execution.
• Expanded Join Query Test Coverage: Added a comprehensive suite of new test cases for various join types, focusing on specific timestamp and data conditions, to ensure the correctness and robustness of join operations.
• Improved Debuggability: Enhanced error logging in client heartbeat requests by including connection type information, which will aid in debugging network-related issues.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

• Ignored by pattern: .github/workflows/** (4)
  • .github/workflows/new-tdgpt-test.yml
  • .github/workflows/taoskeeper-test.yml
  • .github/workflows/tdengine-build.yml
  • .github/workflows/tdengine-check-enum.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a merge from a release branch and includes a variety of changes. The documentation for UDFs has been improved with better formatting and a typo fix. The client monitor logic for handling slow logs has been made more robust, with corresponding tests added. There are also some planner fixes related to join subplan types, and new test cases for join queries. The changes are generally good, but I've found a couple of minor issues in the documentation and test code that could be improved.

[gemini-code-assist]

There seems to be a typo in the column name. The table scores is created with a column varStr, but the query uses valStr. It should probably be varStr for consistency and correctness of the example.

Suggested change

	SELECT extract_avg(valStr) FROM scores;
	SELECT extract_avg(varStr) FROM scores;