merge: from 3.3.6 to 3.3.8

[guanshengliang]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @guanshengliang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates updates from versions 3.3.6 to 3.3.8, focusing on refining existing functionalities and improving system robustness. Key areas of improvement include enhancing user-facing documentation for User-Defined Functions (UDFs), making the client monitoring system more resilient to malformed slow log entries, and introducing a more intelligent subplan type determination within the query planner for join operations. These changes are complemented by an increase in test coverage, particularly for the client monitor's file reading logic and complex join queries, to validate the new behaviors and prevent regressions.

Highlights

• Documentation Enhancement: Improved clarity and consistency in UDF documentation by standardizing SQL syntax, capitalizing keywords, and refining code block formatting.
• Client Monitor Robustness: Enhanced the client monitor's slow log reading logic to correctly handle various edge cases, including oversized or empty log entries, and improved memory allocation.
• Query Planner Refinement: Modified the query planner to dynamically determine the subplan type (scan or merge) for exchange nodes during join splitting, improving query optimization logic.
• Expanded Test Coverage: Activated and added new unit tests for the client monitor's file reading mechanism and expanded integration tests for various join types, ensuring stability and correctness.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The code changes include modifications to the documentation file docs/en/07-develop/09-udf.md to correct SQL code examples and update code blocks. Additionally, changes were made to source/client/src/clientMonitor.c to adjust timer reset logic and file reading, along with updates to source/client/test/CMakeLists.txt and source/client/test/clientMonitorTests.cpp to enhance client monitoring tests. The files source/libs/planner/inc/planInt.h, source/libs/planner/src/planSpliter.c, and source/libs/planner/src/planUtil.c were modified to improve query planning and logic node checks. The file test/cases/14-JoinQueries/test_join_full.py was updated to include additional test cases for join queries. The review comments point out a typo in the log output example within the documentation, suggesting that myspead be corrected to myspread.

[gemini-code-assist]

There is a typo in the log output example. myspead should be myspread to match the function name.

Suggested change

	init function myspead success
	init function myspread success