fix: fetch body - #9801
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: c788235 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
I'm not sure why it says no changeset found, I generated one and it's in the |
Member
|
The changeset needs to be created from the root of the repo. It looks like you initialized another changesets installation within the |
teemingc
reviewed
Apr 29, 2023
Member
|
For posterity: it looks like the reason this is okay is that we just don't serialize |
Co-authored-by: Tee Ming <chewteeming01@gmail.com>
Rich-Harris
approved these changes
May 4, 2023
Member
|
thank you! |
Merged
Rich-Harris
pushed a commit
that referenced
this pull request
Jul 28, 2026
… is not a string or TypedArray (#16501) A universal load `fetch` with a `URLSearchParams`, `FormData` or `Blob` body crashes SSR with `TypeError: value must be a string or TypedArray` when the response would be inlined. #1385 guarded serialization on the request body being a string, #6565 re-pointed the check at the response body, and #9801 removed the throw that had been masking the loss. This restores the guard. The response isn't serialized and the browser repeats the fetch. The client lookup gets the same rule. It hashed only the headers when it couldn't hash the body, so during hydration such a fetch could resolve with a different same-url request's serialized response instead of being sent. Both tests fail on the base branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Provided fetch function accepts the same object types in the body as the native fetch function
See #9420
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.