account for POST bodies when serializing fetches - #1385
Merged
Conversation
Member
|
Additionally supporting JSON doesn't seem like it should be too hard and might be worth it if it helps add GraphQL support. Though presumably those users could just serialize the JSON to a string themselves before calling |
Member
Author
|
JSON is a string. You don't post |
Rich-Harris
pushed a commit
that referenced
this pull request
Jul 28, 2026
… is not a string or TypedArray (#16501) A universal load `fetch` with a `URLSearchParams`, `FormData` or `Blob` body crashes SSR with `TypeError: value must be a string or TypedArray` when the response would be inlined. #1385 guarded serialization on the request body being a string, #6565 re-pointed the check at the response body, and #9801 removed the throw that had been masking the loss. This restores the guard. The response isn't serialized and the browser repeats the fetch. The client lookup gets the same rule. It hashed only the headers when it couldn't hash the body, so during hydration such a fetch could resolve with a different same-url request's serialized response instead of being sent. Both tests fail on the base branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #633. Figured the pragmatic choice is to ignore requests with a non-string body (as in, they don't get serialized; those fetches are repeated in the client) since other kinds are unlikely in
load(presumably the main situation where this is useful is with GraphQL, which uses a JSON payload) and it would be undesirable to buffer streams, etc.Handling other kinds of bodies is a TODO in any case:
kit/packages/kit/src/runtime/server/page/load_node.js
Lines 148 to 159 in 7679399
In fact, I think for now it might be best to throw an error if non-string bodies are sent in
fetchinload. Better than silently failing. Though either way it should affect roughly zero people.Before submitting the PR, please make sure you do the following
Tests
pnpm testand lint the project withpnpm lintChangesets
pnpx changesetand following the prompts