Skip to content

perf: cache the default cookie header parse and avoid allocations in cookies.get - #16341

Merged
Rich-Harris merged 2 commits into
sveltejs:version-3from
Nic-Polumeyv:perf-cookies-get-cache
Jul 16, 2026
Merged

perf: cache the default cookie header parse and avoid allocations in cookies.get#16341
Rich-Harris merged 2 commits into
sveltejs:version-3from
Nic-Polumeyv:perf-cookies-get-cache

Conversation

@Nic-Polumeyv

@Nic-Polumeyv Nic-Polumeyv commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

closes #16340

get_cookies parsed the header once but with an identity decode, so every cookies.get() re-parsed the whole header, and also allocated, filtered and sorted an array of locally set cookies even when there were none. No behavior change, three things:

  • the default-decode parse is now cached for the lifetime of the request, since the header never changes. A custom opts.decode bypasses the cache, and there is a test pinning that.
  • the best-match scan in get is a single pass instead of Array.from().filter().sort()[0], no allocations, same tie-breaking (first inserted wins, as with the stable sort).
  • getAll copies the parsed object before merging locally set cookies into it, so the cache is never mutated.

Measured on the real get_cookies with a realistic ~800B header and five get calls per request: 6.00µs before, 2.98µs after. Parse cost scales linearly with header size, about 1µs per KB.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 14, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 10a86d2:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/10a86d2608e7c0094ff8a1e5c2948f1d044c4803

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16341

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 10a86d2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris

Copy link
Copy Markdown
Member

Hey — we really appreciate all the recent contributions, but we're mostly working on the version-3 branch, and PRs against main are liable to cause merge conflicts. Can I ask you to submit future PRs against version-3 instead? (I've just updated the default branch to point there — should probably have done that sooner.) Updating the existing PRs to point to version-3 would be even better but no worries if that proves troublesome

@Nic-Polumeyv

Nic-Polumeyv commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Not a problem at all with some AI help, sorry for this! Thanks for the heads up. Working on it now

@Nic-Polumeyv
Nic-Polumeyv changed the base branch from main to version-3 July 15, 2026 01:06
@Nic-Polumeyv
Nic-Polumeyv force-pushed the perf-cookies-get-cache branch from 40f4699 to 10a86d2 Compare July 15, 2026 01:06

@Rich-Harris Rich-Harris left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Rich-Harris
Rich-Harris merged commit c1ee782 into sveltejs:version-3 Jul 16, 2026
17 of 18 checks passed
Rich-Harris pushed a commit that referenced this pull request Jul 17, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to version-3, this PR
will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`version-3` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `version-3`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @sveltejs/kit@3.0.0-next.9

### Major Changes

- breaking: `handle`'s `resolve` is now typed to always return a
`Promise` ([#16352](#16352))

- breaking: replace the `$lib` alias with `#lib` and remove `files.lib`
config. ([#16360](#16360))

- breaking: disallow cross-origin form submissions without a
`Content-Type` header
([#16347](#16347))

- breaking: Server-only directories (`/server/` in the path) are now
treated as server-only everywhere inside the project (except
`src/routes` and the assets directory)
([#16360](#16360))

- breaking: delegate CORS handling to Vite for static directory requests
during development
([#16357](#16357))

### Minor Changes

- feat: reinstate `$env/static/private`, `$env/dynamic/private`,
`$env/static/public`, `$env/dynamic/public` and `$app/environment` as
deprecated aliases for `$app/env/private` `$app/env/public` and
`$app/env` ([#16334](#16334))

### Patch Changes

- perf: cache the default cookie header parse and avoid allocations in
`cookies.get` ([#16341](#16341))

- fix: avoid client-side code being bundled by Cloudflare Wrangler
([#16364](#16364))

- fix: handle rejected streamed server data after delayed loads
([#16268](#16268))

- fix: enable CSRF protection in builds with a non-production `NODE_ENV`
value ([#16313](#16313))
## @sveltejs/package@3.0.0-next.3

### Minor Changes

- feat: transform import aliases into relative imports in files
([#16360](#16360))
## @sveltejs/adapter-node@6.0.0-next.4

### Patch Changes

- fix: correctly bundle entrypoints on Windows
([#16367](#16367))
- Updated dependencies
[[`c1ee782`](c1ee782),
[`1a1b3ea`](1a1b3ea),
[`6423d98`](6423d98),
[`6d1f4f0`](6d1f4f0),
[`5ca9906`](5ca9906),
[`b148d31`](b148d31),
[`5ca9906`](5ca9906),
[`9f3d9bb`](9f3d9bb),
[`7bfd922`](7bfd922),
[`ffa0e3b`](ffa0e3b)]:
  - @sveltejs/kit@3.0.0-next.9
## @sveltejs/enhanced-img@1.0.0-next.2

### Patch Changes

- chore: replace the `$lib` alias with `#lib` in docs
([#16360](#16360))

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Nic-Polumeyv
Nic-Polumeyv deleted the perf-cookies-get-cache branch July 30, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cookies.get() re-parses the cookie header on every call

2 participants