feat: Add minOutShares to weETH (DEV-1121) by supercontracts · Pull Request #223 · sparkdotfi/spark-alm-controller

supercontracts · 2026-01-28T07:57:55Z

Summary by CodeRabbit

Release Notes

New Features
- Enhanced weETH deposits with configurable slippage protection, requiring specification of minimum acceptable shares output.
Tests
- Expanded test suite to validate slippage protection and associated deposit scenarios.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

octane-security-app · 2026-01-28T07:58:00Z

Summary by Octane

New Contracts

No new contracts were added.

Updated Contracts

MainnetController.sol: A minimum shares output parameter was added to the depositToWeETH function for enhanced control over deposit outcomes.
WeETHLib.sol: Added functions to calculate shares for a given amount and set minimum shares on deposits to manage slippage.

🔗 Commit Hash: 7423165

coderabbitai · 2026-01-28T07:58:15Z

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🔍 Trigger a full review

Walkthrough

A new minSharesOut parameter is added to the weETH deposit flow in MainnetController and WeETHLib.deposit to enforce slippage protection. The deposit function now validates that the shares received meet the minimum threshold, reverting with "MC/slippage-too-high" if exceeded. Tests are updated to accommodate the new parameter and validate slippage behavior.

Changes

Cohort / File(s)	Summary
Slippage Check Implementation `src/MainnetController.sol`, `src/libraries/WeETHLib.sol`	Added `minSharesOut` parameter to `depositToWeETH` and `WeETHLib.deposit` functions. WeETHLib.deposit now enforces a require check ensuring `shares >= minSharesOut` for slippage protection. New `sharesForAmount` view function added to ILiquidityPoolLike interface.
Test Coverage `test/mainnet-fork/weETH.t.sol`	Updated all `depositToWeETH` calls to include `minSharesOut` parameter (0 or computed value). Added internal helper `_getMinSharesOut` returning 99% of liquidityPool share amount. Introduced `test_depositToWeETH_slippageTooHigh` test to validate slippage revert condition.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

[DEV-1041] : Add weETH integration #215: Introduces the weETH deposit integration that this PR extends with slippage protection via the new minSharesOut parameter and validation.

Suggested reviewers

lucas-manuel

Poem

🐰 A slippage guard hops into view,
weETH shares now checked through and through,
With minSharesOut to protect the way,
No sneaky slips shall come our day! 🥕✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title 'feat: Add minOutShares to weETH (DEV-1121)' follows the required format (starts with 'feat:'), is concise and descriptive, accurately reflects the main changes (adding a minOutShares/minSharesOut parameter for slippage control), and includes the JIRA key.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch DEV-1121-add-minout

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)

DEV-1121: Entity not found: Issue - Could not find referenced Issue.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

octane-security-app · 2026-01-28T08:40:58Z

Overview

Warnings found:	1

🔗 Commit Hash: 7423165
🛡️ Octane Dashboard: All vulnerabilities

lucas-manuel · 2026-01-28T16:21:47Z

    function amountForShare(uint256 shareAmount) external view returns (uint256);
    function deposit() external;
    function requestWithdraw(address receiver,uint256 amount) external returns (uint256 requestId);
+    function sharesForAmount(uint256 amount) external view returns (uint256);


Remove this

removed this

lucas-manuel · 2026-01-28T16:22:16Z

    }

+    function _getMinSharesOut(uint256 amount) internal view returns (uint256) {
+        return liquidityPool.sharesForAmount(amount) * 99 / 100;


Should define ILiquidityPoolLike in the test file if it has a different interface

defined a different interface

lucas-manuel · 2026-01-28T16:22:42Z

+
+        vm.prank(relayer);
+        vm.expectRevert("MC/slippage-too-high");
+        mainnetController.depositToWeETH(1_000e18, 1_000e18);


Try minSharesOut + 1 here

lucas-manuel · 2026-01-28T16:22:49Z

+        mainnetController.depositToWeETH(1_000e18, 0);
+    }
+
+    function test_depositToWeETH_slippageTooHigh() external {


slippageTooHighBoundary

github-actions · 2026-01-29T12:19:48Z

Coverage after merging DEV-1121-add-minout into dev will be

99.40%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
deploy
ControllerDeploy.sol	100%	100%	100%	100%
ForeignControllerInit.sol	100%	100%	100%	100%
MainnetControllerInit.sol	97.37%	93.33%	100%	100%	152, 90
src
ALMProxy.sol	100%	100%	100%	100%
ALMProxyFreezable.sol	100%	100%	100%	100%
ForeignController.sol	94.90%	84.62%	95.65%	97.22%	128–129, 129, 129, 316–317, 573
MainnetController.sol	99.18%	100%	98.36%	99.24%	593–594
OTCBuffer.sol	100%	100%	100%	100%
RateLimitHelpers.sol	100%	100%	100%	100%
RateLimits.sol	100%	100%	100%	100%
WEETHModule.sol	92.86%	75%	100%	100%	26, 38
src/libraries
AaveLib.sol	100%	100%	100%	100%
ApproveLib.sol	100%	100%	100%	100%
CCTPLib.sol	100%	100%	100%	100%
CurveLib.sol	100%	100%	100%	100%
ERC4626Lib.sol	96%	75%	100%	100%	108
LayerZeroLib.sol	100%	100%	100%	100%
PSMLib.sol	100%	100%	100%	100%
UniswapV4Lib.sol	99.32%	95.65%	100%	100%	282
WEETHLib.sol	100%	100%	100%	100%

add: minOutShares to weETH

7423165

supercontracts requested review from deluca-mike and lucas-manuel January 28, 2026 07:57

supercontracts self-assigned this Jan 28, 2026

supercontracts added Priority: High Status: Ready for Review labels Jan 28, 2026

coderabbitai Bot previously approved these changes Jan 28, 2026

View reviewed changes

supercontracts changed the title ~~[DEV 1121] add minOutShares to weETH~~ feat: Add minOutShares to weETH [DEV 1121] Jan 28, 2026

supercontracts changed the title ~~feat: Add minOutShares to weETH [DEV 1121]~~ feat: Add minOutShares to weETH (DEV 1121) Jan 28, 2026

lucas-manuel requested changes Jan 28, 2026

View reviewed changes

supercontracts changed the title ~~feat: Add minOutShares to weETH (DEV 1121)~~ feat: Add minOutShares to weETH (DEV-1121) Jan 28, 2026

supercontracts added 2 commits January 28, 2026 23:22

file name change 1

aa35216

file name change

49f822d

lucas-manuel added Status: Revisions Needed and removed Status: Ready for Review labels Jan 28, 2026

fix: review

42a40eb

supercontracts dismissed coderabbitai[bot]’s stale review via 42a40eb January 28, 2026 18:03

supercontracts added Status: Ready for Review and removed Status: Revisions Needed labels Jan 28, 2026

supercontracts added 2 commits January 28, 2026 23:56

Merge branch 'dev' into DEV-1121-add-minout

69d6bbc

Merge branch 'dev' into DEV-1121-add-minout

a69ad88

deluca-mike previously approved these changes Jan 28, 2026

View reviewed changes

deluca-mike dismissed their stale review via 3a85501 January 28, 2026 20:32

deluca-mike requested a review from lucas-manuel January 28, 2026 20:32

fix: old import naming

ddbb792

deluca-mike force-pushed the DEV-1121-add-minout branch from 3a85501 to ddbb792 Compare January 29, 2026 05:36

Merge branch 'dev' into DEV-1121-add-minout

860a315

lucas-manuel approved these changes Jan 29, 2026

View reviewed changes

lucas-manuel merged commit e8315ca into dev Jan 29, 2026
4 checks passed

lucas-manuel deleted the DEV-1121-add-minout branch January 29, 2026 12:20

coderabbitai Bot mentioned this pull request Feb 9, 2026

fix: added minEETHShares to WeETH withdraw request (DEV-1228) #241

Merged

Navigation Menu

feat: Add minOutShares to weETH (DEV-1121) - #223

feat: Add minOutShares to weETH (DEV-1121)#223
lucas-manuel merged 8 commits into
devfrom
DEV-1121-add-minout

supercontracts commented Jan 28, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

octane-security-app Bot commented Jan 28, 2026

Uh oh!

coderabbitai Bot commented Jan 28, 2026 •

edited

Loading

Review skipped

Review ran into problems

Uh oh!

octane-security-app Bot commented Jan 28, 2026

Uh oh!

lucas-manuel Jan 28, 2026

Uh oh!

supercontracts Jan 28, 2026

Uh oh!

lucas-manuel Jan 28, 2026

Uh oh!

supercontracts Jan 28, 2026

Uh oh!

lucas-manuel Jan 28, 2026

Uh oh!

supercontracts Jan 28, 2026

Uh oh!

lucas-manuel Jan 28, 2026

Uh oh!

supercontracts Jan 28, 2026

Uh oh!

github-actions Bot commented Jan 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

supercontracts commented Jan 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Release Notes

Uh oh!

octane-security-app Bot commented Jan 28, 2026

Summary by Octane

New Contracts

Updated Contracts

Uh oh!

coderabbitai Bot commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Review ran into problems

Uh oh!

octane-security-app Bot commented Jan 28, 2026

Overview

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jan 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

supercontracts commented Jan 28, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jan 28, 2026 •

edited

Loading