fix: review

Author: supercontracts

src/MainnetController.sol

@@ -24,7 +24,7 @@ import { ERC4626Lib }                     from "./libraries/ERC4626Lib.sol";
 import { LayerZeroLib }                   from "./libraries/LayerZeroLib.sol";
 import { IDaiUsdsLike, IPSMLike, PSMLib } from "./libraries/PSMLib.sol";
 import { UniswapV4Lib }                   from "./libraries/UniswapV4Lib.sol";
-import { WeETHLib }                       from "./libraries/WeETHLib.sol";
+import { WEETHLib }                       from "./libraries/WEETHLib.sol";
 
 import { RateLimitHelpers } from "./RateLimitHelpers.sol";
 
@@ -165,9 +165,9 @@ contract MainnetController is ReentrancyGuard, AccessControlEnumerable {
     bytes32 public LIMIT_USDE_MINT               = keccak256("LIMIT_USDE_MINT");
     bytes32 public LIMIT_USDS_MINT               = keccak256("LIMIT_USDS_MINT");
     bytes32 public LIMIT_USDS_TO_USDC            = keccak256("LIMIT_USDS_TO_USDC");
-    bytes32 public LIMIT_WEETH_CLAIM_WITHDRAW    = WeETHLib.LIMIT_WEETH_CLAIM_WITHDRAW;
-    bytes32 public LIMIT_WEETH_DEPOSIT           = WeETHLib.LIMIT_WEETH_DEPOSIT;
-    bytes32 public LIMIT_WEETH_REQUEST_WITHDRAW  = WeETHLib.LIMIT_WEETH_REQUEST_WITHDRAW;
+    bytes32 public LIMIT_WEETH_CLAIM_WITHDRAW    = WEETHLib.LIMIT_WEETH_CLAIM_WITHDRAW;
+    bytes32 public LIMIT_WEETH_DEPOSIT           = WEETHLib.LIMIT_WEETH_DEPOSIT;
+    bytes32 public LIMIT_WEETH_REQUEST_WITHDRAW  = WEETHLib.LIMIT_WEETH_REQUEST_WITHDRAW;
     bytes32 public LIMIT_WSTETH_DEPOSIT          = keccak256("LIMIT_WSTETH_DEPOSIT");
     bytes32 public LIMIT_WSTETH_REQUEST_WITHDRAW = keccak256("LIMIT_WSTETH_REQUEST_WITHDRAW");
 
@@ -497,7 +497,7 @@ contract MainnetController is ReentrancyGuard, AccessControlEnumerable {
     {
         _checkRole(RELAYER);
 
-        shares = WeETHLib.deposit({
+        shares = WEETHLib.deposit({
             proxy        : proxy,
             rateLimits   : rateLimits,
             amount       : amount,
@@ -513,7 +513,7 @@ contract MainnetController is ReentrancyGuard, AccessControlEnumerable {
     {
         _checkRole(RELAYER);
 
-        requestId = WeETHLib.requestWithdraw({
+        requestId = WEETHLib.requestWithdraw({
             proxy       : proxy,
             rateLimits  : rateLimits,
             weETHShares : weETHShares,
@@ -529,7 +529,7 @@ contract MainnetController is ReentrancyGuard, AccessControlEnumerable {
     {
         _checkRole(RELAYER);
 
-        ethReceived = WeETHLib.claimWithdrawal({
+        ethReceived = WEETHLib.claimWithdrawal({
             proxy       : proxy,
             rateLimits  : rateLimits,
             requestId   : requestId,

src/WeEthModule2.sol src/WEETHModule.solsrc/WeEthModule2.sol renamed to src/WEETHModule.sol

@@ -14,7 +14,7 @@ interface IWithdrawRequestNFTLike {
     function isValid(uint256 requestId) external view returns (bool);
 }
 
-contract WeEthModule is AccessControlEnumerable {
+contract WEETHModule is AccessControlEnumerable {
 
     address public immutable almProxy;
 

src/libraries/WEETHLib.sol

@@ -21,7 +21,6 @@ interface ILiquidityPoolLike {
     function amountForShare(uint256 shareAmount) external view returns (uint256);
     function deposit() external;
     function requestWithdraw(address receiver,uint256 amount) external returns (uint256 requestId);
-    function sharesForAmount(uint256 amount) external view returns (uint256);
     function withdrawRequestNFT() external view returns (address);
 }
 
@@ -41,7 +40,7 @@ interface IWETHLike {
     function withdraw(uint256 amount) external;
 }
 
-library WeETHLib {
+library WEETHLib {
 
     bytes32 public constant LIMIT_WEETH_CLAIM_WITHDRAW   = keccak256("LIMIT_WEETH_CLAIM_WITHDRAW");
     bytes32 public constant LIMIT_WEETH_DEPOSIT          = keccak256("LIMIT_WEETH_DEPOSIT");

test/mainnet-fork/weETH.t.sol

@@ -3,12 +3,18 @@ pragma solidity >=0.8.0;
 
 import { ReentrancyGuard } from "../../lib/openzeppelin-contracts/contracts/utils/ReentrancyGuard.sol";
 
-import { IWEETHLike, ILiquidityPoolLike, IEETHLike } from "../../src/libraries/WeETHLib.sol";
+import { IWEETHLike, IEETHLike } from "../../src/libraries/WeETHLib.sol";
 
-import { WeEthModule } from "../../src/WeEthModule.sol";
+import { WEETHModule } from "../../src/WEETHModule.sol";
 
 import "./ForkTestBase.t.sol";
 
+interface ILiquidityPoolLike {
+    function amountForShare(uint256 shareAmount) external view returns (uint256);
+    function sharesForAmount(uint256 amount) external view returns (uint256);
+    function withdrawRequestNFT() external view returns (address);
+}
+
 interface IWithdrawRequestNFTLike {
     function finalizeRequests(uint256 requestId) external;
     function getClaimableAmount(uint256 requestId) external view returns (uint256);
@@ -39,15 +45,15 @@ contract MainnetControllerWeETHTestBase is ForkTestBase {
         eETH          = IEETHLike(address(IWEETHLike(Ethereum.WEETH).eETH()));
         liquidityPool = ILiquidityPoolLike(IEETHLike(eETH).liquidityPool());
 
-        weETHModule = address(new WeEthModule(Ethereum.SPARK_PROXY, address(almProxy)));
+        weETHModule = address(new WEETHModule(Ethereum.SPARK_PROXY, address(almProxy)));
     }
 
     function _getBlock() internal override pure returns (uint256) {
         return 23469772; //  September 29, 2025
     }
 
     function _getMinSharesOut(uint256 amount) internal view returns (uint256) {
-        return liquidityPool.sharesForAmount(amount) * 99 / 100;
+        return liquidityPool.sharesForAmount(amount) - 1;
     }
 
 }
@@ -91,7 +97,7 @@ contract MainnetControllerDepositToWeETHFailureTests is MainnetControllerWeETHTe
         mainnetController.depositToWeETH(1_000e18, 0);
     }
 
-    function test_depositToWeETH_slippageTooHigh() external {
+    function test_depositToWeETH_slippageTooHighBoundary() external {
         bytes32 key = mainnetController.LIMIT_WEETH_DEPOSIT();
 
         vm.prank(Ethereum.SPARK_PROXY);
@@ -103,7 +109,7 @@ contract MainnetControllerDepositToWeETHFailureTests is MainnetControllerWeETHTe
 
         vm.prank(relayer);
         vm.expectRevert("MC/slippage-too-high");
-        mainnetController.depositToWeETH(1_000e18, 1_000e18);
+        mainnetController.depositToWeETH(1_000e18, minSharesOut + 1);
 
         vm.prank(relayer);
         mainnetController.depositToWeETH(1_000e18, minSharesOut);